arturobernalg commented on code in PR #285:
URL: https://github.com/apache/jspwiki/pull/285#discussion_r1232686468
##
pom.xml:
##
@@ -722,6 +722,12 @@
org.mockito
mockito-core
${mockito.version}
+
Review Comment:
mmm
arturobernalg commented on code in PR #285:
URL: https://github.com/apache/jspwiki/pull/285#discussion_r1232686468
##
pom.xml:
##
@@ -722,6 +722,12 @@
org.mockito
mockito-core
${mockito.version}
+
Review Comment:
mmm
juanpablo-santos commented on code in PR #285:
URL: https://github.com/apache/jspwiki/pull/285#discussion_r1231608214
##
pom.xml:
##
@@ -722,6 +722,12 @@
org.mockito
mockito-core
${mockito.version}
+
Review Comment:
arturobernalg opened a new pull request, #285:
URL: https://github.com/apache/jspwiki/pull/285
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
juanpablo-santos merged pull request #22:
URL: https://github.com/apache/jspwiki/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #22:
URL: https://github.com/apache/jspwiki/pull/22
Bumps [wro4j-maven-plugin](https://github.com/wro4j/wro4j) from 1.8.0 to
1.10.1.
Release notes
Sourced from https://github.com/wro4j/wro4j/releases";>wro4j-maven-plugin
x27;t
do any compression.) But if wro4j provides other benefits, it's OK with me.
However, the roughly 30-45 second delay every time we do an mvn test
-Dtest= just to have the JS and CSS get re-compressed and re-linted
from scratch is very irritating/draining (and was happening even before
Hi,
I don't have the time right now to dig into what you guys are proposing
with wro4j so I
can only add a cautionary tale to the table. I imagine that the vast
majority of JSPWiki
users (i.e., installers) will be modifying the PlainVanilla theme to create
a style that
matches their indiv
On 08/07/2013 05:47 AM, Dirk Frederickx wrote:
One of the main advantages for using wro4j at RUNTIME, is that the wro4j
filter also GZIP's the JS and CSS files. This has an enormous impact on
the size of these files, and we should definitely consider to add this to
JSPWiki in the f
Glen,
>>inline feedback
On Wed, Aug 7, 2013 at 1:15 AM, Glen Mazza wrote:
> Hi Dirk, some comments and a question:
>
>
> On 08/04/2013 05:49 PM, Dirk Frederickx wrote:
>
>> Hi all,
>>
>> I recently added WRO4J to the build chain of JSPWIKI. (see
>
gt; It would be nice to have an option to skip this wro4j step when running
> (individual) mvn tests, cause the wro4j step takes quite a bit of time.
>
> kind regards,
> Harry
>
>
>
> On 4 August 2013 23:49, Dirk Frederickx wrote:
>
> > Hi all,
> >
> >
Hi,
I'm +1 on this. We're beginning to use wro4j at work for some simple cases,
only compression and minification, and I'd be interested in seeing some
more complex use cases :-)
thx,
juan pablo
p.d.: @Glen, unless I'm mistaken, we're currently using wro4j at
build-tim
Hi Dirk, some comments and a question:
On 08/04/2013 05:49 PM, Dirk Frederickx wrote:
Hi all,
I recently added WRO4J to the build chain of JSPWIKI. (see
https://issues.apache.org/jira/browse/JSPWIKI-761 for more details)
The main goal is the introduction of a proper build system for the JS
+0.5
I have very little knowledge/experience with js and css. I trust what you
say is the right thing to do.
It would be nice to have an option to skip this wro4j step when running
(individual) mvn tests, cause the wro4j step takes quite a bit of time.
kind regards,
Harry
On 4 August 2013 23
Hi all,
I recently added WRO4J to the build chain of JSPWIKI. (see
https://issues.apache.org/jira/browse/JSPWIKI-761 for more details)
The main goal is the introduction of a proper build system for the JS and
CSS files, allowing to move away from the current monolithic JS and CSS
files, and
[
https://issues.apache.org/jira/browse/JSPWIKI-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
brushed resolved JSPWIKI-761.
-
Resolution: Fixed
Fix Version/s: 2.10
Implemented in 2.10.0-svn-27
> Use wr
[
https://issues.apache.org/jira/browse/JSPWIKI-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727901#comment-13727901
]
brushed commented on JSPWIKI-761:
-
Implementing the WRO4J ( Web Resource Optimizer
17 matches
Mail list logo
