[jira] [Updated] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-02-26 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-671: - Attachment: outOfMemFix-v5.patch Yes it can be simplified. > DelayedProd

[jira] [Assigned] (KAFKA-330) Add delete topic support

2013-02-26 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon reassigned KAFKA-330: - Assignee: Neha Narkhede (was: Prashanth Menon) > Add delete topic support >

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-02-26 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587167#comment-13587167 ] Prashanth Menon commented on KAFKA-330: --- Apologies for not getting to this. Neha, go

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587423#comment-13587423 ] Jay Kreps commented on KAFKA-656: - Yes, that is basic idea. The concern with ewma is just t

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587447#comment-13587447 ] Jonathan Creasy commented on KAFKA-656: --- That makes sense. Thinking about this last n

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587466#comment-13587466 ] Jay Kreps commented on KAFKA-656: - Yeah this a bit of a dilemma. Doing it cluster-wide with

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587507#comment-13587507 ] Jonathan Creasy commented on KAFKA-656: --- Thinking about it that way, keeping the quot

[jira] [Closed] (KAFKA-604) Add missing metrics in 0.8

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-604. --- > Add missing metrics in 0.8 > -- > > Key: KAFKA-604 >

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587545#comment-13587545 ] Neha Narkhede commented on KAFKA-671: - +1. If others don't have any other input, I will

[jira] [Created] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-774: --- Summary: Periodic refresh of topic metadata on the producer does not check for error code in the response Key: KAFKA-774 URL: https://issues.apache.org/jira/browse/KAFKA-774

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Labels: p1 (was: ) > Periodic refresh of topic metadata on the producer does not check for erro

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Attachment: kafka-774.patch Minor patch, probably could even skip review. The error code for partiti

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Status: Patch Available (was: Open) > Periodic refresh of topic metadata on the producer does n

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587614#comment-13587614 ] Swapnil Ghike commented on KAFKA-774: - Useful stuff, +1. > Periodic re

[jira] [Updated] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-773: Attachment: kafka-773-v2.patch Yes you're right. Attached patch v2. > kafka.integra

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Attachment: kafka-774-v2.patch Thanks for the quick review, Swapnil. While reviewing the server side

[jira] [Commented] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587716#comment-13587716 ] Neha Narkhede commented on KAFKA-773: - Looks good, +1 > kafka.integrat

[jira] [Resolved] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-773. - Resolution: Fixed Thanks for patch v3, checked in > kafka.integration.PrimitiveAp

[jira] [Closed] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-773. --- > kafka.integration.PrimitiveApiTest fails intermittently > --

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587737#comment-13587737 ] Swapnil Ghike commented on KAFKA-774: - I doubt if the v2 patch will do what it intends

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587742#comment-13587742 ] Neha Narkhede commented on KAFKA-774: - Not sure if I understood your point about consol

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587747#comment-13587747 ] Swapnil Ghike commented on KAFKA-774: - Yes, your change consolidates everything, which

[jira] [Comment Edited] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587747#comment-13587747 ] Swapnil Ghike edited comment on KAFKA-774 at 2/26/13 11:55 PM: --

[jira] [Created] (KAFKA-775) Very long error message on the producer during produce requests failures

2013-02-26 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-775: --- Summary: Very long error message on the producer during produce requests failures Key: KAFKA-775 URL: https://issues.apache.org/jira/browse/KAFKA-775 Project: Kafka

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Attachment: kafka-774-v3.patch I see your concern here. The reason we convert those exceptions to on

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587788#comment-13587788 ] Swapnil Ghike commented on KAFKA-774: - Yup, looks good. +1 > Periodic

[jira] [Updated] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-774: Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews, checked i

[jira] [Closed] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-774. --- > Periodic refresh of topic metadata on the producer does not check for error > code in the response

[jira] [Work started] (KAFKA-775) Very long error message on the producer during produce requests failures

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-775 started by Neha Narkhede. > Very long error message on the producer during produce requests failures > --

[jira] [Updated] (KAFKA-775) Very long error message on the producer during produce requests failures

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-775: Status: Patch Available (was: In Progress) diff --git a/core/src/main/scala/kafka/producer/async/De

[jira] [Updated] (KAFKA-775) Very long error message on the producer during produce requests failures

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-775: Resolution: Fixed Status: Resolved (was: Patch Available) Checked in without review since i

[jira] [Closed] (KAFKA-775) Very long error message on the producer during produce requests failures

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-775. --- > Very long error message on the producer during produce requests failures > -

[jira] [Closed] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-671. --- > DelayedProduce requests should not hold full producer request data > ---

[jira] [Updated] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-671: Resolution: Fixed Status: Resolved (was: Patch Available) Checked in patch v5

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v3.patch Rebased. All comments are the same as those on patch v2.

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587853#comment-13587853 ] Jonathan Creasy commented on KAFKA-656: --- I could implement the checks as meters in th

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2013-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587997#comment-13587997 ] Jay Kreps commented on KAFKA-656: - Yes, it would definitely make sense to use a metric for