[jira] [Commented] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-15 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794966#comment-13794966 ] Swapnil Ghike commented on KAFKA-1087: -- Same patch should apply fine to trunk.

[jira] [Commented] (KAFKA-1084) Validate properties for custom serializers

2013-10-15 Thread Francois Saint-Jacques (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795202#comment-13795202 ] Francois Saint-Jacques commented on KAFKA-1084: --- I believe a warning will

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14638/#review27028 --- Ship it! Only one minor comment below.

[jira] [Resolved] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1087. -- Resolution: Fixed Thanks for the patch. Checked into 0.8 and trunk Empty topic list causes

[jira] [Closed] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1087. Empty topic list causes consumer to fetch metadata of all topics

[jira] [Assigned] (KAFKA-1084) Validate properties for custom serializers

2013-10-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-1084: -- Assignee: Francois Saint-Jacques Validate properties for custom serializers

[jira] [Resolved] (KAFKA-1084) Validate properties for custom serializers

2013-10-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1084. Resolution: Fixed Fix Version/s: 0.8.1 Yes, you are right. +1 on the patch. Committed to trunk.

[jira] [Closed] (KAFKA-1084) Validate properties for custom serializers

2013-10-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-1084. -- Validate properties for custom serializers -- Key:

[jira] [Commented] (KAFKA-417) NullPointerException in ZookeeperConsumerConnector

2013-10-15 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795384#comment-13795384 ] Andrew Olson commented on KAFKA-417: bq. Would you mind retrying this using the latest

[jira] [Created] (KAFKA-1088) Ability to create a shadow consumer group

2013-10-15 Thread Andrew Olson (JIRA)
Andrew Olson created KAFKA-1088: --- Summary: Ability to create a shadow consumer group Key: KAFKA-1088 URL: https://issues.apache.org/jira/browse/KAFKA-1088 Project: Kafka Issue Type: New

[jira] [Resolved] (KAFKA-417) NullPointerException in ZookeeperConsumerConnector

2013-10-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-417. - Resolution: Implemented Fix Version/s: 0.8 NullPointerException in

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14638/#review27039 --- core/src/main/scala/kafka/tools/GetOffsetShell.scala

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-15 Thread Joel Koshy
On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote: core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 71 https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line71 Nice use of clientId. We should do this in every tool. I would suggest we also prepend this with

[jira] [Resolved] (KAFKA-1081) kafka-run-class.sh is broken

2013-10-15 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1081. -- Resolution: Fixed Checked in on both 0.8 and trunk. kafka-run-class.sh is broken

[jira] [Resolved] (KAFKA-1036) Unable to rename replication offset checkpoint in windows

2013-10-15 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1036. -- Resolution: Fixed Checked in fix on trunk. Note that I don't have access to a windows box so I can't

[jira] [Resolved] (KAFKA-1008) Unmap before resizing

2013-10-15 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1008. -- Resolution: Fixed Checked in on 0.8 and trunk. Unmap before resizing -

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-15 Thread Neha Narkhede
On Oct. 15, 2013, 4:33 p.m., Jun Rao wrote: core/src/main/scala/kafka/tools/GetOffsetShell.scala, lines 41-42 https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line41 Should we name this option partitions? Sure. Will make that change on check-in - Neha