[jira] [Closed] (KAFKA-1187) Controller should retry connecting to brokers to send state change requests

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1187. > Controller should retry connecting to brokers to send state change requests > ---

[jira] [Updated] (KAFKA-1187) Controller should retry connecting to brokers to send state change requests

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1187: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews, commit

Re: Review Request 15674: add unit test for aborting during cleaning

2014-01-03 Thread Jun Rao
> On Jan. 3, 2014, 4:22 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 262 > > > > > > Would these be better as just InProgress, Aborted, and Paused? My feeling is that in the future t

[jira] [Updated] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

2014-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1074: --- Attachment: KAFKA-1074_2014-01-03_12:30:47.patch > Reassign partitions should delete the old replicas from di

[jira] [Commented] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

2014-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861877#comment-13861877 ] Jun Rao commented on KAFKA-1074: Updated reviewboard https://reviews.apache.org/r/15674/

Re: Review Request 15674: add unit test for aborting during cleaning

2014-01-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- (Updated Jan. 3, 2014, 8:27 p.m.) Review request for kafka. Summary (updated)

[jira] [Commented] (KAFKA-1198) NullPointerException in describe topic

2014-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861871#comment-13861871 ] Jun Rao commented on KAFKA-1198: Thanks for the patch. +1 and committed trunk. > NullPoin

Re: Review Request 16579: Patch for KAFKA-1198

2014-01-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16579/#review31155 --- Ship it! Ship It! - Jun Rao On Jan. 3, 2014, 6:17 p.m., Guozhang

[jira] [Work started] (KAFKA-1185) Improve leader elector module to have a resign API

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1185 started by Neha Narkhede. > Improve leader elector module to have a resign API > -- > >

[jira] [Closed] (KAFKA-1185) Improve leader elector module to have a resign API

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1185. > Improve leader elector module to have a resign API >

[jira] [Updated] (KAFKA-1185) Improve leader elector module to have a resign API

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1185: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk > Improve

[jira] [Updated] (KAFKA-1185) Improve leader elector module to have a resign API

2014-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1185: - Status: Patch Available (was: In Progress) > Improve leader elector module to have a resign API

[jira] [Updated] (KAFKA-1198) NullPointerException in describe topic

2014-01-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1198: - Attachment: KAFKA-1198_2014-01-03_10:17:46.patch > NullPointerException in describe topic > -

[jira] [Commented] (KAFKA-1198) NullPointerException in describe topic

2014-01-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861738#comment-13861738 ] Guozhang Wang commented on KAFKA-1198: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 16579: Patch for KAFKA-1198

2014-01-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16579/ --- (Updated Jan. 3, 2014, 6:17 p.m.) Review request for kafka. Bugs: KAFKA-1198

Re: Review Request 16579: Patch for KAFKA-1198

2014-01-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16579/#review31140 --- Looks good. Just one comment. core/src/main/scala/kafka/admin/Topi

Re: Review Request 15674: address more review comments

2014-01-03 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review31134 --- core/src/main/scala/kafka/log/LogCleaner.scala