Re: Published Java/Scala docs?

2014-01-29 Thread Jay Kreps
The primary problem was that we never found a way to get sane javadocs for scala code. Moving the clients out of scala will fix this (e.g. http://empathybox.com/kafka-javadoc/index.html?kafka/clients/producer/KafkaProducer.html) -Jay On Wed, Jan 29, 2014 at 11:54 AM, David Arthur wrote: > Noti

Re: Published Java/Scala docs?

2014-01-29 Thread Jun Rao
We had one for 0.7, but it wasn't very readable. We didn't do one for 0.8. Thanks, Jun On Wed, Jan 29, 2014 at 11:54 AM, David Arthur wrote: > Noticed these are no where to be found on the webpage. Are we currently > publishing these anywhere? > > -David >

Re: Review Request 17460: Patch for KAFKA-330

2014-01-29 Thread Neha Narkhede
> On Jan. 30, 2014, 1:33 a.m., Jun Rao wrote: > > A few high level comments: > > > > 1. Do we need to block adding partitions when a topic is being deleted? > > > > 2. StopReplica callback: When the callback is created, we can probably let > > it reference a local val for replica id. This way,

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

2014-01-29 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886227#comment-13886227 ] David Arthur commented on KAFKA-1171: - Figured out the POM thing finally. After Googl

[jira] [Comment Edited] (KAFKA-1171) Gradle build for Kafka

2014-01-29 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886227#comment-13886227 ] David Arthur edited comment on KAFKA-1171 at 1/30/14 3:49 AM: --

[jira] [Updated] (KAFKA-1233) Integration test for the new producer

2014-01-29 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1233: - Attachment: KAFKA-1233.patch > Integration test for the new producer > --

[jira] [Commented] (KAFKA-1233) Integration test for the new producer

2014-01-29 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886191#comment-13886191 ] Guozhang Wang commented on KAFKA-1233: -- Created reviewboard https://reviews.apache.or

Review Request 17524: Add one integration test for the new producer

2014-01-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17524/ --- Review request for kafka. Bugs: KAFKA-1233 https://issues.apache.org/jira/b

Re: Review Request 17460: Patch for KAFKA-330

2014-01-29 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33179 --- A few high level comments: 1. Do we need to block adding partitions

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

2014-01-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885869#comment-13885869 ] Neha Narkhede commented on KAFKA-1028: -- It will be easier to do the review if you can

[jira] [Created] (KAFKA-1233) Integration test for the new producer

2014-01-29 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1233: Summary: Integration test for the new producer Key: KAFKA-1233 URL: https://issues.apache.org/jira/browse/KAFKA-1233 Project: Kafka Issue Type: Bug

Published Java/Scala docs?

2014-01-29 Thread David Arthur
Noticed these are no where to be found on the webpage. Are we currently publishing these anywhere? -David

Re: Review Request 17263: New producer for Kafka.

2014-01-29 Thread Neha Narkhede
> On Jan. 26, 2014, 11:30 p.m., Sriram Subramanian wrote: > > clients/src/main/java/kafka/clients/producer/internals/RecordAccumulator.java, > > line 87 > > > > > > We can allocate a batch larger than the batchSize? >

Re: Review Request 17263: New producer for Kafka.

2014-01-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review33004 --- Some more comments regarding the blocking behavior clients/src/mai

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33135 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33128 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 15711: Patch for KAFKA-930

2014-01-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review33124 --- Ship it! I hope we can hold this off until delete topic which is cu

Re: Review Request 15711: Patch for KAFKA-930

2014-01-29 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review33121 --- Ship it! Ship It! - Jun Rao On Jan. 27, 2014, 9:28 p.m., Sriram

[jira] [Commented] (KAFKA-1095) Kafka does not compile with sbt

2014-01-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885420#comment-13885420 ] Jun Rao commented on KAFKA-1095: Not sure, could you try adding 2.9.3 to the sbt build fil

[jira] [Commented] (KAFKA-1095) Kafka does not compile with sbt

2014-01-29 Thread jobs wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885360#comment-13885360 ] jobs wang commented on KAFKA-1095: -- Does compiling kafka with sbt support scala 2.9.3?