[jira] [Commented] (KAFKA-1095) Kafka does not compile with sbt

2014-02-05 Thread jobs wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891965#comment-13891965 ] jobs wang commented on KAFKA-1095: -- i add 2.9.3 to sbt build file, but report errors!

[jira] [Commented] (KAFKA-1242) Get added to the asf-cla group

2014-02-05 Thread Tomas Uribe (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892265#comment-13892265 ] Tomas Uribe commented on KAFKA-1242: Don't seem to have edit permission yet. Who's in

Re: Review Request 17537: Patch for KAFKA-1028

2014-02-05 Thread Andrew Olson
On Feb. 4, 2014, 11:21 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala, line 64 https://reviews.apache.org/r/17537/diff/3/?file=456705#file456705line64 the config object should already have the per topic preference for unclean leader

Re: Review Request 17460: Patch for KAFKA-330

2014-02-05 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Feb. 5, 2014, 5:31 p.m.) Review request for kafka. Bugs: KAFKA-330

[jira] [Commented] (KAFKA-330) Add delete topic support

2014-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892325#comment-13892325 ] Neha Narkhede commented on KAFKA-330: - Updated reviewboard

Re: Review Request 17460: Patch for KAFKA-330

2014-02-05 Thread Neha Narkhede
On Feb. 5, 2014, 2:50 a.m., Joel Koshy wrote: core/src/main/scala/kafka/controller/ControllerChannelManager.scala, line 304 https://reviews.apache.org/r/17460/diff/7/?file=462654#file462654line304 You mean just put all in a single StopReplicaRequest? If so, any reason not to

[jira] [Updated] (KAFKA-1171) Gradle build for Kafka

2014-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1171: --- Attachment: kafka-1171_v13.patch Attach patch v13. This fixes all known issues. 1. Added hadoop-producer

[jira] [Updated] (KAFKA-330) Add delete topic support

2014-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330_2014-02-05_09:31:30.patch Add delete topic support

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

2014-02-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892351#comment-13892351 ] Guozhang Wang commented on KAFKA-1171: -- Wondering how to run a single unit test:

[jira] [Updated] (KAFKA-1171) Gradle build for Kafka

2014-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1171: --- Attachment: kafka-1171_v14.patch Attach patch v14 to fix a typo in README. Gradle build for Kafka

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

2014-02-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892463#comment-13892463 ] Guozhang Wang commented on KAFKA-1171: -- When I run ./gradlew

Re: Review Request 17460: Patch for KAFKA-330

2014-02-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33711 --- In the follow-up patch that serialize all the admin tasks in the

Re: Review Request 17460: Patch for KAFKA-330

2014-02-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33699 --- Some high level comments. 1. While most of the replica states are

Re: Config for new clients (and server)

2014-02-05 Thread Joel Koshy
Overall, +1 on sticking with key-values for configs. Con: The IDE gives nice auto-completion for pojos. Con: There are some advantages to javadoc as a documentation mechanism for java people. Optionally, both the above cons can be addressed (to some degree) by wrapper config POJOs that

Re: Config for new clients (and server)

2014-02-05 Thread Guozhang Wang
I like the helper function in all except in parseType: is it better to be restrict about types, i.e. now allowing true if the type is really Boolean? On Wed, Feb 5, 2014 at 5:06 PM, Joel Koshy jjkosh...@gmail.com wrote: Overall, +1 on sticking with key-values for configs. Con: The IDE

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

2014-02-05 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892908#comment-13892908 ] Jakob Homan commented on KAFKA-1171: There's the test output html, but you can also