Re: Review Request 19338: Fix cross-compilation issue

> On March 18, 2014, 1:47 a.m., Neha Narkhede wrote: > > Ship It! Thanks for the review - actually, now that I look at it I don't recollect why it needed to be a mutable.map. Will revisit this tomorrow. - Joel --- This is an automatica

Re: Review Request 19338: Fix cross-compilation issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/#review37526 --- Ship it! Ship It! - Neha Narkhede On March 18, 2014, 1:37 a.m.,

[jira] [Updated] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1028: - Assignee: Andrew Olson > per topic configuration of preference for consistency over availability

[jira] [Resolved] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1028. -- Resolution: Fixed Assignee: (was: Neha Narkhede) Thanks for the patch! Committed to t

Re: Review Request 19338: Fix cross-compilation issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/#review37525 --- core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala

[jira] [Updated] (KAFKA-1309) jarAll (cross-compilation) is broken

[ https://issues.apache.org/jira/browse/KAFKA-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1309: -- Attachment: KAFKA-1309.patch > jarAll (cross-compilation) is broken > -

[jira] [Commented] (KAFKA-1309) jarAll (cross-compilation) is broken

[ https://issues.apache.org/jira/browse/KAFKA-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938666#comment-13938666 ] Joel Koshy commented on KAFKA-1309: --- Created reviewboard https://reviews.apache.org/r/19

Review Request 19338: Fix cross-compilation issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/ --- Review request for kafka. Bugs: KAFKA-1309 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1309) jarAll (cross-compilation) is broken

Joel Koshy created KAFKA-1309: - Summary: jarAll (cross-compilation) is broken Key: KAFKA-1309 URL: https://issues.apache.org/jira/browse/KAFKA-1309 Project: Kafka Issue Type: Bug Repo

[jira] [Created] (KAFKA-1308) Publish jar of test utilities to Maven

Martin Kleppmann created KAFKA-1308: --- Summary: Publish jar of test utilities to Maven Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938575#comment-13938575 ] Scott Clasen commented on KAFKA-1028: - Yes! Thanks Andrew! > per topic configuration

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938567#comment-13938567 ] Jay Kreps commented on KAFKA-1028: -- No, I'm +1 too. Thanks Andrew! > per topic configura

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938559#comment-13938559 ] Neha Narkhede commented on KAFKA-1028: -- [~noslowerdna] Your latest patch looks good t

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938520#comment-13938520 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 17, 2014, 10:56 p.m.) Review request for kafka. Bugs: KAFKA-12

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 17, 2014, 10:56 p.m.) Review request for kafka. Bugs: KAFKA-12

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-17_15:56:04.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

> On March 16, 2014, 6:42 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/Compressor.java, lines > > 49-50 > > > > > > We probably can call Compressor.putRecord() directly since when key

Re: Review Request 19311: Patch for KAFKA-1307

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19311/#review37472 --- Ship it! I would vote for handling these exceptions separately sinc

[jira] [Commented] (KAFKA-1307) potential socket leak in new producer and clean up

[ https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938304#comment-13938304 ] Jun Rao commented on KAFKA-1307: The logging improvement is already committed in KAFKA-130

Re: Review Request 19311: Patch for KAFKA-1307

> On March 17, 2014, 5:40 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selectable.java, line > > 36 > > > > > > Throwing Exception is pretty bad form. Can we actually see if there ar

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (85 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1307 potential socket leak in new producer and clean up https://issues.apache.org/jira/browse/KAFKA-1307 KAFKA-1300 Added Wa

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/#review37419 --- Ship it! Ship It! - Neha Narkhede On March 17, 2014, 2:39 p.m.,

Re: Review Request 19311: Patch for KAFKA-1307

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19311/#review37415 --- Looks good overall. I have the same questions as Jay. clients/src/

Re: Review Request 19311: Patch for KAFKA-1307

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19311/#review37412 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

[jira] [Commented] (KAFKA-1307) potential socket leak in new producer and clean up

[ https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938061#comment-13938061 ] Neha Narkhede commented on KAFKA-1307: -- [~junrao] You mentioned that you also have a

[jira] [Commented] (KAFKA-1307) potential socket leak in new producer and clean up

[ https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938050#comment-13938050 ] Jun Rao commented on KAFKA-1307: Created reviewboard https://reviews.apache.org/r/19311/

[jira] [Updated] (KAFKA-1307) potential socket leak in new producer and clean up

[ https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1307: --- Attachment: KAFKA-1307.patch > potential socket leak in new producer and clean up > -

Review Request 19311: Patch for KAFKA-1307

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19311/ --- Review request for kafka. Bugs: KAFKA-1307 https://issues.apache.org/jira/b

Review Request 19310: Patch for KAFKA-1307

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19310/ --- Review request for kafka. Bugs: KAFKA-1307 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1307) potential socket leak in new producer and clean up

Jun Rao created KAFKA-1307: -- Summary: potential socket leak in new producer and clean up Key: KAFKA-1307 URL: https://issues.apache.org/jira/browse/KAFKA-1307 Project: Kafka Issue Type: Bug

Re: Review Request 17537: Patch for KAFKA-1028

> On March 17, 2014, 4:30 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 256 > > > > > > Are these config changes due to needing a rebase or something? They > > don't seem relate

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/#review37386 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 17537: Patch for KAFKA-1028

> On March 14, 2014, 8:13 p.m., Jay Kreps wrote: > > This is great! > > > > I don't think we should add a special purpose method that hard codes one > > property in AdminUtils, I think the helper code is actually there in > > LogConfig. > > > > I see Neha's point about adding a higher-level c

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937865#comment-13937865 ] Andrew Olson commented on KAFKA-1028: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated KAFKA-1028: Attachment: KAFKA-1028_2014-03-17_09:39:05.patch > per topic configuration of preference for consis

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/ --- (Updated March 17, 2014, 2:39 p.m.) Review request for kafka. Bugs: KAFKA-102

[jira] [Updated] (KAFKA-1306) Offset commit API, does it work?

[ https://issues.apache.org/jira/browse/KAFKA-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] korebantic2 updated KAFKA-1306: --- Affects Version/s: 0.8.1 > Offset commit API, does it work? > > >