[jira] [Commented] (KAFKA-1354) Failed to load class "org.slf4j.impl.StaticLoggerBinder"

[ https://issues.apache.org/jira/browse/KAFKA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958574#comment-13958574 ] Timothy Chen commented on KAFKA-1354: - Hi Rakesh, this is actually a very common messa

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39402 --- Just curious: which part of the code is the main contribution to the

Re: Review Request 19972: Patch for KAFKA-1358

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19972/#review39401 --- Ship it! Ship It! - Guozhang Wang On April 3, 2014, 12:34 a.m.,

Re: Review Request 19953: Patch for KAFKA-1303

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19953/#review39399 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39387 --- Ship it! Ship It! - Joel Koshy On April 3, 2014, 1:39 a.m., Timo

Re: Review Request 19972: Patch for KAFKA-1358

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19972/#review39384 --- Ship it! core/src/main/scala/kafka/controller/KafkaController.scal

Re: Review Request 19957: Patch for KAFKA-1356

> On April 3, 2014, 1:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TopicMetadata.scala, line 35 > > > > > > Nitpick, but I think this would be a little neater: > > (0 to numPartitions).map( ).toArra

[jira] [Commented] (KAFKA-472) update metadata in batches in Producer

[ https://issues.apache.org/jira/browse/KAFKA-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958432#comment-13958432 ] Neha Narkhede commented on KAFKA-472: - Seems like this is a non-issue with the new prod

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356_2014-04-02_18:39:36.patch > Topic metadata requests takes too long to proces

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958428#comment-13958428 ] Timothy Chen commented on KAFKA-1356: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/ --- (Updated April 3, 2014, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-1356

Re: Review Request 19957: Patch for KAFKA-1356

> On April 3, 2014, 1:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TopicMetadata.scala, line 35 > > > > > > Nitpick, but I think this would be a little neater: > > (0 to numPartitions).map( ).toArra

Re: Review Request 19957: Patch for KAFKA-1356

> On April 3, 2014, 1:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 638 > > > > > > I think this really should have been > > isr.map(aliveBrokers.get).filter(_.isEmpty) this is

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39378 --- core/src/main/scala/kafka/api/TopicMetadata.scala

[jira] [Commented] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958388#comment-13958388 ] Timothy Chen commented on KAFKA-1358: - Looks like we already have this guard in trunk,

[jira] [Updated] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1358: Fix Version/s: 0.8.1.1 > Broker throws exception when reconnecting to zookeeper > -

[jira] [Updated] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1358: Status: Patch Available (was: Open) > Broker throws exception when reconnecting to zookeeper > ---

[jira] [Updated] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1358: Attachment: KAFKA-1358.patch > Broker throws exception when reconnecting to zookeeper > ---

[jira] [Commented] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958387#comment-13958387 ] Timothy Chen commented on KAFKA-1358: - Created reviewboard https://reviews.apache.org/

Review Request 19972: Patch for KAFKA-1358

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19972/ --- Review request for kafka. Bugs: KAFKA-1358 https://issues.apache.org/jira/b

[jira] [Resolved] (KAFKA-1264) Make ConsoleProducer compression codec configurable

[ https://issues.apache.org/jira/browse/KAFKA-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-1264. -- Resolution: Duplicate Fix Version/s: 0.8.2 duplicate of KAFKA-1344 which is committed to master

[jira] [Created] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

Timothy Chen created KAFKA-1358: --- Summary: Broker throws exception when reconnecting to zookeeper Key: KAFKA-1358 URL: https://issues.apache.org/jira/browse/KAFKA-1358 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958242#comment-13958242 ] Joris Van Remoortere commented on KAFKA-1215: - Since there is further interest

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958153#comment-13958153 ] Timothy Chen commented on KAFKA-1356: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356.patch > Topic metadata requests takes too long to process >

Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/ --- Review request for kafka. Bugs: KAFKA-1356 https://issues.apache.org/jira/b

Re: Review Request 19953: Patch for KAFKA-1303

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19953/#review39343 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958061#comment-13958061 ] Timothy Chen commented on KAFKA-1323: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1323: Attachment: KAFKA-1323_2014-04-02_12:17:57.patch > log.dirs server property no longer supports rela

Re: Review Request 19626: Patch for KAFKA-1323

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/ --- (Updated April 2, 2014, 7:18 p.m.) Review request for kafka. Bugs: KAFKA-1323

[jira] [Resolved] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

[ https://issues.apache.org/jira/browse/KAFKA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1344. Resolution: Fixed Assignee: Ivan Lyutov Thanks for the patch. +1 and committed to trunk. > Kafka-con

[jira] [Commented] (KAFKA-472) update metadata in batches in Producer

[ https://issues.apache.org/jira/browse/KAFKA-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958033#comment-13958033 ] Guozhang Wang commented on KAFKA-472: - Is this still an issue with the new producer? >

[jira] [Commented] (KAFKA-1303) metadata request in the new producer can be delayed

[ https://issues.apache.org/jira/browse/KAFKA-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958024#comment-13958024 ] Jun Rao commented on KAFKA-1303: Created reviewboard https://reviews.apache.org/r/19953/

[jira] [Updated] (KAFKA-1303) metadata request in the new producer can be delayed

[ https://issues.apache.org/jira/browse/KAFKA-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1303: --- Attachment: KAFKA-1303.patch > metadata request in the new producer can be delayed >

Review Request 19953: Patch for KAFKA-1303

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19953/ --- Review request for kafka. Bugs: KAFKA-1303 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-803) Offset returned to producer is not consistent

[ https://issues.apache.org/jira/browse/KAFKA-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957988#comment-13957988 ] Joel Koshy commented on KAFKA-803: -- Yes - I think this was fixed as part of KAFKA-1260 >

[jira] [Commented] (KAFKA-803) Offset returned to producer is not consistent

[ https://issues.apache.org/jira/browse/KAFKA-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957967#comment-13957967 ] Guozhang Wang commented on KAFKA-803: - I think this issue has already been solved in th

[jira] [Closed] (KAFKA-1209) System test transient failure due to ProducerPerformance's connection to servers kept broken

[ https://issues.apache.org/jira/browse/KAFKA-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang closed KAFKA-1209. > System test transient failure due to ProducerPerformance's connection to > servers kept broken > ---

[jira] [Resolved] (KAFKA-1209) System test transient failure due to ProducerPerformance's connection to servers kept broken

[ https://issues.apache.org/jira/browse/KAFKA-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1209. -- Resolution: Not a Problem > System test transient failure due to ProducerPerformance's connecti

Re: Review Request 19873: Add log cleaner metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19873/#review39299 --- Ship it! Ship It! - Joel Koshy On April 1, 2014, 5:41 p.m., Jay

[jira] [Updated] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

[ https://issues.apache.org/jira/browse/KAFKA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1344: --- Attachment: KAFKA-1344_2014-04-02_20:31:27.patch > Kafka-console-producer.sh support snappy compressi

[jira] [Commented] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

[ https://issues.apache.org/jira/browse/KAFKA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957917#comment-13957917 ] Ivan Lyutov commented on KAFKA-1344: Updated reviewboard https://reviews.apache.org/r/

Re: Review Request 19853: Patch for KAFKA-1344

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19853/ --- (Updated April 2, 2014, 5:31 p.m.) Review request for kafka. Bugs: KAFKA-1344

[jira] [Commented] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957907#comment-13957907 ] Jay Kreps commented on KAFKA-1327: -- Created reviewboard https://reviews.apache.org/r/1994

[jira] [Updated] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1327: - Attachment: KAFKA-1327.patch > Add log cleaner metrics > --- > > Key:

Review Request 19947: Patch for KAFKA-1327

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19947/ --- Review request for kafka. Bugs: KAFKA-1327 https://issues.apache.org/jira/b

Re: Review Request 19873: Add log cleaner metrics

> On April 2, 2014, 3:25 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/Throttler.scala, lines 49-50 > > > > > > Shouldn't this be measured as a gauge since it's the observed bytes/sec? > > Jay Kreps wrote: >

[jira] [Commented] (KAFKA-1354) Failed to load class "org.slf4j.impl.StaticLoggerBinder"

[ https://issues.apache.org/jira/browse/KAFKA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957879#comment-13957879 ] RakeshAcharya commented on KAFKA-1354: -- Any update? > Failed to load class "org.slf4

[jira] [Commented] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957870#comment-13957870 ] Jay Kreps commented on KAFKA-1327: -- Created reviewboard against branch trunk > Add log

[jira] [Updated] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1327: - Attachment: KAFKA-1327.patch > Add log cleaner metrics > --- > > Key:

[jira] [Commented] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957872#comment-13957872 ] Jay Kreps commented on KAFKA-1327: -- Okay reviewboard is busted. Jun, I renamed the metric

[jira] [Updated] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1327: - Attachment: KAFKA-1327.patch > Add log cleaner metrics > --- > > Key:

[jira] [Commented] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957867#comment-13957867 ] Jay Kreps commented on KAFKA-1327: -- Created reviewboard against branch trunk > Add log

Re: Review Request 19873: Add log cleaner metrics

> On April 2, 2014, 3:25 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/Throttler.scala, lines 49-50 > > > > > > Shouldn't this be measured as a gauge since it's the observed bytes/sec? My understanding is th

Re: Review Request 19873: Add log cleaner metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19873/#review39277 --- Ship it! core/src/main/scala/kafka/log/LogCleaner.scala

[jira] [Commented] (KAFKA-1357) Rack-aware replica assignment

[ https://issues.apache.org/jira/browse/KAFKA-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957843#comment-13957843 ] Jay Bae commented on KAFKA-1357: Sorry for dirtying your issue tracker :) I should have as

[jira] [Resolved] (KAFKA-1357) Rack-aware replica assignment

[ https://issues.apache.org/jira/browse/KAFKA-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Bae resolved KAFKA-1357. Resolution: Duplicate > Rack-aware replica assignment > - > > K

Re: Review Request 19879: Further metric name standardization

> On April 1, 2014, 8:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 138 > > > > > > Do we still need this sensor, since the only metric it has i

Re: Review Request 19879: Further metric name standardization

> On April 2, 2014, 1:55 a.m., Jun Rao wrote: > > Do we need both io-ratio and io-wait-ratio? It seems io-ratio = 1 - > > io-wait-ratio. Other than that, looks good to me. Yes, you need both. There are really three things: 1. Time waiting on I/O 2. Time doing I/O 3. Time in Sender doing actual

Re: Review Request 19879: Further metric name standardization

> On April 1, 2014, 8:21 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 432 > > > > > > Here was my convention: > > 1. All rates are in seconds (the defaul

Re: Review Request 19873: Add log cleaner metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19873/#review39262 --- The following three metrics are all of percentage, but we use differ

Re: Review Request 19853: Patch for KAFKA-1344

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19853/#review39255 --- Thanks for the patch. A couple other minor comments below. core/sr