Re: Review Request 19957: Patch for KAFKA-1356

2014-04-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/ --- (Updated April 8, 2014, 8:38 a.m.) Review request for kafka. Bugs: KAFKA-1356

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962707#comment-13962707 ] Timothy Chen commented on KAFKA-1356: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356_2014-04-08_01:38:23.patch > Topic metadata requests takes too long to proces

[GitHub] kafka pull request: Fix to run hadoop-consumer with hadoop 2

2014-04-08 Thread mvalleavila
Github user mvalleavila closed the pull request at: https://github.com/apache/kafka/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Created] (KAFKA-1368) Upgrade log4j

2014-04-08 Thread Vladislav Pernin (JIRA)
Vladislav Pernin created KAFKA-1368: --- Summary: Upgrade log4j Key: KAFKA-1368 URL: https://issues.apache.org/jira/browse/KAFKA-1368 Project: Kafka Issue Type: Improvement Affects Version

[jira] [Commented] (KAFKA-1210) Windows Bat files are not working properly

2014-04-08 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962749#comment-13962749 ] Stevo Slavic commented on KAFKA-1210: - kafka-run-class.bat changes from the patch unfo

[jira] [Commented] (KAFKA-1195) windows kafka-run-class.bat not updated

2014-04-08 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962751#comment-13962751 ] Stevo Slavic commented on KAFKA-1195: - Duplicate of KAFKA-1210 ? > windows kafka-run-

[jira] [Created] (KAFKA-1369) snappy version update 1.1.x

2014-04-08 Thread thinker0 (JIRA)
thinker0 created KAFKA-1369: --- Summary: snappy version update 1.1.x Key: KAFKA-1369 URL: https://issues.apache.org/jira/browse/KAFKA-1369 Project: Kafka Issue Type: Bug Components: core

[jira] [Created] (KAFKA-1370) Gradle startup script for Windows

2014-04-08 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-1370: --- Summary: Gradle startup script for Windows Key: KAFKA-1370 URL: https://issues.apache.org/jira/browse/KAFKA-1370 Project: Kafka Issue Type: Wish Comp

[GitHub] kafka pull request: KAFKA-1370 Added Gradle startup script for Win...

2014-04-08 Thread sslavic
GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/22 KAFKA-1370 Added Gradle startup script for Windows This patch adds Gradle startup script for Windows You can merge this pull request into a Git repository by running: $ git pull https://github.co

[jira] [Commented] (KAFKA-1370) Gradle startup script for Windows

2014-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962800#comment-13962800 ] ASF GitHub Bot commented on KAFKA-1370: --- GitHub user sslavic opened a pull request:

[jira] [Commented] (KAFKA-1370) Gradle startup script for Windows

2014-04-08 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962801#comment-13962801 ] Stevo Slavic commented on KAFKA-1370: - Created pull request with this change (see [he

[jira] [Created] (KAFKA-1371) Ignore build output dirs

2014-04-08 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-1371: --- Summary: Ignore build output dirs Key: KAFKA-1371 URL: https://issues.apache.org/jira/browse/KAFKA-1371 Project: Kafka Issue Type: Wish Components: t

[jira] [Commented] (KAFKA-1371) Ignore build output dirs

2014-04-08 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962803#comment-13962803 ] Stevo Slavic commented on KAFKA-1371: - Created pull request with fix for this (see [h

[jira] [Created] (KAFKA-1372) Upgrade to Gradle 1.11

2014-04-08 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-1372: --- Summary: Upgrade to Gradle 1.11 Key: KAFKA-1372 URL: https://issues.apache.org/jira/browse/KAFKA-1372 Project: Kafka Issue Type: Task Components: too

[GitHub] kafka pull request: KAFKA-1372 Upgrade to Gradle 1.11

2014-04-08 Thread sslavic
GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/23 KAFKA-1372 Upgrade to Gradle 1.11 This patch upgrades Gradle wrapper from 1.6 to 1.11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sslavic/kafka

[jira] [Commented] (KAFKA-1372) Upgrade to Gradle 1.11

2014-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962809#comment-13962809 ] ASF GitHub Bot commented on KAFKA-1372: --- GitHub user sslavic opened a pull request:

Build failed in Jenkins: Kafka-trunk #151

2014-04-08 Thread Apache Jenkins Server
See -- Started by user junrao Building remotely on solaris1 (Solaris) in workspace Cloning the remote Git repository Cloning repository https://git-wip-us.apach

Build failed in Jenkins: Kafka-trunk #152

2014-04-08 Thread Apache Jenkins Server
See -- Started by an SCM change Building remotely on solaris1 (Solaris) in workspace ERROR: Workspace has a .git repository, but it appears to be corrupt. hudso

[jira] [Commented] (KAFKA-1360) Configure continuous integration (CI) for Kafka branches under active development

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963132#comment-13963132 ] Jun Rao commented on KAFKA-1360: Following up in https://issues.apache.org/jira/browse/INF

Re: Review Request 20034: Fix KAFKA-1353

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39792 --- The way that we expose the metrics through a gauge is a bit complica

Re: Review Request 20038: Patch for KAFKA-1355

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39798 --- core/src/main/scala/kafka/controller/ControllerChannelManager.scala

Re: Review Request 20109: Fix KAFKA-1366

2014-04-08 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20109/#review39795 --- Ship it! Ship It! - Neha Narkhede On April 7, 2014, 11:12 p.m.,

[jira] [Resolved] (KAFKA-1366) Multiple Unit Test failures with new producer

2014-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1366. -- Resolution: Fixed Committed to trunk > Multiple Unit Test failures with new producer > ---

Re: Review Request 20034: Fix KAFKA-1353

2014-04-08 Thread Guozhang Wang
> On April 8, 2014, 4:53 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/network/RequestChannel.scala, lines 163-165 > > > > > > Do we still need this? This is still used in some unit tests, in which they do need b

Re: Review Request 20034: Fix KAFKA-1353: incorporate Jun's comments

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/ --- (Updated April 8, 2014, 5:41 p.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1353: - Attachment: KAFKA-1353_2014-04-08_10:41:15.patch > report capacity used by request thread pool an

[jira] [Commented] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963212#comment-13963212 ] Guozhang Wang commented on KAFKA-1353: -- Updated reviewboard https://reviews.apache.or

[jira] [Resolved] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1356. -- Resolution: Fixed Thanks for the patches! Committed to trunk > Topic metadata requests takes t

[jira] [Closed] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1356. > Topic metadata requests takes too long to process > -

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1356: - Assignee: Timothy Chen > Topic metadata requests takes too long to process >

[jira] [Commented] (KAFKA-1210) Windows Bat files are not working properly

2014-04-08 Thread John Arnold (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963238#comment-13963238 ] John Arnold commented on KAFKA-1210: Is there a branch that "just works" on windows?

[jira] [Updated] (KAFKA-1364) ReplicaManagerTest hard-codes log dir

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1364: -- Fix Version/s: 0.8.1.1 > ReplicaManagerTest hard-codes log dir > -

[jira] [Assigned] (KAFKA-1364) ReplicaManagerTest hard-codes log dir

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1364: - Assignee: Guozhang Wang > ReplicaManagerTest hard-codes log dir > ---

[jira] [Assigned] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1363: - Assignee: Timothy Chen > testTopicConfigChangesDuringDeleteTopic hangs >

Review Request 20128: Fix KAFKA-1364

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20128/ --- Review request for kafka. Bugs: KAFKA-1364 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1364) ReplicaManagerTest hard-codes log dir

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963433#comment-13963433 ] Guozhang Wang commented on KAFKA-1364: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1364) ReplicaManagerTest hard-codes log dir

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1364: - Attachment: KAFKA-1364.patch > ReplicaManagerTest hard-codes log dir > --

Re: Review Request 20034: Fix KAFKA-1353: incorporate Jun's comments

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39819 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 20034: Fix KAFKA-1353: incorporate Jun's comments

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39821 --- core/src/main/scala/kafka/network/SocketServer.scala

[jira] [Created] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1373: - Summary: LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint Key: KAFKA-1373 URL: https://issues.apache.org/jira/browse/KAFKA-1373 Project: Kafka

Review Request 20130: Patch for KAFKA-1373

2014-04-08 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/ --- Review request for kafka. Bugs: KAFKA-1373 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963461#comment-13963461 ] Joel Koshy commented on KAFKA-1373: --- Created reviewboard https://reviews.apache.org/r/20

[jira] [Updated] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1373: -- Attachment: KAFKA-1373.patch > LogCleaner assumes first dirty offset zero if there is no cleaner checkp

[jira] [Created] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-04-08 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1374: - Summary: LogCleaner (compaction) does not support compressed topics Key: KAFKA-1374 URL: https://issues.apache.org/jira/browse/KAFKA-1374 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1353: - Attachment: KAFKA-1353.patch > report capacity used by request thread pool and network thread poo

[jira] [Commented] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963467#comment-13963467 ] Guozhang Wang commented on KAFKA-1353: -- Created reviewboard https://reviews.apache.or

Review Request 20131: Fix KAFKA-1353: incorporate Jun's comment round two

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/ --- Review request for kafka. Bugs: KAFKA-1353 https://issues.apache.org/jira/b

Re: Review Request 20131: Fix KAFKA-1353: incorporate Jun's comment round two

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/ --- (Updated April 8, 2014, 9:56 p.m.) Review request for kafka. Bugs: KAFKA-1353

Re: Review Request 20050: Fix KAFKA-1359

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39825 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 20131: Fix KAFKA-1353: incorporate Jun's comment round two

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/#review39831 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 20130: Patch for KAFKA-1373

2014-04-08 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/ --- (Updated April 8, 2014, 11:18 p.m.) Review request for kafka. Bugs: KAFKA-137

[jira] [Commented] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963605#comment-13963605 ] Joel Koshy commented on KAFKA-1373: --- Updated reviewboard https://reviews.apache.org/r/20

[jira] [Updated] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1373: -- Attachment: KAFKA-1373_2014-04-08_16:18:22.patch > LogCleaner assumes first dirty offset zero if there

[jira] [Commented] (KAFKA-1373) LogCleaner assumes first dirty offset zero if there is no cleaner checkpoint

2014-04-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963608#comment-13963608 ] Joel Koshy commented on KAFKA-1373: --- Updated the RB with an additional fix: KAFKA-1289 c

Re: Review Request 20050: Fix KAFKA-1359

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39836 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 20131: Fix KAFKA-1353: incorporate Jun's comment round three

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/ --- (Updated April 8, 2014, 11:31 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963617#comment-13963617 ] Guozhang Wang commented on KAFKA-1353: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1353) report capacity used by request thread pool and network thread pool

2014-04-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1353: - Attachment: KAFKA-1353_2014-04-08_16:31:45.patch > report capacity used by request thread pool an

Re: Review Request 20130: Patch for KAFKA-1373

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/#review39839 --- Ship it! Ship It! - Guozhang Wang On April 8, 2014, 11:18 p.m.,

Re: Review Request 19957: Patch for KAFKA-1356

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39840 --- Thanks for the patch. Some additional comments. 1. The introduction

Re: Review Request 20131: Fix KAFKA-1353: incorporate Jun's comment round three

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20131/#review39841 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 20128: Fix KAFKA-1364

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20128/#review39843 --- core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala

Review Request 20143: Patch for KAFKA-1363

2014-04-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20143/ --- Review request for kafka. Bugs: KAFKA-1363 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1363: Attachment: KAFKA-1363.patch > testTopicConfigChangesDuringDeleteTopic hangs >

[jira] [Commented] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963673#comment-13963673 ] Timothy Chen commented on KAFKA-1363: - Created reviewboard https://reviews.apache.org/

Re: Review Request 20143: Patch for KAFKA-1363

2014-04-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20143/ --- (Updated April 9, 2014, 12:52 a.m.) Review request for kafka. Bugs: KAFKA-136

[jira] [Updated] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1363: Attachment: KAFKA-1363_2014-04-08_17:52:17.patch > testTopicConfigChangesDuringDeleteTopic hangs >

[jira] [Commented] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

2014-04-08 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963675#comment-13963675 ] Timothy Chen commented on KAFKA-1363: - Updated reviewboard https://reviews.apache.org/

[jira] [Resolved] (KAFKA-1352) Reduce logging on the server

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1352. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the patch. +1 and committed to trunk after rebasin

[jira] [Commented] (KAFKA-1371) Ignore build output dirs

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963679#comment-13963679 ] Jun Rao commented on KAFKA-1371: Thanks for filing the jira. Could you attach the patch to

[jira] [Commented] (KAFKA-1372) Upgrade to Gradle 1.11

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963677#comment-13963677 ] Jun Rao commented on KAFKA-1372: Could you attach the change as a patch? I think we need t

[jira] [Commented] (KAFKA-1370) Gradle startup script for Windows

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963680#comment-13963680 ] Jun Rao commented on KAFKA-1370: Could you attach the change as a patch? I think we need t

[jira] [Resolved] (KAFKA-1195) windows kafka-run-class.bat not updated

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1195. Resolution: Duplicate Resolved since it's a duplicate. > windows kafka-run-class.bat not updated > ---

Re: Review Request 20083: Patch for KAFKA-1351

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/#review39852 --- Thanks for the patch. Do you have any performance numbers? - Jun Ra

Build failed in Jenkins: Kafka-trunk #154

2014-04-08 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1352; Reduce logging on the server; patched by Ivan Lyutovg; reviewed by Guozhang Wang and Jun Rao -- [...truncated 397 lines...] kafka.log.CleanerTest > testCleaningWithD

[jira] [Commented] (KAFKA-1360) Configure continuous integration (CI) for Kafka branches under active development

2014-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963752#comment-13963752 ] Jun Rao commented on KAFKA-1360: A Jenkins job is now set up on for trunk and will be trig

Kafka Jenkins job for unit tests

2014-04-08 Thread Jun Rao
We now have a Jenkins job set up for trunk. It will run testAll and jarAll after every commit (within an hour). If the test fails, an email will be sent to the dev mailing list. https://builds.apache.org/job/Kafka-trunk/ The job now fails due to unit test failures. Thanks, Jun

Re: Kafka Jenkins job for unit tests

2014-04-08 Thread Neha Narkhede
Super cool. Thanks for setting this up, Jun! On Tue, Apr 8, 2014 at 8:23 PM, Jun Rao wrote: > We now have a Jenkins job set up for trunk. It will run testAll and jarAll > after every commit (within an hour). If the test fails, an email will be > sent to the dev mailing list. > > https://builds.

Re: Review Request 20083: Patch for KAFKA-1351

2014-04-08 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/#review39861 --- core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 20130: Patch for KAFKA-1373

2014-04-08 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/#review39862 --- Ship it! Ship It! - Neha Narkhede On April 8, 2014, 11:18 p.m.,

Re: Review Request 20130: Patch for KAFKA-1373

2014-04-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/#review39863 --- Ship it! Ship It! - Timothy Chen On April 8, 2014, 11:18 p.m., J

Re: Review for the new consumer APIs

2014-04-08 Thread pushkar priyadarshi
Was trying to understand when we have subscribe then why poll is a separate API.Why cant we pass a callback in subscribe itself? On Mon, Apr 7, 2014 at 9:51 PM, Neha Narkhede wrote: > Hi, > > I'm looking for people to review the new consumers APIs. Patch is posted at > https://issues.apache.org/