[jira] [Updated] (KAFKA-1179) createMessageStreams() in javaapi.ZookeeperConsumerConnector does not throw

2014-05-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1179: -- Attachment: KAFKA-1179_2014-05-14_14:40:11.patch > createMessageStreams() in ja

Re: Review Request 19731: Patch for KAFKA-1328

2014-05-15 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 10, 2014, 12:18 a.m.) Review request for kafka. Bugs: KAFKA-1328

Review Request 21304: Fix KAFKA-1445

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21304/ --- Review request for kafka. Bugs: KAFKA-1445 https://issues.apache.org/jira/b

Re: Review Request 19731: Patch for KAFKA-1328

2014-05-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review42405 --- The javadoc for KafkaConsumer is missing in http://people.apache.or

Re: Review Request 21174: Fix KAFKA-1396

2014-05-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42576 --- core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTe

[jira] [Commented] (KAFKA-1396) fix transient unit test ProducerFailureHandlingTest.testBrokerFailure

2014-05-15 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993740#comment-13993740 ] Guozhang Wang commented on KAFKA-1396: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 21239: Patch for KAFKA-1431

2014-05-15 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21239/#review42550 --- core/src/main/scala/kafka/consumer/ConsoleConsumer.scala

[jira] [Commented] (KAFKA-1193) Data loss if broker is killed using kill -9

2014-05-15 Thread Hanish Bansal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994155#comment-13994155 ] Hanish Bansal commented on KAFKA-1193: -- Neha, i was quite busy and couldn't get time

[jira] [Created] (KAFKA-1440) Per-request tracing

2014-05-15 Thread Todd Palino (JIRA)
Todd Palino created KAFKA-1440: -- Summary: Per-request tracing Key: KAFKA-1440 URL: https://issues.apache.org/jira/browse/KAFKA-1440 Project: Kafka Issue Type: Improvement Components: c

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-05-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1438: - Labels: newbie tools usability (was: ) > Migrate kafka client tools > --

[jira] [Commented] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-05-15 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993760#comment-13993760 ] Timothy Chen commented on KAFKA-1443: - Created reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1448) Filter-plugins for messages

2014-05-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996558#comment-13996558 ] Neha Narkhede commented on KAFKA-1448: -- >> Using one topic for each event * product c

[jira] [Created] (KAFKA-1448) Filter-plugins for messages

2014-05-15 Thread JIRA
Moritz Möller created KAFKA-1448: Summary: Filter-plugins for messages Key: KAFKA-1448 URL: https://issues.apache.org/jira/browse/KAFKA-1448 Project: Kafka Issue Type: Wish Componen

Re: Review Request 21239: Patch for KAFKA-1431

2014-05-15 Thread Sriharsha Chintalapani
> On May 8, 2014, 10:48 p.m., Neha Narkhede wrote: > > Thanks for the feedback. I added checkZkPathExists method to check if the offsets for given topic & groupid exists and removed tryCleanZookeeper method its not being used anywhere else in the code. - Sriharsha

Re: Review Request 21240: Patch for KAFKA-1179

2014-05-15 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21240/ --- (Updated May 14, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-1179

[jira] [Created] (KAFKA-1452) Killing last replica for partition doesn't change ISR/Leadership if replica is running controller

2014-05-15 Thread Alexander Demidko (JIRA)
Alexander Demidko created KAFKA-1452: Summary: Killing last replica for partition doesn't change ISR/Leadership if replica is running controller Key: KAFKA-1452 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Commented] (KAFKA-1396) fix transient unit test ProducerFailureHandlingTest.testBrokerFailure

2014-05-15 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996882#comment-13996882 ] Guozhang Wang commented on KAFKA-1396: -- Created reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1179) createMessageStreams() in javaapi.ZookeeperConsumerConnector does not throw

2014-05-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998096#comment-13998096 ] Sriharsha Chintalapani commented on KAFKA-1179: --- Updated reviewboard https:/

Failed to build Kafka using IntelliJ

2014-05-15 Thread Sheng Wang
Hi, I am trying to use IntelliJ to build Kafka. I use java 1.7.0_55-b13 on Mac OS X Mavericks. The "gradlew jar" commands etc. worked fine. However, I cannot use IntelliJ to build the project. I got some errors when I used IntelliJ 13.1 to build the project. Could anyone tell how I can solve thi

[jira] [Updated] (KAFKA-1431) ConsoleConsumer - Option to clean zk consumer path

2014-05-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1431: -- Attachment: KAFKA-1431_2014-05-14_12:08:47.patch > ConsoleConsumer - Option to

[jira] [Commented] (KAFKA-1432) Make num.producerThreads configurable on new MirrrorMaker

2014-05-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992488#comment-13992488 ] Jun Rao commented on KAFKA-1432: Thanks for the followup patch. +1 and committed to trunk.

Review Request 21272: Patch for KAFKA-1443

2014-05-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21272/ --- Review request for kafka. Bugs: KAFKA-1443 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1442) RBTools post-review is deprecated

2014-05-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993239#comment-13993239 ] Neha Narkhede commented on KAFKA-1442: -- Updated reviewboard https://reviews.apache.or

[jira] [Comment Edited] (KAFKA-1449) Extend wire protocol to allow CRC32C

2014-05-15 Thread Albert Strasheim (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998466#comment-13998466 ] Albert Strasheim edited comment on KAFKA-1449 at 5/15/14 5:50 AM: --

[jira] [Updated] (KAFKA-1396) fix transient unit test ProducerFailureHandlingTest.testBrokerFailure

2014-05-15 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1396: - Attachment: KAFKA-1396.patch > fix transient unit test ProducerFailureHandlingTest.testBrokerFail

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

2014-05-15 Thread Simon Cooper (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997719#comment-13997719 ] Simon Cooper commented on KAFKA-1352: - Another example is when there's an exception in

Review Request 21240: Patch for KAFKA-1179

2014-05-15 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21240/ --- Review request for kafka. Bugs: KAFKA-1179 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992931#comment-13992931 ] Neha Narkhede commented on KAFKA-1316: -- [~jkreps] At a high level, this seems great.

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 14, 2014, 11:28 p.m.) Review request for kafka. Bugs: KAFKA-1445

Re: Failed to build Kafka using IntelliJ

2014-05-15 Thread Timothy Chen
It seems like that you generated your idea files you were on a different scala version than what you configured it to be. Can you try to set your scala version to 2.9.2 in your gradle.properties, and do a ./gradlew clean idea, and try again? Tim On Tue, May 13, 2014 at 11:26 PM, Sheng Wang wro

[jira] [Commented] (KAFKA-1445) New Producer should send all partitions that have non-empty batches when on of them is ready

2014-05-15 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998260#comment-13998260 ] Guozhang Wang commented on KAFKA-1445: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21398/ --- (Updated May 14, 2014, 11:24 p.m.) Review request for kafka. Bugs: KAFKA-1445

[jira] [Commented] (KAFKA-1449) Extend wire protocol to allow CRC32C

2014-05-15 Thread Albert Strasheim (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998466#comment-13998466 ] Albert Strasheim commented on KAFKA-1449: - Attributes in Message has 6 bits to pla

Review Request 21174: Fix KAFKA-1396

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- Review request for kafka. Bugs: KAFKA-1396 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1431) ConsoleConsumer - Option to clean zk consumer path

2014-05-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997868#comment-13997868 ] Sriharsha Chintalapani commented on KAFKA-1431: --- Updated reviewboard https:/

[jira] [Comment Edited] (KAFKA-1449) Extend wire protocol to allow CRC32C

2014-05-15 Thread Albert Strasheim (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998466#comment-13998466 ] Albert Strasheim edited comment on KAFKA-1449 at 5/15/14 5:49 AM: --

[jira] [Created] (KAFKA-1445) New Producer should send all partitions that have non-empty batches when on of them is ready

2014-05-15 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1445: Summary: New Producer should send all partitions that have non-empty batches when on of them is ready Key: KAFKA-1445 URL: https://issues.apache.org/jira/browse/KAFKA-1445

[jira] [Commented] (KAFKA-1431) ConsoleConsumer - Option to clean zk consumer path

2014-05-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997907#comment-13997907 ] Sriharsha Chintalapani commented on KAFKA-1431: --- Updated reviewboard https:/

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-15 Thread Guozhang Wang
> On May 14, 2014, 4:31 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > lines 204-247 > > > > > > Could the two loops be merged into a single loop