Re: Review Request 23291: Patch for KAFKA-1528

2014-07-07 Thread Jun Rao
> On July 6, 2014, 5:01 p.m., Jun Rao wrote: > > .gitattributes, lines 1-2 > > > > > > Thanks for the patch. Since we explicitly specify the text types, do we > > still need this line? > > Evgeny Vereshchagin wrote: >

RE: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
Jay, About 1), I just remembered why I did not use a while loop inside forceUpdate, which is because every time we are interrupted but not jumping out of the loop, we need to call sender.wakeup(), which can only be done in the caller. Guozhang From: Jay Kreps [n

RE: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
I have changed the semantics of awaitUpdate (renamed from forceUpdate) to "wait for one update on the metadata, but if the current metadata version is already larger than the known last version that was passed in, return immediately". How do you think of this change? Guozhang

[jira] [Comment Edited] (KAFKA-1457) Nginx Kafka Integration

2014-07-07 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054247#comment-14054247 ] Daniel Compton edited comment on KAFKA-1457 at 7/7/14 10:26 PM:

[jira] [Commented] (KAFKA-1457) Nginx Kafka Integration

2014-07-07 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054247#comment-14054247 ] Daniel Compton commented on KAFKA-1457: --- Hi Darion Would something like https://git

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 7, 2014, 9:17 p.m.) Review request for kafka. Bugs: KAFKA-1515

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/#review47414 --- Three very minor issues: 1. It would be good to use a while loop whe

[jira] Subscription: outstanding kafka patches

2014-07-07 Thread jira
Issue Subscription Filter: outstanding kafka patches (99 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1529 transient unit test failure in testAutoCreateAfterDeleteTopic https://issues.apache.org/jira/browse/KAFKA-1529 KAFKA-152

[jira] [Updated] (KAFKA-1515) Wake-up Sender upon blocked on fetching leader metadata

2014-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1515: - Attachment: KAFKA-1515_2014-07-07_10:55:58.patch > Wake-up Sender upon blocked on fetching leader

[jira] [Commented] (KAFKA-1515) Wake-up Sender upon blocked on fetching leader metadata

2014-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053929#comment-14053929 ] Guozhang Wang commented on KAFKA-1515: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 7, 2014, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-1515

[jira] [Updated] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-07-07 Thread Raul Castro Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Castro Fernandez updated KAFKA-1525: - Assignee: Dong Lin (was: Raul Castro Fernandez) > DumpLogSegments should print t

[jira] [Updated] (KAFKA-1526) Producer performance tool should have an option to enable transactions

2014-07-07 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1526: Assignee: Raul Castro Fernandez (was: Dong Lin) > Producer performance tool should have an option to enabl

Re: Review Request 23294: Patch for KAFKA-1529

2014-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23294/#review47389 --- Ship it! Ship It! - Guozhang Wang On July 6, 2014, 6:40 p.m., Ju

Kafka 0.8.x failover with multiple data centers

2014-07-07 Thread Janos Mucza
Dear Kafka Users, I would like to use Kafka 0.8.x in a multi-cluster environment so that when my primary cluster fails, producers and consumers could switch to the secondary cluster. Clusters would be hosted in different data centers. A possibility would be mirroring topics (similar to Kafka 0.