(New) reviewer field in Kafka jiras

2014-08-28 Thread Joel Koshy
I had requested infra to add a reviewer field in our jiras - https://issues.apache.org/jira/browse/INFRA-8189 Hopefully it will make it easier to formally keep track of a review owner for each jira. It goes without saying that it should not be interpreted as sole reviewer - i.e., more than one per

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Reviewer: Jun Rao > Rebalance algorithm should consider partitions from all topics > -

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1374: -- Reviewer: Joel Koshy Assignee: Manikumar Reddy (was: Joel Koshy) > LogCleaner (compaction) does no

[jira] [Resolved] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

2014-08-28 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Palino resolved KAFKA-1588. Resolution: Won't Fix > Offset response does not support two requests for the same topic/partition

[jira] [Commented] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

2014-08-28 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114814#comment-14114814 ] Todd Palino commented on KAFKA-1588: I believe that since this involves significant ch

Build failed in Jenkins: Kafka-trunk #255

2014-08-28 Thread Apache Jenkins Server
See Changes: [joe.stein] KAFKA-1485 Upgrade to Zookeeper 3.4.6 and create shim for ZKCLI so system tests can run patch by Gwen Shapira reviewed by Joe Stein and Jun Rao -- [...truncated 747 lines...]

Re: Review Request 24676: Fix KAFKA-1583

2014-08-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review51855 --- core/src/main/scala/kafka/cluster/Partition.scala

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-28 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1485: - Resolution: Fixed Status: Resolved (was: Patch Available) +1 committed to trunk > Upgrade to Zo

[jira] [Assigned] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-08-28 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira reassigned KAFKA-1618: --- Assignee: Gwen Shapira > Exception thrown when running console producer with no port number f

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-08-28 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114689#comment-14114689 ] Joe Stein commented on KAFKA-1618: -- +1 to guess a default port, would be great to make th

[jira] [Created] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-08-28 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1618: --- Summary: Exception thrown when running console producer with no port number for the broker Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project

Re: Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review51850 --- core/src/main/scala/kafka/server/RequestPurgatory.scala

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-28_16:20:25.patch > Rebalance algorithm should consider partitions from all

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114578#comment-14114578 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard https://reviews.apache.org/r/23655

Re: Review Request 23655: Patch for KAFKA-687

2014-08-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/ --- (Updated Aug. 28, 2014, 11:20 p.m.) Review request for kafka. Bugs: KAFKA-687

Re: Jira tickets for starter bugs

2014-08-28 Thread Bill Bejeck
Great Thanks! On Thu, Aug 28, 2014 at 7:04 PM, Joe Stein wrote: > It would be great if you could assign it to yourself or ask someone to > assign it to you (comment in ticket or ask on list). If you don't have > access to assign to yourself we can add you as a contributor, not a problem > jus

Re: Jira tickets for starter bugs

2014-08-28 Thread Joe Stein
It would be great if you could assign it to yourself or ask someone to assign it to you (comment in ticket or ask on list). If you don't have access to assign to yourself we can add you as a contributor, not a problem just need your username for JIRA. Having tickets assigned to you gives you cred

Jira tickets for starter bugs

2014-08-28 Thread Bill Bejeck
Hi, For the starter bugs, do I need to have the jira ticket assigned to me, or do I just do the work and submit a pull request? Thanks, Bill

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114390#comment-14114390 ] Jun Rao commented on KAFKA-1282: Thanks for the patch. The following should be * 100,

[jira] [Created] (KAFKA-1617) Move Metadata Cache to TopicManager and handling of Offset Request to LogManager

2014-08-28 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1617: Summary: Move Metadata Cache to TopicManager and handling of Offset Request to LogManager Key: KAFKA-1617 URL: https://issues.apache.org/jira/browse/KAFKA-1617 Projec

Re: Review Request 25136: KAFKA-1610-Review Request

2014-08-28 Thread Mayuresh Gharat
> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 20 > > > > > > Is this necessary? ReassignedPartitionContext seems not used anywhere. No. I

[jira] [Commented] (KAFKA-1612) Consumer offsets auto-commit before processing finishes

2014-08-28 Thread Gian Merlino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114320#comment-14114320 ] Gian Merlino commented on KAFKA-1612: - I am currently working around this by setting a

[jira] [Updated] (KAFKA-1502) source jar is empty

2014-08-28 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1502: - Fix Version/s: 0.8.2 > source jar is empty > --- > > Key: KAFKA-1502 >

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-28 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114248#comment-14114248 ] nicu marasoiu commented on KAFKA-1282: -- [~nehanarkhede] Hi, I implemented our discuss

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-28 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114244#comment-14114244 ] nicu marasoiu commented on KAFKA-1510: -- Hi, I will do this tomorrow, Friday, so I hop

Re: Review Request 25136: KAFKA-1610-Review Request

2014-08-28 Thread Guozhang Wang
> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > Thanks for the patch, some general comments: > > > > 1. In general we would like to avoid using ._1 and ._2 simply due to > > clarity of the code; instead we can use { case (key, value) => }. > > 2. After thinking about it twice, I think

[jira] [Issue Comment Deleted] (KAFKA-1362) Publish sources and javadoc jars

2014-08-28 Thread Daniel Wegener (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Wegener updated KAFKA-1362: -- Comment: was deleted (was: Hallo, ich bin bis zum 18.08.2014 im Urlaub und lese meine E-Mails

[jira] Subscription: outstanding kafka patches

2014-08-28 Thread jira
Issue Subscription Filter: outstanding kafka patches (128 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1616 Purgatory Size and Num.Delayed.Request metrics are incorrect https://issues.apache.org/jira/browse/KAFKA-1616 KAFKA-161

Re: Review Request 25136: KAFKA-1610-Review Request

2014-08-28 Thread Mayuresh Gharat
> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > Thanks for the patch, some general comments: > > > > 1. In general we would like to avoid using ._1 and ._2 simply due to > > clarity of the code; instead we can use { case (key, value) => }. > > 2. After thinking about it twice, I think

Re: Review Request 23655: Patch for KAFKA-687

2014-08-28 Thread Joel Koshy
> On Aug. 28, 2014, 1:32 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 721 > > > > > > Could we use case to avoid _._1 ? > > > > Also, could you explai

Re: Review Request 23655: Patch for KAFKA-687

2014-08-28 Thread Joel Koshy
> On Aug. 28, 2014, 1:32 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConfig.scala, line 52 > > > > > > This probably should be named DefaultPartitionAssignmentStrategy. Ok - it seems a number of

Re: Review Request 25044: KAFKA-1611 - Improve system test configuration

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25044/#review51803 --- Ship it! Thanks for the patch. LGTM. - Guozhang Wang On Aug. 26,

Re: Review Request 25136: KAFKA-1610-Review Request

2014-08-28 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Aug. 28, 2014, 6:12 p.m.) Review request for kafka. Bugs: KAFKA-1610

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

2014-08-28 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114079#comment-14114079 ] Jonathan Natkins commented on KAFKA-1420: - Wanted to bump this ticket so the patch

Re: Review Request 25136: KAFKA-1610-Review Request

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review51793 --- Thanks for the patch, some general comments: 1. In general we woul

[jira] [Updated] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1616: - Attachment: KAFKA-1616_2014-08-28_10:12:17.patch > Purgatory Size and Num.Delayed.Request metrics

[jira] [Commented] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113984#comment-14113984 ] Guozhang Wang commented on KAFKA-1616: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1616: - Status: Patch Available (was: Open) > Purgatory Size and Num.Delayed.Request metrics are incorre

[jira] [Updated] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1616: - Attachment: KAFKA-1616.patch > Purgatory Size and Num.Delayed.Request metrics are incorrect > ---

[jira] [Commented] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113981#comment-14113981 ] Guozhang Wang commented on KAFKA-1616: -- Created reviewboard https://reviews.apache.or

Re: Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Aug. 28, 2014, 5:12 p.m.) Review request for kafka. Bugs: KAFKA-1616

Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- Review request for kafka. Bugs: KAFKA-1616 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

2014-08-28 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1616: Summary: Purgatory Size and Num.Delayed.Request metrics are incorrect Key: KAFKA-1616 URL: https://issues.apache.org/jira/browse/KAFKA-1616 Project: Kafka I

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-08-28 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113641#comment-14113641 ] Otis Gospodnetic commented on KAFKA-1481: - bq. if you know the clientId, you can p