Review Request 26340: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- Review request for kafka. Bugs: KAFKA-1277

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Keep the

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159071#comment-14159071 ] Manikumar Reddy commented on KAFKA-1277: Created reviewboard

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277.patch Keep the summery/description when updating the RB with

Re: Review Request 26340: KAFKA-1277; Keep the summary/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:12 a.m.) Review request for kafka. Summary

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159074#comment-14159074 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_16:39:56.patch Keep the summery/description when updating

Re: Review Request 26340: KAFKA-1277; Keep the summary/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:23 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159078#comment-14159078 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_16:51:20.patch Keep the summery/description when updating

Re: Review Request 26340: KAFKA-1277; Keep the summary/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:29 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_16:57:30.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159079#comment-14159079 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26340: Testing this patch

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:32 a.m.) Review request for kafka. Summary

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_17:00:37.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159081#comment-14159081 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26340: Testing this patch

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:33 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_17:01:43.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159082#comment-14159082 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26340: Testing this patch

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:35 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_17:03:08.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159083#comment-14159083 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-04_17:09:02.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159084#comment-14159084 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26340: Testing this patch

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26340/ --- (Updated Oct. 4, 2014, 11:41 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159088#comment-14159088 ] Manikumar Reddy commented on KAFKA-1277: In this patch, I disabled the

Review Request 26341: Patch for KAFKA-1057

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26341/ --- Review request for kafka. Bugs: KAFKA-1057

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1057: --- Attachment: KAFKA-1057.patch Trim whitespaces from user specified configs

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1057: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Trim whitespaces from

[jira] [Commented] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159094#comment-14159094 ] Manikumar Reddy commented on KAFKA-1057: Created reviewboard

Re: Review Request 26341: Patch for KAFKA-1057

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26341/ --- (Updated Oct. 4, 2014, 2:48 p.m.) Review request for kafka. Bugs: KAFKA-1057

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1057: --- Attachment: KAFKA-1057_2014-10-04_20:15:32.patch Trim whitespaces from user specified

[jira] [Commented] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159149#comment-14159149 ] Manikumar Reddy commented on KAFKA-1057: Updated reviewboard

Re: Humble request for wiki comment privileges

2014-10-04 Thread Joe Stein
What is your confluence username? On Oct 2, 2014 7:45 PM, Jarek Jarcec Cecho jar...@apache.org wrote: Might I humbly request wiki comment privileges? I would like to comment the Security proposal wiki page. Jarcec

Re: Humble request for wiki comment privileges

2014-10-04 Thread Jarek Jarcec Cecho
Simply “jarcec” :) Jarcec On Oct 4, 2014, at 12:43 PM, Joe Stein joe.st...@stealth.ly wrote: What is your confluence username? On Oct 2, 2014 7:45 PM, Jarek Jarcec Cecho jar...@apache.org wrote: Might I humbly request wiki comment privileges? I would like to comment the Security proposal

Re: Humble request for wiki comment privileges

2014-10-04 Thread Joe Stein
done /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop http://www.twitter.com/allthingshadoop / On Sat, Oct 4, 2014 at 3:45 PM,

Re: Humble request for wiki comment privileges

2014-10-04 Thread Jarek Jarcec Cecho
Thank you Joe! Jarcec On Oct 4, 2014, at 12:46 PM, Joe Stein joe.st...@stealth.ly wrote: done /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop

[jira] [Assigned] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1670: - Assignee: Sriharsha Chintalapani Corrupt log files for segment.bytes

[jira] [Commented] (KAFKA-1624) building on JDK 8 fails

2014-10-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159286#comment-14159286 ] Ismael Juma commented on KAFKA-1624: Note that Scala 2.10.4 also includes a number of

Review Request 26346: Patch for KAFKA-1670

2014-10-04 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/ --- Review request for kafka. Bugs: KAFKA-1670

[jira] [Commented] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159309#comment-14159309 ] Sriharsha Chintalapani commented on KAFKA-1670: --- Created reviewboard

[jira] [Updated] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1670: -- Status: Patch Available (was: Open) Corrupt log files for segment.bytes

[jira] [Updated] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1670: -- Attachment: KAFKA-1670.patch Corrupt log files for segment.bytes values close

[jira] [Commented] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159312#comment-14159312 ] Sriharsha Chintalapani commented on KAFKA-1670: --- This is caused by maybeRoll

[jira] [Updated] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1670: -- Fix Version/s: 0.8.2 Corrupt log files for segment.bytes values close to

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159338#comment-14159338 ] Neha Narkhede commented on KAFKA-1277: -- [~omkreddy] I tried testing the patch, but it

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1277: - Reviewer: Neha Narkhede Keep the summery/description when updating the RB with

Re: Review Request 26346: Patch for KAFKA-1670

2014-10-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/#review55455 --- Can you try to add a unit test for this?

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review55456 --- Can you try to add a unit test for this?

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1057: - Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.3

Build failed in Jenkins: Kafka-trunk #287

2014-10-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/287/changes Changes: [neha.narkhede] KAFKA-1057 Trim whitespaces from user specified configs; reviewed by Neha Narkhede -- [...truncated 397 lines...] kafka.admin.TopicCommandTest

[jira] [Updated] (KAFKA-1648) Round robin consumer balance throws an NPE when there are no topics

2014-10-04 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1648: --- Attachment: KAFKA-1648_2014-10-04_17:40:47.patch Round robin consumer balance throws an NPE

[jira] [Updated] (KAFKA-1663) Controller unable to shutdown after a soft failure

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1663: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch! Pushed

[jira] [Commented] (KAFKA-1558) AdminUtils.deleteTopic does not work

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159379#comment-14159379 ] Neha Narkhede commented on KAFKA-1558: -- [~sriharsha] Now that KAFKA-1663 is pushed to

[jira] [Commented] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159388#comment-14159388 ] Neha Narkhede commented on KAFKA-1631: -- The behavior of partition reassignment being

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159389#comment-14159389 ] Neha Narkhede commented on KAFKA-328: - [~balaji.sesha...@dish.com] I use Intellij 13

Jenkins build is back to normal : Kafka-trunk #288

2014-10-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/288/changes

[jira] [Resolved] (KAFKA-1385) mirrormaker hangs during shutdown if no topic is consumed

2014-10-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1385. -- Resolution: Fixed Fixed by patch for KAFKA-1650 mirrormaker hangs during shutdown if no

Re: Review Request 26346: Patch for KAFKA-1670

2014-10-04 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/ --- (Updated Oct. 5, 2014, 3:17 a.m.) Review request for kafka. Bugs: KAFKA-1670

[jira] [Commented] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159407#comment-14159407 ] Sriharsha Chintalapani commented on KAFKA-1670: --- Updated reviewboard

[jira] [Updated] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1670: -- Attachment: KAFKA-1670_2014-10-04_20:17:46.patch Corrupt log files for

Re: Review Request 26346: Patch for KAFKA-1670

2014-10-04 Thread Sriharsha Chintalapani
On Oct. 4, 2014, 11:28 p.m., Neha Narkhede wrote: Can you try to add a unit test for this? I added unit test under LogTest. This test very basic its just adds messages to file until the file reaches Int.Max. This will result in couple of issues first being atleast having 2G+ tmp space and

[jira] [Commented] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

2014-10-04 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159411#comment-14159411 ] Sriharsha Chintalapani commented on KAFKA-1670: --- [~nehanarkhede] [~junrao]

Review Request 26348: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26348/ --- Review request for kafka. Bugs: KAFKA-1277

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159436#comment-14159436 ] Manikumar Reddy commented on KAFKA-1277: Created reviewboard

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277.patch Keep the summery/description when updating the RB with

Re: Review Request 26348: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26348/ --- (Updated Oct. 5, 2014, 5:37 a.m.) Review request for kafka. Bugs: KAFKA-1277

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159437#comment-14159437 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26348: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26348/ --- (Updated Oct. 5, 2014, 5:41 a.m.) Review request for kafka. Bugs: KAFKA-1277

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-05_11:09:08.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159439#comment-14159439 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Re: Review Request 26348: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26348/ --- (Updated Oct. 5, 2014, 5:43 a.m.) Review request for kafka. Bugs: KAFKA-1277

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-05_11:10:50.patch Keep the summery/description when updating

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159441#comment-14159441 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard

Review Request 26349: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26349/ --- Review request for kafka. Bugs: KAFKA-1277

[jira] [Updated] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-10-04 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-328: - Attachment: KAFKA-328-FORMATTED.patch Write unit test for kafka server startup and shutdown API

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159444#comment-14159444 ] Manikumar Reddy commented on KAFKA-1277: Created reviewboard

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-10-04 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159445#comment-14159445 ] BalajiSeshadri commented on KAFKA-328: -- [~nehanarkhede] Please find patch for Startup

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277.patch Keep the summery/description when updating the RB with

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1277: --- Attachment: KAFKA-1277_2014-10-05_11:18:17.patch Keep the summery/description when updating

Re: Review Request 26349: Patch for KAFKA-1277

2014-10-04 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26349/ --- (Updated Oct. 5, 2014, 5:51 a.m.) Review request for kafka. Bugs: KAFKA-1277

[jira] [Commented] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2014-10-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159446#comment-14159446 ] Manikumar Reddy commented on KAFKA-1277: Updated reviewboard