[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-06 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-06_18:58:57.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-06 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237032#comment-14237032 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-06 Thread Jiangjie Qin
> On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: > > Thanks for the patch. Some comments below. Thank you very much for the review. > On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 529-530 > >

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-06 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 7, 2014, 2:59 a.m.) Review request for kafka. Bugs: KAFKA-1650

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review64152 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf