Re: Review Request 25944: Patch for KAFKA-1013

2014-12-21 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 10:42 p.m.) Review request for kafka. Bugs: KAFKA-101

[jira] [Updated] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

2014-12-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1013: --- Attachment: KAFKA-1013_2014-12-21_14:42:49.patch > Modify existing tools as per the changes in

[jira] [Commented] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

2014-12-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255286#comment-14255286 ] Mayuresh Gharat commented on KAFKA-1013: Updated reviewboard https://reviews.apach

Re: Review Request 26291: Patch for KAFKA-1648

2014-12-21 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Dec. 21, 2014, 10:45 p.m.) Review request for kafka. Bugs: KAFKA-164

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-21 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 142 > > > > > > This and a lot of the rest of the code exists in ClientUtils. Until the > > refactoring

Re: Review Request 25944: Patch for KAFKA-1013

2014-12-21 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 11:06 p.m.) Review request for kafka and joel koshy.