Re: Review Request 29210: Patch for KAFKA-1819

2014-12-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review65866 --- core/src/main/scala/kafka/log/LogCleaner.scala

[jira] [Commented] (KAFKA-1822) Add "echo" request

2014-12-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256574#comment-14256574 ] Joe Stein commented on KAFKA-1822: -- Can we utilize the ClusterMetadataRequest and Cluster

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2014-12-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256569#comment-14256569 ] Joe Stein commented on KAFKA-1824: -- Shouldn't this go into 0.8.2 branch also since it is

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-22 Thread Jiangjie Qin
> On Dec. 18, 2014, 10:42 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 614 > > > > > > Should this be fatal? i.e., fatal is normally used before exiting > > (abnormally). WARN w

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-22_19:07:24.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256536#comment-14256536 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-22 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 23, 2014, 3:07 a.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2014-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256363#comment-14256363 ] Gwen Shapira commented on KAFKA-1824: - I added tests, I also did some refactoring to C

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2014-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256355#comment-14256355 ] Gwen Shapira commented on KAFKA-1824: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2014-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1824: Attachment: KAFKA-1824_2014-12-22_16:17:42.patch > in ConsoleProducer - properties key.separator and

Re: Review Request 29231: Patch for KAFKA-1824

2014-12-22 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29231/ --- (Updated Dec. 23, 2014, 12:17 a.m.) Review request for kafka. Bugs: KAFKA-182

[jira] [Updated] (KAFKA-1826) add command to delete all consumer group information for a topic in zookeeper

2014-12-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1826: - Reviewer: Neha Narkhede > add command to delete all consumer group information for a topic in zook

[jira] [Commented] (KAFKA-1826) add command to delete all consumer group information for a topic in zookeeper

2014-12-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256334#comment-14256334 ] Neha Narkhede commented on KAFKA-1826: -- [~onurkaraman], as I mentioned before, this a

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2014-12-22 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256255#comment-14256255 ] Parth Brahmbhatt commented on KAFKA-1788: - [~nehanarkhede] [~junrao] Can you provi

[jira] [Updated] (KAFKA-1806) broker fetch request uses old leader offset which is higher than current leader offset causes error

2014-12-22 Thread lokesh Birla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lokesh Birla updated KAFKA-1806: Priority: Blocker (was: Major) > broker fetch request uses old leader offset which is higher than c

[jira] [Comment Edited] (KAFKA-727) broker can still expose uncommitted data to a consumer

2014-12-22 Thread lokesh Birla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256154#comment-14256154 ] lokesh Birla edited comment on KAFKA-727 at 12/22/14 8:29 PM: --

[jira] [Commented] (KAFKA-727) broker can still expose uncommitted data to a consumer

2014-12-22 Thread lokesh Birla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256154#comment-14256154 ] lokesh Birla commented on KAFKA-727: Hi Jun and Jay, I filed https://issues.apache.org

[jira] [Commented] (KAFKA-1806) broker fetch request uses old leader offset which is higher than current leader offset causes error

2014-12-22 Thread lokesh Birla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256104#comment-14256104 ] lokesh Birla commented on KAFKA-1806: - Neha, Could you please update on this? With my

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-12-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255956#comment-14255956 ] Jun Rao commented on KAFKA-1481: Ok, the metric does show up. By default, the flush is onl

[jira] [Commented] (KAFKA-1822) Add "echo" request

2014-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255950#comment-14255950 ] Gwen Shapira commented on KAFKA-1822: - Thanks for the headsup about Heartbeat, [~joest

[jira] [Commented] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2014-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255942#comment-14255942 ] Gwen Shapira commented on KAFKA-1814: - Thanks for the update, Stefan. Glad you got it

[jira] [Comment Edited] (KAFKA-1693) Issue sending more messages to single Kafka server (Load testing for Kafka transport)

2014-12-22 Thread Rasmeet Devji (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255900#comment-14255900 ] Rasmeet Devji edited comment on KAFKA-1693 at 12/22/14 4:38 PM:

[jira] [Commented] (KAFKA-1693) Issue sending more messages to single Kafka server (Load testing for Kafka transport)

2014-12-22 Thread Rasmeet Devji (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255900#comment-14255900 ] Rasmeet Devji commented on KAFKA-1693: -- Faced the same issue with Kafka 811, Java 6 o

[jira] [Comment Edited] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-12-22 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255875#comment-14255875 ] Vladimir Tretyakov edited comment on KAFKA-1481 at 12/22/14 4:07 PM: ---

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-12-22 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255875#comment-14255875 ] Vladimir Tretyakov commented on KAFKA-1481: --- Already did, waited more than 1 day

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-12-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255845#comment-14255845 ] Jun Rao commented on KAFKA-1481: The JMX will be registered the first time that the flush

[jira] [Comment Edited] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

2014-12-22 Thread Jason Kania (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255816#comment-14255816 ] Jason Kania edited comment on KAFKA-1817 at 12/22/14 3:15 PM: --

[jira] [Commented] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

2014-12-22 Thread Jason Kania (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255816#comment-14255816 ] Jason Kania commented on KAFKA-1817: Here is my exact code which does not work to crea

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-22 Thread Joel Koshy
> On Dec. 18, 2014, 10:42 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 614 > > > > > > Should this be fatal? i.e., fatal is normally used before exiting > > (abnormally). WARN w

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-22 Thread Joel Koshy
> On Dec. 17, 2014, 1:17 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 489 > > > > > > Why not use KafkaScheduler for the offset commit task? > > Jiangjie Qin wrote: > Haven'

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65759 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-12-22 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255722#comment-14255722 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi guys, maybe it is not a best pla

[jira] [Comment Edited] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

2014-12-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255709#comment-14255709 ] Andrii Biletskyi edited comment on KAFKA-1817 at 12/22/14 1:08 PM: -

[jira] [Commented] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

2014-12-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255709#comment-14255709 ] Andrii Biletskyi commented on KAFKA-1817: - Can you please elaborate on the issue?

[jira] [Closed] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2014-12-22 Thread Stefan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan closed KAFKA-1814. -- Configuration problem, not an issue. > FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown

[jira] [Commented] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2014-12-22 Thread Stefan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255620#comment-14255620 ] Stefan commented on KAFKA-1814: Yes, it's was configuration problem that I fixed, now Kaf

[jira] [Created] (KAFKA-1827) Optimistic Locking when Producing Messages

2014-12-22 Thread Daniel Schierbeck (JIRA)
Daniel Schierbeck created KAFKA-1827: Summary: Optimistic Locking when Producing Messages Key: KAFKA-1827 URL: https://issues.apache.org/jira/browse/KAFKA-1827 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-1694) kafka command line and centralized operations

2014-12-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1694: Status: Patch Available (was: Open) > kafka command line and centralized operations > -

[jira] [Updated] (KAFKA-1694) kafka command line and centralized operations

2014-12-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1694: Attachment: KAFKA-1694.patch > kafka command line and centralized operations > -

[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

2014-12-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255566#comment-14255566 ] Andrii Biletskyi commented on KAFKA-1694: - Created reviewboard https://reviews.apa

Review Request 29301: Patch for KAFKA-1694

2014-12-22 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- Review request for kafka. Bugs: KAFKA-1694 https://issues.apache.org/jira/b