[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2014-12-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258803#comment-14258803 ] Jeff Holoman commented on KAFKA-1782: - Given the timing, is it best to move the fix

Re: Review Request 28769: Patch for KAFKA-1809

2014-12-25 Thread Gwen Shapira
On Dec. 6, 2014, 7:40 a.m., Joe Stein wrote: core/src/main/scala/kafka/cluster/Broker.scala, line 40 https://reviews.apache.org/r/28769/diff/1/?file=783935#file783935line40 More JSON, k! We need to change parsers I think or change using JSON this is in a few other tickets

Re: Review Request 28769: Patch for KAFKA-1809

2014-12-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/ --- (Updated Dec. 25, 2014, 7:04 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2014-12-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258834#comment-14258834 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard

[jira] [Updated] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2014-12-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1809: Attachment: KAFKA-1809_2014-12-25_11:04:17.patch Refactor brokers to allow listening on multiple

Re: Review Request 28769: Patch for KAFKA-1809

2014-12-25 Thread Gwen Shapira
On Dec. 6, 2014, 7:40 a.m., Joe Stein wrote: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 95 https://reviews.apache.org/r/28769/diff/1/?file=783984#file783984line95 PLAINTEXT here should be read and matched to it's int from the SecurityProtocol statics also.

Re: Review Request 29029: Patch for KAFKA-1512

2014-12-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review66134 --- Ship it! Non-binding +1 - the fix and test look good. - Gwen

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1650: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk Mirror Maker