Re: Review request for patch attached to KAFKA-1836

Sounds good, if you need access to Confluence send along your Confluence username and I will grant you access if you need to update the document. /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitte

Re: Review request for patch attached to KAFKA-1836

Thanks Joe, I'll do that. I had indeed quickly looked at that document over the weekend but I saw that it was missing instructions for Debian based systems (am on LinuxMint) and so decided to skip that for now till I understand the whole tool chain. I'll see which of these tools I need to insta

[jira] [Updated] (KAFKA-1836) metadata.fetch.timeout.ms set to zero blocks forever

[ https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1836: - Fix Version/s: 0.8.3 > metadata.fetch.timeout.ms set to zero blocks forever >

Re: Review request for patch attached to KAFKA-1836

Hi Jaikiran, do you mind utilizing the kafka patch review tool please https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool as it is helpful for folks to comment on your code lines as it posts to review board for you and updates JIRA too. /**

Review request for patch attached to KAFKA-1836

Hello Kafka team, I was just looking around some newbie bugs in the JIRA, during the weekend, and decided to take up https://issues.apache.org/jira/browse/KAFKA-1836. I've a patch, which I've attached to that JIRA a few days back, which I would like to be reviewed. The patch handles the case

Jenkins build is back to normal : Kafka-trunk #362

See

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1512: - Resolution: Fixed Status: Resolved (was: Patch Available) committed to 0.8.2 branch and trunk, th

Re: Review Request 28769: Patch for KAFKA-1809

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review66944 --- Thanks for the patch. It's a lot work! A few general comments below,

[jira] [Commented] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267057#comment-14267057 ] Gwen Shapira commented on KAFKA-1697: - Either I'm missing something or this was trivia

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1697: Status: Patch Available (was: Open) > remove code related to ack>1 on the broker >

[jira] [Commented] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267048#comment-14267048 ] Gwen Shapira commented on KAFKA-1697: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1697: Attachment: KAFKA-1697.patch > remove code related to ack>1 on the broker >

Review Request 29647: Patch for KAFKA-1697

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/ --- Review request for kafka. Bugs: KAFKA-1697 https://issues.apache.org/jira/b

Re: Possible Memory Leak in Kafka with Tomcat

Hi, thanks for the answer. If create a spring bean wich is starting the kafka consumer and this bean has an „destroy“ function. You can see it here: https://github.com/marcelalburg/spring-integration-kafka-memory-leak/blob/master/src/main/java/org/example/kafkamemoryleak/listener/KafkaConsumerS

Re: Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review66942 --- Thinking about this more, I think this patch only covers one very sp

Re: Possible Memory Leak in Kafka with Tomcat

Hi Marcel, Memory leaks will happen when there are background threads started by webapp and not shutdown (usually lib like Code hale has shutdown hook, but web app you do get to execute shutdown hook so you get memory leaks or class not found). I have faced this so you need to either use web cont

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/#review66838 --- tools/src/main/java/org/apache/kafka/cli/command/AlterTopicCommand.

Possible Memory Leak in Kafka with Tomcat

Hello, i try to use spring-integration-kafka and after stopping the Tomcat i get an "possible memory leak" from the class loader. I talked with the people of spring-integration-kafka and you can see this talk with a lot of debug messages and an reproduceable project under: https://github.com/spr

Build failed in Jenkins: Kafka-trunk #361

See Changes: [junrao] kafka-1797; (delta follow-up patch) add the serializer/deserializer api to the new java client; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 1704 lines...] kaf

Build failed in Jenkins: Kafka-trunk #360

See Changes: [junrao] kafka-1797; (follow-up patch) add the serializer/deserializer api to the new java client; patched by Jun Rao; reviewed by Jay Kreps -- [...truncated 1731 lines...] kafka.log.Log

[jira] [Updated] (KAFKA-1489) Global threshold on data retention size

[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1489: - Fix Version/s: (was: 0.8.2) 0.8.3 Assignee: (was: Jay Kreps) > Global

[jira] [Updated] (KAFKA-1489) Global threshold on data retention size

[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1489: - Fix Version/s: 0.8.2 > Global threshold on data retention size > --- >

Re: Review Request 29590: 1. Removed defaults for serializer/deserializer. 2. Converted type cast exception to serialization exception in the producer. 3. Added string ser/deser. 4. Moved the isKey fl

> On Jan. 6, 2015, 2:13 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 433 > > > > > > This does suck. An alternative would be to default the serializer

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266634#comment-14266634 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 28769: Patch for KAFKA-1809

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/ --- (Updated Jan. 6, 2015, 7:46 p.m.) Review request for kafka. Bugs: KAFKA-1809

[jira] [Updated] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1809: Attachment: KAFKA-1809_2015-01-06_11:46:22.patch > Refactor brokers to allow listening on multiple p

[jira] [Created] (KAFKA-1843) Metadata fetch/refresh in new producer should handle all node connection states gracefully

Ewen Cheslack-Postava created KAFKA-1843: Summary: Metadata fetch/refresh in new producer should handle all node connection states gracefully Key: KAFKA-1843 URL: https://issues.apache.org/jira/browse/KAFK

[jira] [Created] (KAFKA-1842) New producer/consumer should support configurable connection timeouts

Ewen Cheslack-Postava created KAFKA-1842: Summary: New producer/consumer should support configurable connection timeouts Key: KAFKA-1842 URL: https://issues.apache.org/jira/browse/KAFKA-1842 P

[jira] [Updated] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1642: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the latest followup patch. +1 an

[jira] [Updated] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1788: Attachment: KAFKA-1788_2015-01-06_13:44:41.patch > producer record can stay in RecordAccumul

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266541#comment-14266541 ] Parth Brahmbhatt commented on KAFKA-1788: - Updated reviewboard https://reviews.apa

Re: Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Jan. 6, 2015, 6:44 p.m.) Review request for kafka. Bugs: KAFKA-1788

[jira] [Updated] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1788: Attachment: KAFKA-1788_2015-01-06_13:42:37.patch > producer record can stay in RecordAccumul

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266538#comment-14266538 ] Parth Brahmbhatt commented on KAFKA-1788: - Updated reviewboard https://reviews.apa

Re: Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/#review66879 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Jan. 6, 2015, 6:42 p.m.) Review request for kafka. Bugs: KAFKA-1788

Re: Review Request 29590: 1. Removed defaults for serializer/deserializer. 2. Converted type cast exception to serialization exception in the producer. 3. Added string ser/deser. 4. Moved the isKey fl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29590/#review66861 --- Ship it! clients/src/main/java/org/apache/kafka/clients/producer/K

Possible Memory Leak in Kafka with Tomcat

Hello, i try to use spring-integration-kafka and after stopping the Tomcat i get an "possible memory leak" from the class loader. I talked with the people of spring-integration-kafka and you can see this talk with a lot of debug messages and an reproduceable project under: https://github.com/spr

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266290#comment-14266290 ] Sriharsha Chintalapani commented on KAFKA-1646: --- [~jkreps] [~junrao] Can you

Re: Review Request 29301: Patch for KAFKA-1694

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/#review66801 --- build.gradle