[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288933#comment-14288933 ] Joel Koshy commented on KAFKA-1729: --- I was trying out the documentation I wrote on http

Re: [DISCUSS] KIP-5 - Broker Configuration Management

There is still some to-dos to be done in https://reviews.apache.org/r/29513/diff/ to use changing to ConfigDef https://reviews.apache.org/r/30126/diff/ once that is in. We can get more written up on it, will do. On Fri, Jan 23, 2015 at 12:05 AM, Jay Kreps wrote: > Hey Joe, > > Can you fill in t

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

I will go back through the ticket and code and write more up. Should be able to-do that sometime next week. The intention was to not replace existing functionality by issue a WARN on use. The following version it is released we could then deprecate it... I will fix the KIP for that too. On Fri, Ja

Re: [DISCUSS] KIP-8 - Decommission a broker

Ok On Fri, Jan 23, 2015 at 12:26 AM, Neha Narkhede wrote: > Hi Joe, > > Thanks for starting a KIP for this change. > > This feature is trivial once we agree on KIP-6 > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-6+-+New+reassignment+partition+logic+for+re-balancing > > > since > th

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

inline On Thu, Jan 22, 2015 at 11:59 PM, Jay Kreps wrote: > Hey Joe, > > This is great. A few comments on KIP-4 > > 1. This is much needed functionality, but there are a lot of the so let's > really think these protocols through. We really want to end up with a set > of well thought-out, orthoga

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

Hey Joe, 1. Could you add details to the Public Interface section of the KIP? This should include the proposed changes to the partition reassignment tool. Also, maybe the new option can be named --rebalance instead of --re-balance? 2. It makes sense to list --decommission-broker as part of this KI

Re: [DISCUSS] KIP-8 - Decommission a broker

Hi Joe, Thanks for starting a KIP for this change. This feature is trivial once we agree on KIP-6 since that feature figures out an ideal replica placement. Decomission broker is just one

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

Ditto on this one. Can you give the algorithm we want to implement? Also I think in terms of scope this is just proposing to change the logic in ReassignPartitionsCommand? I think we've had the discussion various times on the mailing list that what people really want is just for Kafka to do it's b

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

Hey Joe, This is great. A few comments on KIP-4 1. This is much needed functionality, but there are a lot of the so let's really think these protocols through. We really want to end up with a set of well thought-out, orthoganol apis. For this reason I think it is really important to think through

Re: [DISCUSS] KIP-5 - Broker Configuration Management

Hey Joe, Can you fill in this KIP? The purpose of these KIPs is to give a full overview of the feature, how it will work, be implemented, the considerations involved, etc. There is only like one sentence on this which isn't enough for anyone to know what you are thinking. Moving off of configs to

Build failed in Jenkins: Kafka-trunk #377

See Changes: [joe.stein] KAFKA-1891 MirrorMaker hides consumer exception - making troubleshooting challenging patch by Gwen Shapira reviewed by Joe Stein -- [...truncated 1150 lines...] kafka.utils.S

Re: [DISCUSS] KIPs

Reviewed the latest patch in KAFKA-1809 :). Thanks, Jun On Thu, Jan 22, 2015 at 12:38 PM, Gwen Shapira wrote: > Thanks for validating our ideas. Updated the KIP with the workflow. > > Now if you can nudge Jun to review the latest patch... ;) > > > On Thu, Jan 22, 2015 at 11:44 AM, Jay Kreps w

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 7:10 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, lines 733-743 > > > > > > Is this the same as createTopic in line 172? > > Jay Kreps wrote: > Yeah, wei

[jira] [Updated] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1760: - Attachment: KAFKA-1760_2015-01-22_20:21:56.patch > Implement new consumer client > ---

[jira] [Commented] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288721#comment-14288721 ] Jay Kreps commented on KAFKA-1760: -- Updated reviewboard https://reviews.apache.org/r/2779

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 23, 2015, 4:22 a.m.) Review request for kafka. Bugs: KAFKA-1760

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 7:10 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 198 > > > > > > Just trying to understand the rationale why we want to special-care

Re: Review Request 30199: Patch for KAFKA-1890

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/ --- (Updated 一月 23, 2015, 3:57 a.m.) Review request for kafka. Bugs: KAFKA-1890

Re: Review Request 30199: Patch for KAFKA-1890

> On 一月 23, 2015, 3:14 a.m., Joe Stein wrote: > > Can you add test cases for the failure please? We should be able to apply > > the test cases, run test, see the failure, apply fix, verify the success. > > Thanks! It was actually a pretty silly mistake I made. Mirror maker will always have NP

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288694#comment-14288694 ] Joe Stein commented on KAFKA-1888: -- I agree this is something that we need. I don't know

[jira] [Updated] (KAFKA-1891) MirrorMaker hides consumer exception - making troubleshooting challenging

[ https://issues.apache.org/jira/browse/KAFKA-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1891: - Resolution: Fixed Status: Resolved (was: Patch Available) committed to trunk > MirrorMaker hides

[jira] [Updated] (KAFKA-1891) MirrorMaker hides consumer exception - making troubleshooting challenging

[ https://issues.apache.org/jira/browse/KAFKA-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1891: - Fix Version/s: 0.8.3 > MirrorMaker hides consumer exception - making troubleshooting challenging > ---

Re: Review Request 30199: Patch for KAFKA-1890

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69337 --- Can you add test cases for the failure please? We should be able to

[jira] [Updated] (KAFKA-1890) Fix bug preventing Mirror Maker from successful rebalance.

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Reviewer: Gwen Shapira > Fix bug preventing Mirror Maker from successful rebalance. >

[jira] [Updated] (KAFKA-1890) Fix bug preventing Mirror Maker from successful rebalance.

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Priority: Blocker (was: Major) > Fix bug preventing Mirror Maker from successful rebalance. > ---

[jira] [Updated] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Description: (was: Fix bug preventing Mirror Maker from successful rebalance.) > Follow-up patch for

[jira] [Updated] (KAFKA-1890) Fix bug preventing Mirror Maker from successful rebalance.

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Description: Follow-up patch for KAFKA-1650 > Fix bug preventing Mirror Maker from successful rebalance. >

[jira] [Updated] (KAFKA-1890) Fix bug preventing Mirror Maker from successful rebalance.

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Summary: Fix bug preventing Mirror Maker from successful rebalance. (was: Follow-up patch for KAFKA-1650)

[jira] [Updated] (KAFKA-1890) Fix bug preventing Mirror Maker from successful rebalance.

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1890: - Fix Version/s: 0.8.3 > Fix bug preventing Mirror Maker from successful rebalance. > --

Re: Latency Tracking Across All Kafka Component

HI Kafka Team, I completely understand the use of the Audit event and reference material posted here https://issues.apache.org/jira/browse/KAFKA-260 and slides . Since we are enterprise customer of the Kafka end-to-end pipeline, it would be great if Kafka have build-in support for distributive

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288639#comment-14288639 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2015-01-22_18:47:37.patch > Improve semantics of timestamp in OffsetCommitR

Re: Review Request 27391: Fix KAFKA-1634

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated Jan. 23, 2015, 2:47 a.m.) Review request for kafka. Bugs: KAFKA-1634

Re: Review Request 27391: Fix KAFKA-1634

> On Jan. 22, 2015, 1:56 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 145-166 > > > > > > I am not sure that we should change the timestamp for offsets produced > > in V0 and V1. Th

Re: Review Request 29831: Patch for KAFKA-1476

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/#review69332 --- Onur, do you have an updated version of the console output from this

Re: Review Request 28769: Patch for KAFKA-1809

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review69281 --- Thanks for the patch. Looks promising. Some comments. 1. I overlook

[jira] [Commented] (KAFKA-1703) The bat script failed to start on windows

[ https://issues.apache.org/jira/browse/KAFKA-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288535#comment-14288535 ] JK Dong commented on KAFKA-1703: modify set BASE_DIR=%CD%\.. to set BASE_DIR=%CD%\..\..

[jira] [Updated] (KAFKA-1703) The bat script failed to start on windows

[ https://issues.apache.org/jira/browse/KAFKA-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JK Dong updated KAFKA-1703: --- Attachment: kafka-run-class.bat > The bat script failed to start on windows >

[jira] [Updated] (KAFKA-1703) The bat script failed to start on windows

[ https://issues.apache.org/jira/browse/KAFKA-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JK Dong updated KAFKA-1703: --- Status: Patch Available (was: Open) > The bat script failed to start on windows > ---

[jira] [Commented] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288521#comment-14288521 ] Gwen Shapira commented on KAFKA-1890: - +1 - Solved my problem :) Thanks, [~becket_qin

Re: Review Request 30199: Patch for KAFKA-1890

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69302 --- Ship it! Ship It! - Gwen Shapira On Jan. 22, 2015, 11:25 p.m., J

[jira] [Commented] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288438#comment-14288438 ] Jiangjie Qin commented on KAFKA-1890: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1890: Attachment: KAFKA-1890.patch > Follow-up patch for KAFKA-1650 > -- > >

[jira] [Updated] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1890: Status: Patch Available (was: Open) > Follow-up patch for KAFKA-1650 >

Review Request 30199: Patch for KAFKA-1890

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/ --- Review request for kafka. Bugs: KAFKA-1890 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288404#comment-14288404 ] Jiangjie Qin commented on KAFKA-1890: - Yes, this is the one I'm fixing. > Follow-up p

[jira] [Commented] (KAFKA-1890) Follow-up patch for KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288395#comment-14288395 ] Gwen Shapira commented on KAFKA-1890: - [~becket_qin], I'm getting the following error

[jira] [Updated] (KAFKA-1891) MirrorMaker hides consumer exception - making troubleshooting challenging

[ https://issues.apache.org/jira/browse/KAFKA-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1891: Attachment: KAFKA-1891.patch Its a 3 character patch, so I'm not creating an RB :) > MirrorMaker hi

[jira] [Updated] (KAFKA-1891) MirrorMaker hides consumer exception - making troubleshooting challenging

[ https://issues.apache.org/jira/browse/KAFKA-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1891: Status: Patch Available (was: Open) > MirrorMaker hides consumer exception - making troubleshooting

Re: Review Request 30196: Patch for KAFKA-1886

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- (Updated Jan. 22, 2015, 10:35 p.m.) Review request for kafka and Joel Koshy.

[jira] [Updated] (KAFKA-1886) SimpleConsumer swallowing ClosedByInterruptException

[ https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-1886: - Attachment: KAFKA-1886.patch > SimpleConsumer swallowing ClosedByInterruptException >

Review Request 30196: Patch for KAFKA-1886

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- Review request for kafka. Bugs: KAFKA-1886 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1886) SimpleConsumer swallowing ClosedByInterruptException

[ https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288350#comment-14288350 ] Aditya A Auradkar commented on KAFKA-1886: -- Created reviewboard https://reviews.a

[jira] [Commented] (KAFKA-1818) Code cleanup in ReplicationUtils including unit test

[ https://issues.apache.org/jira/browse/KAFKA-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288328#comment-14288328 ] Eric Olander commented on KAFKA-1818: - In review: https://reviews.apache.org/r/29840/

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288327#comment-14288327 ] Navina Ramesh commented on KAFKA-1863: -- As a part of the documentation, can you also

[jira] [Created] (KAFKA-1891) MirrorMaker hides consumer exception - making troubleshooting challenging

Gwen Shapira created KAFKA-1891: --- Summary: MirrorMaker hides consumer exception - making troubleshooting challenging Key: KAFKA-1891 URL: https://issues.apache.org/jira/browse/KAFKA-1891 Project: Kafka

[jira] [Commented] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

[ https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288254#comment-14288254 ] Sriharsha Chintalapani commented on KAFKA-1867: --- [~junrao] when you get a ch

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288206#comment-14288206 ] Abhishek Nigam commented on KAFKA-1888: --- Gwen, If you are not actively working on it

[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288205#comment-14288205 ] Francois Saint-Jacques commented on KAFKA-1889: --- Also note that this patch k

[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288193#comment-14288193 ] Francois Saint-Jacques commented on KAFKA-1889: --- It's not about working well

[jira] [Created] (KAFKA-1890) Follow-up patch for KAFKA-1650

Jiangjie Qin created KAFKA-1890: --- Summary: Follow-up patch for KAFKA-1650 Key: KAFKA-1890 URL: https://issues.apache.org/jira/browse/KAFKA-1890 Project: Kafka Issue Type: Bug Report

Re: [DISCUSS] KIPs

Thanks for validating our ideas. Updated the KIP with the workflow. Now if you can nudge Jun to review the latest patch... ;) On Thu, Jan 22, 2015 at 11:44 AM, Jay Kreps wrote: > Oh yeah I think that is better, I hadn't thought of that approach! Any way > you could describe the usage in the KIP

[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288152#comment-14288152 ] Joe Stein commented on KAFKA-1889: -- Makes sense. How do we know this works well for rpm a

Re: Review Request 30126: Patch for KAFKA-1845

> On Jan. 21, 2015, 10:55 p.m., Eric Olander wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 475 > > > > > > Maybe some helper functions could help with this code: > > > > def stringProp(pr

[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288120#comment-14288120 ] Francois Saint-Jacques commented on KAFKA-1889: --- My goal is to fix the kafka

Re: Review Request 30126: Patch for KAFKA-1845

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30126/#review69224 --- Looks great. Just one minor comment. core/src/main/scala/kafka/ser

Re: New consumer plans

I have made a pass over the patch, the changes in NetworkClient / Selector / Sender look good to me. But there is one issue I found in the KafkaConsumer implementation, that when consumer subscribe (topic-partition), it will not send a join-group request to the coordinator. This seems to be differ

Re: [DISCUSS] KIPs

Oh yeah I think that is better, I hadn't thought of that approach! Any way you could describe the usage in the KIP, just for completeness? -Jay On Thu, Jan 22, 2015 at 10:23 AM, Gwen Shapira wrote: > I think what you described was the original design, so no wonder you > are confused :) > > Foll

[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288061#comment-14288061 ] Joe Stein commented on KAFKA-1889: -- Thanks for the patch [~fsaintjacques]. What is the mo

[jira] [Updated] (KAFKA-1889) Refactor shell wrapper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Saint-Jacques updated KAFKA-1889: -- Status: Open (was: Patch Available) > Refactor shell wrapper scripts >

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review68947 --- clients/src/main/java/org/apache/kafka/common/network/Selector.java

[jira] [Assigned] (KAFKA-1757) Can not delete Topic index on Windows

[ https://issues.apache.org/jira/browse/KAFKA-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1757: - Assignee: Sriharsha Chintalapani > Can not delete Topic index on Windows

Re: [KIP-DISCUSSION] KIP-7 Security - IP Filtering

Hey Jeff, thanks for the patch and writing this up. I think the approach to explicitly deny and then set what is allowed or explicitly allow then deny specifics makes sense. Supporting CIDR notation and ip4 and ip6 both good too. Waiting for KAFKA-1845 to get committed I think makes sense before

Re: [DISCUSS] KIP-5 - Broker Configuration Management

Thanks for clarifying the upgrade path. +1 for this proposal, it will greatly reduce errors resulting from configuration mismatches. On Thu, Jan 22, 2015 at 8:40 AM, Joe Stein wrote: > Deployment proposal: > >1. If global configuration isn't being used, do what you do today (there >shou

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287949#comment-14287949 ] Joel Koshy commented on KAFKA-1729: --- Should be able to update the doc patch today. > ad

Re: [DISCUSS] KIPs

I think what you described was the original design, so no wonder you are confused :) Following suggestions from Jun, I changed it a bit. The current model is: - Clients (producers and consumers) need to know about the broker ports in advance. They don't need to know about all brokers, but they ne

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java, > > line 21 > > > > > > nit. Can we remove the public from the interface methods?

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java, > > line 21 > > > > > > nit. Can we remove the public from the interface methods?

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 22, 2015, 6:06 p.m.) Review request for kafka. Bugs: KAFKA-1760

[jira] [Commented] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287869#comment-14287869 ] Jay Kreps commented on KAFKA-1760: -- Updated reviewboard https://reviews.apache.org/r/2779

[jira] [Updated] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1760: - Attachment: KAFKA-1760_2015-01-22_10:03:26.patch > Implement new consumer client > ---

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 22, 2015, 6:03 p.m.) Review request for kafka. Bugs: KAFKA-1760

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java, > > line 21 > > > > > > nit. Can we remove the public from the interface methods?

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review69204 --- clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 2:45 a.m., Onur Karaman wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 32 > > > > > > Other CURRENT_SCHEMA's throughout the rb were changed to be f

Re: [DISCUSS] KIPs

I think I am still confused. In addition to the UpdateMetadataRequest don't we have to change the MetadataResponse so that it's possible for clients to discover the new ports? Or is that a second phase? I was imagining it worked by basically allowing the brokers to advertise multiple ports, one per

Re: NIO and Threading implementation

Hey Chittaranjan, Yeah I think at a high level our goal is that classes are either threadsafe or not and if threadsafe their safety doesn't depend on the details of their current usage(s) since that often changes. In other words the synchronization should be encapsulated in the class. So that's th

[jira] [Commented] (KAFKA-1804) Kafka network thread lacks top exception handler

[ https://issues.apache.org/jira/browse/KAFKA-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287713#comment-14287713 ] Alexey Ozeritskiy commented on KAFKA-1804: -- The last time we saw the bug during r

Re: [DISCUSS] KIP-5 - Broker Configuration Management

Deployment proposal: 1. If global configuration isn't being used, do what you do today (there should be configuration brokers.admin.global.configuration=true [default=false]. This works for the upgrade. Once all brokers are upgraded proceed. 2. if the global config is used then only

[jira] [Updated] (KAFKA-1845) KafkaConfig should use ConfigDef

[ https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1845: - Fix Version/s: 0.8.3 > KafkaConfig should use ConfigDef > - > >

Re: [DISCUSS] KIP-5 - Broker Configuration Management

Hi Joe, How does initial deployments will look in this environment. I guess users will deploy the kafka cluster and it will be running with defaults and they can use a command line tool to update the configs?. I think you need to update the JIRA and mailing list thread links on the

[jira] [Commented] (KAFKA-1869) Openning some random ports while running kafka service

[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287341#comment-14287341 ] QianHu commented on KAFKA-1869: --- Can we set it in the configuration file of jdk? I hava trie

[jira] [Commented] (KAFKA-1869) Openning some random ports while running kafka service

[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287339#comment-14287339 ] QianHu commented on KAFKA-1869: --- Hello, this is my config: export KAFKA_HEAP_OPTS="-Xms4g -

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287215#comment-14287215 ] Onur Karaman commented on KAFKA-1476: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1476: Attachment: KAFKA-1476_2015-01-22_02:32:52.patch > Get a list of consumer groups > -

Re: Review Request 29831: Patch for KAFKA-1476

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/ --- (Updated Jan. 22, 2015, 10:32 a.m.) Review request for kafka. Bugs: KAFKA-147