Review Request 31007: Patch for KAFKA-1926

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31007/ --- Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch > Replace kafka.utils.Utils with o.a.k.common.utils.Utils > -

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320404#comment-14320404 ] Tong Li commented on KAFKA-1926: Created reviewboard https://reviews.apache.org/r/31007/di

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320416#comment-14320416 ] Tong Li commented on KAFKA-1926: [~jkreps] Removal of Time.scala cause a lot of code chang

Re: Review Request 29912: Patch for KAFKA-1852

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review72405 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 29912: Patch for KAFKA-1852

> On Feb. 13, 2015, 6:24 p.m., Eric Olander wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 303 > > > > > > This code could be done using map and getOrElse on the Option rather > > than using pattern

Re: Review Request 29912: Patch for KAFKA-1852

> On Feb. 13, 2015, 6:24 p.m., Eric Olander wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 303 > > > > > > This code could be done using map and getOrElse on the Option rather > > than using pattern

Re: Review Request 29912: Patch for KAFKA-1852

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review72413 --- minor comment, looks good otherwise core/src/main/scala/kafka/serv

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: KAFKA-1792_2015-02-13_21:07:06.patch > change behavior of --generate to produce assignme

Re: Review Request 28481: Patch for KAFKA-1792

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/ --- (Updated Feb. 13, 2015, 7:07 p.m.) Review request for kafka. Bugs: KAFKA-1792

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320584#comment-14320584 ] Dmitry Pekar commented on KAFKA-1792: - Updated reviewboard https://reviews.apache.org/

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320584#comment-14320584 ] Dmitry Pekar edited comment on KAFKA-1792 at 2/13/15 7:09 PM: --

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320673#comment-14320673 ] Guozhang Wang commented on KAFKA-1659: -- One big use-case for this function call would

[jira] [Commented] (KAFKA-1461) Replica fetcher thread does not implement any back-off behavior

[ https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320746#comment-14320746 ] Idcmp commented on KAFKA-1461: -- This issue can be tickled on a multi-broker configuration by

[jira] [Comment Edited] (KAFKA-1461) Replica fetcher thread does not implement any back-off behavior

[ https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320746#comment-14320746 ] Idcmp edited comment on KAFKA-1461 at 2/13/15 9:04 PM: --- This issue c

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1697: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Pushed to trunk

[jira] [Updated] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

[ https://issues.apache.org/jira/browse/KAFKA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1951: Assignee: Jiangjie Qin Status: Patch Available (was: Open) > Consumer offset checker should h

[jira] [Updated] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

[ https://issues.apache.org/jira/browse/KAFKA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1951: Attachment: KAFKA-1951.patch > Consumer offset checker should handle corner cases for dual commit or

Review Request 31021: Patch for KAFKA-1951

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31021/ --- Review request for kafka. Bugs: KAFKA-1951 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

[ https://issues.apache.org/jira/browse/KAFKA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320800#comment-14320800 ] Jiangjie Qin commented on KAFKA-1951: - Created reviewboard https://reviews.apache.org/

[jira] [Created] (KAFKA-1952) High CPU Usage in 0.8.2 release

Jay Kreps created KAFKA-1952: Summary: High CPU Usage in 0.8.2 release Key: KAFKA-1952 URL: https://issues.apache.org/jira/browse/KAFKA-1952 Project: Kafka Issue Type: Bug Affects Versions: 0

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320981#comment-14320981 ] Jay Kreps commented on KAFKA-1659: -- But there would be a race condition between the sende

[jira] [Created] (KAFKA-1953) Disambiguate metrics from different purgatories

Joel Koshy created KAFKA-1953: - Summary: Disambiguate metrics from different purgatories Key: KAFKA-1953 URL: https://issues.apache.org/jira/browse/KAFKA-1953 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320991#comment-14320991 ] Guozhang Wang commented on KAFKA-1659: -- Okay, I think we may need to treat the follow

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321015#comment-14321015 ] Jay Kreps commented on KAFKA-1659: -- Hmm, but how useful is being able to shutdown the pro

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321029#comment-14321029 ] Guozhang Wang commented on KAFKA-1659: -- Yes it works only with max-inflight-request =

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321071#comment-14321071 ] Jay Kreps commented on KAFKA-1659: -- I understood the original problem we were trying to s

Review Request 31040: Patch for kafka-1952

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/ --- Review request for kafka. Bugs: kafka-1952 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1952) High CPU Usage in 0.8.2 release

[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1952: --- Attachment: kafka-1952.patch > High CPU Usage in 0.8.2 release > --- > >

[jira] [Commented] (KAFKA-1952) High CPU Usage in 0.8.2 release

[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321131#comment-14321131 ] Jun Rao commented on KAFKA-1952: The issue is that after purgatory refactoring, we make a

[jira] [Updated] (KAFKA-1952) High CPU Usage in 0.8.2 release

[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1952: --- Status: Patch Available (was: Open) > High CPU Usage in 0.8.2 release > --- > >

[jira] [Commented] (KAFKA-1952) High CPU Usage in 0.8.2 release

[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321130#comment-14321130 ] Jun Rao commented on KAFKA-1952: Created reviewboard https://reviews.apache.org/r/31040/di

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321134#comment-14321134 ] Jay Kreps commented on KAFKA-1926: -- Yes but the whole point of these code cleanups is to

Re: Review Request 31040: Patch for kafka-1952

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/#review72479 --- Ship it! core/src/main/scala/kafka/server/RequestPurgatory.scala <

[jira] [Commented] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321158#comment-14321158 ] Guozhang Wang commented on KAFKA-1659: -- Jay, I think idempotent producer is helpful f

Build failed in Jenkins: KafkaPreCommit #5

See Changes: [jjkoshy] KAFKA-1697; Remove support for producer ack > 1 on the broker; reviewed by Joel Koshy -- [...truncated 1121 lines...] kafka.api.test.ProducerFailureHandlingTest > testNotEnoug

Build failed in Jenkins: Kafka-trunk #392

See Changes: [jjkoshy] KAFKA-1697; Remove support for producer ack > 1 on the broker; reviewed by Joel Koshy -- [...truncated 1373 lines...] try { ^