Review Request 31591: Patch for KAFKA-1992

2015-02-28 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/ --- Review request for kafka. Bugs: KAFKA-1992 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

2015-02-28 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342042#comment-14342042 ] Gwen Shapira commented on KAFKA-1992: - Created reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342011#comment-14342011 ] Gwen Shapira commented on KAFKA-1991: - Nice catch! Thanks for finding and fixing. +1

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-28 Thread Gwen Shapira
> On Feb. 27, 2015, 11:18 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 289 > > > > > > good point Yep, good catch. Created KAFKA-1992 to fix this. - Gwen

[jira] [Created] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

2015-02-28 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1992: --- Summary: Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks Key: KAFKA-1992 URL: https://issues.apache.org/jira/browse/KAFKA-1992 Pro

Re: Review Request 31566: Patch for KAFKA-1988

2015-02-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74688 --- Ship it! Ship It! - Guozhang Wang On Feb. 27, 2015, 11:16 p.m.,

[jira] [Resolved] (KAFKA-1987) Potential race condition in partition creation

2015-02-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1987. -- Resolution: Won't Fix Assignee: (was: Neha Narkhede) > Potential race condition in par

[jira] [Updated] (KAFKA-1987) Potential race condition in partition creation

2015-02-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1987: - Affects Version/s: (was: 0.8.1.1) > Potential race condition in partition creation > -

Build failed in Jenkins: KafkaPreCommit #27

2015-02-28 Thread Apache Jenkins Server
See Changes: [jay.kreps] KAFKA-1865 Add a flush() method to the producer. -- [...truncated 1937 lines...] kafka.admin.AddPartitionsTest > testIncrementPartitions PASSED kafka.admin.AddPartitionsTes

Jenkins build is back to normal : Kafka-trunk #414

2015-02-28 Thread Apache Jenkins Server
See

[jira] [Updated] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1865: - Resolution: Fixed Status: Resolved (was: Patch Available) > Add a flush() call to the new produce

[jira] [Updated] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1991: --- Attachment: KAFKA-1991.patch > Clean ControllerStats initialization >

[jira] [Updated] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1991: --- Status: Patch Available (was: Open) > Clean ControllerStats initialization >

[jira] [Created] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-1991: -- Summary: Clean ControllerStats initialization Key: KAFKA-1991 URL: https://issues.apache.org/jira/browse/KAFKA-1991 Project: Kafka Issue Type: Improvement

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-28 Thread Jay Kreps
> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? > > Jay Kreps wrote: >

[jira] [Created] (KAFKA-1990) Add unlimited time-based log retention

2015-02-28 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-1990: Summary: Add unlimited time-based log retention Key: KAFKA-1990 URL: https://issues.apache.org/jira/browse/KAFKA-1990 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-1877) Expose version via JMX for 'new' producer

2015-02-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341744#comment-14341744 ] Jay Kreps commented on KAFKA-1877: -- The metrics are just for metrics which are by nature

[jira] [Updated] (KAFKA-1313) Support adding replicas to existing topic partitions

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1313: - Assignee: Geoffrey Anderson > Support adding replicas to existing topic partitions > -

[jira] [Updated] (KAFKA-527) Compression support does numerous byte copies

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-527: Priority: Critical (was: Major) > Compression support does numerous byte copies > --

[jira] [Updated] (KAFKA-1911) Log deletion on stopping replicas should be async

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1911: - Labels: newbie++ (was: ) > Log deletion on stopping replicas should be async > --

[jira] [Updated] (KAFKA-1911) Log deletion on stopping replicas should be async

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1911: - Assignee: Geoffrey Anderson (was: Jay Kreps) > Log deletion on stopping replicas should be async

[jira] [Updated] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-902: Component/s: (was: replication) clients > Randomize backoff on the clients for m

[jira] [Updated] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-902: Assignee: Geoffrey Anderson (was: Neha Narkhede) > Randomize backoff on the clients for metadata req

[jira] [Updated] (KAFKA-952) a broker should unregister certain ZK watchers afte it is no longer the controller

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-952: Assignee: Geoffrey Anderson (was: Neha Narkhede) > a broker should unregister certain ZK watchers af

[jira] [Updated] (KAFKA-1677) Governor on concurrent replica reassignments

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1677: - Labels: newbie++ (was: ) > Governor on concurrent replica reassignments > ---

[jira] [Updated] (KAFKA-1677) Governor on concurrent replica reassignments

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1677: - Assignee: Geoffrey Anderson (was: Neha Narkhede) > Governor on concurrent replica reassignments >

[jira] [Updated] (KAFKA-1676) Ability to cancel replica reassignment in progress

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1676: - Labels: newbie (was: ) > Ability to cancel replica reassignment in progress > ---

[jira] [Updated] (KAFKA-952) a broker should unregister certain ZK watchers afte it is no longer the controller

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-952: Labels: newbie (was: ) > a broker should unregister certain ZK watchers afte it is no longer the >

Re: Review Request 25995: Patch for KAFKA-1650

2015-02-28 Thread Jiangjie Qin
> On Feb. 28, 2015, 4:43 p.m., Jun Rao wrote: > > Sorry for the late review. A few more comments below. Thanks a lot for the review, Jun. We actually have a new design for mirror maker based on the flush() call of producer (KAFKA-1865). The design is updated in KIP-3 and it is in voting proces

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341660#comment-14341660 ] Jun Rao commented on KAFKA-1664: Thanks for the patch. The patch makes every create operat

Build failed in Jenkins: KafkaPreCommit #26

2015-02-28 Thread Apache Jenkins Server
See Changes: [neha.narkhede] KAFKA-1824 ConsoleProducer - properties key.separator and parse.key no longer work; reviewed by Neha Narkhede -- [...truncated 1347 lines...] kafka.admin.AddPartitionsT

Re: Review Request 25995: Patch for KAFKA-1650

2015-02-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review74677 --- Sorry for the late review. A few more comments below. core/src/mai

Build failed in Jenkins: Kafka-trunk #413

2015-02-28 Thread Apache Jenkins Server
See Changes: [neha.narkhede] KAFKA-1824 ConsoleProducer - properties key.separator and parse.key no longer work; reviewed by Neha Narkhede -- [...truncated 556 lines...] kafka.api.test.ProducerFailur

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1824: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patches. Pushed

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2015-02-28 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1824: - Component/s: tools > in ConsoleProducer - properties key.separator and parse.key no longer work >