[jira] [Comment Edited] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383418#comment-14383418 ] Rajiv Kurian edited comment on KAFKA-2045 at 3/27/15 6:54 AM: --

[jira] [Comment Edited] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383418#comment-14383418 ] Rajiv Kurian edited comment on KAFKA-2045 at 3/27/15 6:53 AM: --

[jira] [Comment Edited] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383418#comment-14383418 ] Rajiv Kurian edited comment on KAFKA-2045 at 3/27/15 6:53 AM: --

[jira] [Commented] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383418#comment-14383418 ] Rajiv Kurian commented on KAFKA-2045: - Copying from the email list and expanding here.

[jira] [Comment Edited] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383418#comment-14383418 ] Rajiv Kurian edited comment on KAFKA-2045 at 3/27/15 6:51 AM: --

[jira] [Commented] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383344#comment-14383344 ] Jay Kreps commented on KAFKA-2045: -- Hey [~rzidane], one statically allocated ByteBuffer p

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review78018 --- Ship it! Thanks for the patch. +1. Just a couple of minor comments

Re: [DISCUSSION] Keep docs updated per jira

The reason the docs are in svn is that when we were setting up the site apache required that to publish doc changes. Two possible fixes: 1. Follow up with infra to see if they have git integration working yet 2. Move to a model where doc "source" is kept in the main git and we use jenkyl or somethi

Re: [DISCUSSION] Keep docs updated per jira

On 3/26/15, 7:00 PM, "Neha Narkhede" wrote: >> >> Much much easier to do this if the docs are in git and can be reviewed >>and >> committed / reverted with the code (transactions makes synchronization >> easier...). +1 on this, too! > > >Huge +1. > >On Thu, Mar 26, 2015 at 6:54 PM, Joel Koshy

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383277#comment-14383277 ] Guozhang Wang commented on KAFKA-1634: -- Just updated the protocol wiki with the new v

Re: [DISCUSSION] Keep docs updated per jira

> > Much much easier to do this if the docs are in git and can be reviewed and > committed / reverted with the code (transactions makes synchronization > easier...). Huge +1. On Thu, Mar 26, 2015 at 6:54 PM, Joel Koshy wrote: > +1 > > It is indeed too easy to forget and realize only much later

Re: [DISCUSSION] Keep docs updated per jira

+1 It is indeed too easy to forget and realize only much later that a jira needed a doc update. So getting into the habit of asking "did you update the docs" as part of review will definitely help. On Thu, Mar 26, 2015 at 06:36:43PM -0700, Gwen Shapira wrote: > I strongly support the goal of keep

Re: [DISCUSSION] Keep docs updated per jira

+1. I will update the protocol per KAFKA-1634. On Thu, Mar 26, 2015 at 6:27 PM, Jun Rao wrote: > Hi, Everyone, > > Quite a few jiras these days require documentation changes (e.g., wire > protocol, ZK layout, configs, jmx, etc). Historically, we have been > updating the documentation just before

Re: [DISCUSSION] Keep docs updated per jira

I strongly support the goal of keeping docs and code in sync. Much much easier to do this if the docs are in git and can be reviewed and committed / reverted with the code (transactions makes synchronization easier...). This will also allow us to: 1. Include the docs in the bits we release 2. On

Re: [DISCUSSION] Keep docs updated per jira

Could we move to git from svn so we can have the docs in the patch with the code too, easier to review and commit and work on for contribs also? To start we could do something easy like create a new directory /site cp -r from svn and then when we release cp -r /site/* svn/site and commit for the re

[DISCUSSION] Keep docs updated per jira

Hi, Everyone, Quite a few jiras these days require documentation changes (e.g., wire protocol, ZK layout, configs, jmx, etc). Historically, we have been updating the documentation just before we do a release. The issue is that some of the changes will be missed since they were done a while back. A

[jira] [Commented] (KAFKA-2045) Memory Management on the consumer

[ https://issues.apache.org/jira/browse/KAFKA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383147#comment-14383147 ] Rajiv Kurian commented on KAFKA-2045: - Bounding the ByteBuffers and statically allocat

Build failed in Jenkins: Kafka-trunk #435

See Changes: [wangguoz] KAFKA-1634; Bump up Offset Commit Request to v2 to add global retention and remove per-partition commit timestamp; reviewed by Joel Koshy and Jun Rao -- [...truncated 3352 li

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383117#comment-14383117 ] Jun Rao commented on KAFKA-1634: Also, could you also update the protocol wiki (https://c

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383111#comment-14383111 ] Jun Rao commented on KAFKA-1595: [~ijuma], we probably need to do a poll on the dev/user m

Build failed in Jenkins: KafkaPreCommit #47

See Changes: [wangguoz] KAFKA-1634; Bump up Offset Commit Request to v2 to add global retention and remove per-partition commit timestamp; reviewed by Joel Koshy and Jun Rao -- [...truncated 2492

[jira] [Updated] (KAFKA-1546) Automate replica lag tuning

[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-1546: - Attachment: KAFKA-1546_2015-03-26_17:44:08.patch > Automate replica lag tuning > -

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383086#comment-14383086 ] Aditya A Auradkar commented on KAFKA-1546: -- Updated reviewboard https://reviews.a

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 27, 2015, 12:44 a.m.) Review request for kafka. Bugs: KAFKA-15

Re: Review Request 31967: Patch for KAFKA-1546

> On March 25, 2015, 9:25 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Replica.scala, lines 60-72 > > > > > > Instead of pass these fiels of logReadResult all the way up to the > > replica, I think

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383030#comment-14383030 ] Joel Koshy commented on KAFKA-1634: --- [~guozhang] we actually need to merge KAFKA-1841 no

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Resolution: Fixed Status: Resolved (was: Patch Available) > Improve semantics of timestam

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383021#comment-14383021 ] Guozhang Wang commented on KAFKA-1634: -- Thanks for the reviews, committed to trunk.

Re: Review Request 27391: Rebase patch and incorporate Joel's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/#review77970 --- Ship it! Thank you for the updated patch. Just one minor comment be

Build failed in Jenkins: KafkaPreCommit #46

See Changes: [wangguoz] KAFKA-527; Use in-place decompression enabled inner iterator to replace old decompress function; reviewed by Joel Koshy and Jun Rao -- [...truncated 591 lines...] kafka.api

Re: Review Request 31967: Patch for KAFKA-1546

> On March 26, 2015, 12:07 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Replica.scala, lines 52-72 > > > > > > Would it be simpler to instead keeping track of a lastCaughtUpTime and > > updating it every

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382919#comment-14382919 ] Ismael Juma commented on KAFKA-1351: Fabian, the `trace` call uses a by-name parameter

Build failed in Jenkins: Kafka-trunk #434

See Changes: [wangguoz] KAFKA-527; Use in-place decompression enabled inner iterator to replace old decompress function; reviewed by Joel Koshy and Jun Rao -- [...truncated 1862 lines...] kafka.messa

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382880#comment-14382880 ] Jay Kreps commented on KAFKA-527: - Do we have any kind of before/after performance assessme

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382872#comment-14382872 ] Guozhang Wang commented on KAFKA-527: - Both patches have been checked in, closing this

[jira] [Updated] (KAFKA-527) Compression support does numerous byte copies

[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-527: Resolution: Fixed Status: Resolved (was: Patch Available) > Compression support does numerou

Re: [VOTE] KIP-15 add a close with timeout to new producer

Yes it is killing the thread (and effectively the producer as well) but I think that is appropriate since calling close with a timeout from callback is fundamentally a programming error - specifically an illegal argument (in the context of the callback). There are three options as I see it (in dec

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382842#comment-14382842 ] Ismael Juma commented on KAFKA-1595: I am interested in providing a patch for this iss

[jira] [Commented] (KAFKA-2017) Persist Coordinator State for Coordinator Failover

[ https://issues.apache.org/jira/browse/KAFKA-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382835#comment-14382835 ] Guozhang Wang commented on KAFKA-2017: -- Talked to Onur offline about possible approac

Thread Safety in KafkaServer.scala

KafkaServer.scala is using 3 AtomicBooleans (startupComplete, isShuttingDown, isStartingUp) as locks around the broker lifecycle. This strategy doesn’t appear to be thread safe, which I assume is the goal. Consider two threads, A and B, calling startup() and execution occurring as: Thread A pro

Re: Review Request 31816: Fix decompression regarding KAFKA-572

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31816/#review77955 --- Ship it! Thanks for the patch. Just a couple of minor comments belo

Re: Metrics package discussion

Yeah that is a good summary. The reason we don't use histograms heavily in the server is because of the memory issues. We originally did use histograms for everything, then we ran into all these issues, and ripped them out. Whether they are really useful or not, I don't know. Averages can be prett

Re: [VOTE] KIP-15 add a close with timeout to new producer

Hmm, but won't the impact of throwing the exception just be killing the sender thread? i.e. the user won't see it unless they check the logs, which is the same as logging the error. Is there a problem with just logging an error and then blocking for the amount of time requested? -Jay On Thu, Mar

Re: [VOTE] KIP-15 add a close with timeout to new producer

Talked to Jiangjie offline - actually looking at the code, we could just extend java.lang.Error. Alternately we could throw an IllegalArgumentException and though we catch Exception, we could catch that explicitly and rethrow to cause the sender to just exit. On Thu, Mar 26, 2015 at 01:29:41PM -07

RE: Metrics package discussion

>From what I can tell, Histograms don't seem to be used extensively in the >Kafka server (only in RequestChannel.scala) and I'm not sure we need them for >per-client metrics. Topic metrics use meters currently. Migrating graphing, >alerting will be quite a significant effort for all users of Ka

Re: [VOTE] KIP-15 add a close with timeout to new producer

Hey guys, I think there are really two choices: 1. Blocking for the time the user requested 2. Blocking indefinitely irrespective of what the user requested When we were discussing I thought we were talking about (1) but I think really you were proposing (2). (1) seems defensible. After all you

[jira] [Updated] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2039: --- Attachment: kafka-2039-v2.patch Updated patch with change to bin/windows/kafka-run-class.bat included

[jira] [Created] (KAFKA-2060) Async onCompletion callback may not be called

Bill Sobel created KAFKA-2060: - Summary: Async onCompletion callback may not be called Key: KAFKA-2060 URL: https://issues.apache.org/jira/browse/KAFKA-2060 Project: Kafka Issue Type: Bug

Re: Review Request 27391: Rebase patch and incorporate Joel's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated March 26, 2015, 7:28 p.m.) Review request for kafka. Bugs: KAFKA-163

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382490#comment-14382490 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2015-03-26_12:27:18.patch > Improve semantics of timestamp in OffsetCommitR

Re: Review Request 27391: Rebase patch and incorporate Joel's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated March 26, 2015, 7:27 p.m.) Review request for kafka. Bugs: KAFKA-163

Re: Review Request 27391: Rebase patch and incorporate Joel's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated March 26, 2015, 7:17 p.m.) Review request for kafka. Bugs: KAFKA-163

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2015-03-26_12:16:09.patch > Improve semantics of timestamp in OffsetCommitR

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382478#comment-14382478 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 27391: Rebase patch and incorporate Joel's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated March 26, 2015, 7:16 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382431#comment-14382431 ] Jay Kreps commented on KAFKA-1501: -- Fantastic! > transient unit tests failures due to po

Re: [VOTE] KIP-15 add a close with timeout to new producer

I was previously preferring logging + exist, but Jiangjie had a point that by doing this we are effectively silently changing the close(>0) call to close(0) call although we log an error to it. The problem is that users may just think the close(>0) call exit normally and do not check the logs. Guo

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382275#comment-14382275 ] Onur Karaman commented on KAFKA-2046: - Bumping controller.message.queue.size didn't se

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1501: - Assignee: Ewen Cheslack-Postava (was: Guozhang Wang) > transient unit tests failures due to port

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382274#comment-14382274 ] Guozhang Wang commented on KAFKA-1501: -- Ran 100 times with port issue not showing at

[jira] [Updated] (KAFKA-1573) Transient test failures on LogTest.testCorruptLog

[ https://issues.apache.org/jira/browse/KAFKA-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1573: - Issue Type: Sub-task (was: Bug) Parent: KAFKA-2054 > Transient test failures on LogTest.t

[jira] [Updated] (KAFKA-435) Keep track of the transient test failure for Kafka-343 on Apache Jenkins

[ https://issues.apache.org/jira/browse/KAFKA-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-435: Issue Type: Sub-task (was: Bug) Parent: KAFKA-2054 > Keep track of the transient test failur

[jira] [Updated] (KAFKA-1534) transient unit test failure in testBasicPreferredReplicaElection

[ https://issues.apache.org/jira/browse/KAFKA-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1534: - Issue Type: Sub-task (was: Bug) Parent: KAFKA-2054 > transient unit test failure in testB

[jira] [Resolved] (KAFKA-1759) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1759. -- Resolution: Duplicate > transient unit test failure in PartitionAssignorTest > -

[jira] [Created] (KAFKA-2059) ZookeeperConsumerConnectorTest.testBasic trasient failure

Guozhang Wang created KAFKA-2059: Summary: ZookeeperConsumerConnectorTest.testBasic trasient failure Key: KAFKA-2059 URL: https://issues.apache.org/jira/browse/KAFKA-2059 Project: Kafka Issue

[jira] [Updated] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2055: - Description: {code} kafka.api.ConsumerBounceTest > testSeekAndCommitWithBrokerFailures FAILED

[jira] [Created] (KAFKA-2058) ProducerTest.testSendWithDeadBroker transient failure

Guozhang Wang created KAFKA-2058: Summary: ProducerTest.testSendWithDeadBroker transient failure Key: KAFKA-2058 URL: https://issues.apache.org/jira/browse/KAFKA-2058 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-2057) DelayedOperationTest.testRequestExpiry transient failure

Guozhang Wang created KAFKA-2057: Summary: DelayedOperationTest.testRequestExpiry transient failure Key: KAFKA-2057 URL: https://issues.apache.org/jira/browse/KAFKA-2057 Project: Kafka Issue

[jira] [Created] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

Guozhang Wang created KAFKA-2056: Summary: PartitionAssignorTest.testRangePartitionAssignor transient failure Key: KAFKA-2056 URL: https://issues.apache.org/jira/browse/KAFKA-2056 Project: Kafka

[jira] [Created] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

Guozhang Wang created KAFKA-2055: Summary: ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure Key: KAFKA-2055 URL: https://issues.apache.org/jira/browse/KAFKA-2055 Project: Kafka

[jira] [Created] (KAFKA-2054) Fix Kafka transient unit test failures

Guozhang Wang created KAFKA-2054: Summary: Fix Kafka transient unit test failures Key: KAFKA-2054 URL: https://issues.apache.org/jira/browse/KAFKA-2054 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382143#comment-14382143 ] Ismael Juma commented on KAFKA-2039: Yes, the tests passed successfully with 2.10 and

Re: [DISCUSS] KIP-17 - Add HighwaterMarkOffset to OffsetFetchResponse

I agree with Jun here, that it would make it easier to do lag checking. However, for individual checks it's really not that much trouble to do the second request. If you're doing a lot of lag checking (like every consumer and every topic) where the scale would start to make a difference, I would ar

[jira] [Commented] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382124#comment-14382124 ] Jun Rao commented on KAFKA-2039: Thanks for the patch. We will also need to change the sca

Re: Review Request 32459: Patch for KAFKA-2044

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/#review77907 --- Thanks for the new patch. Looks good overall. Just a couple of more

Re: Contributing a KIP

Hi, Tom, What's you apache wiki id? I can grant you write access. Thanks, Jun On Wed, Mar 25, 2015 at 9:01 PM, Tom Lee wrote: > Hi all, > > I'd like to put forth a KIP but don't seem to have write access to cwiki. > Do I need to get a special permission bit set, or should I simply open up > t

Re: [DISCUSS] KIP-17 - Add HighwaterMarkOffset to OffsetFetchResponse

Grant, In addition to FetchRequest, currently we have another way to get the high watermark through OffsetRequest ( https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetRequest). OffsetRequest is a read-only request and is much lighter than

Re: [VOTE] KIP-15 add a close with timeout to new producer

Hi Neha, I totally agree that from program behavior point of view, blocking is not a good idea. I think the ultimate question here is whether we define calling close()/close(timeout) from callback as a legal usage or not. If it is a legal usage, logging a warning and exit makes perfect sense, w

[jira] [Updated] (KAFKA-2053) Make initZk a protected function

[ https://issues.apache.org/jira/browse/KAFKA-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Kampka updated KAFKA-2053: Attachment: make-initzk-protected > Make initZk a protected function > -

[jira] [Created] (KAFKA-2053) Make initZk a protected function

Christian Kampka created KAFKA-2053: --- Summary: Make initZk a protected function Key: KAFKA-2053 URL: https://issues.apache.org/jira/browse/KAFKA-2053 Project: Kafka Issue Type: Improvement

[jira] [Issue Comment Deleted] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Bugaychenko updated KAFKA-2029: -- Comment: was deleted (was: Created reviewboard against branch 0.8.1) > Improving contr

[jira] [Updated] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Bugaychenko updated KAFKA-2029: -- Attachment: (was: KAFKA-2029.patch) > Improving controlled shutdown for rolling upda

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381538#comment-14381538 ] Dmitry Bugaychenko commented on KAFKA-2029: --- Created reviewboard against branch

[jira] [Updated] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Bugaychenko updated KAFKA-2029: -- Attachment: KAFKA-2029.patch > Improving controlled shutdown for rolling updates > -

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381531#comment-14381531 ] Dmitry Bugaychenko commented on KAFKA-2029: --- Created reviewboard against branch

[jira] [Updated] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Bugaychenko updated KAFKA-2029: -- Attachment: KAFKA-2029.patch > Improving controlled shutdown for rolling updates > -

[jira] [Commented] (KAFKA-2052) zookeeper.connect does not work when specifying multiple zk nodes with chroot

[ https://issues.apache.org/jira/browse/KAFKA-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381516#comment-14381516 ] Sriharsha Chintalapani commented on KAFKA-2052: --- [~uohzxela] Syntax is to ad

[jira] [Resolved] (KAFKA-2052) zookeeper.connect does not work when specifying multiple zk nodes with chroot

[ https://issues.apache.org/jira/browse/KAFKA-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani resolved KAFKA-2052. --- Resolution: Invalid > zookeeper.connect does not work when specifying multiple

[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381494#comment-14381494 ] Flutra Osmani commented on KAFKA-1416: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Attachment: KAFKA-1416_2015-03-26_00:20:36.patch > Unify sendMessages/getMessages in unit tests >

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/ --- (Updated March 26, 2015, 7:21 a.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 31606: Patch for KAFKA-1416

> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala, > > lines 85-106 > > > > > > Can we use TestUtils.sendMessages to replace t