[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-11 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-04-11_22:47:27.patch > Add failure detection capability to the coordinat

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-11 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491338#comment-14491338 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 33088: add heartbeat to coordinator

2015-04-11 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 12, 2015, 5:47 a.m.) Review request for kafka. Bugs: KAFKA-133

Re: [DISCUSS] KIP-18 - JBOD Support

2015-04-11 Thread Todd Palino
I'm with you on that, Jay, although I don't consider your case common. More common is that there are things on all the disks at their normal retention, and you add something new. That said, it doesn't really matter because what you're illustrating is a valid concern. Automatic balancing would proba

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-11 Thread Jiangjie Qin
> On April 11, 2015, 8:02 p.m., Jay Kreps wrote: > > Thanks for the review, Jay. Please see the reply below. > On April 11, 2015, 8:02 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 530 > >

[jira] [Assigned] (KAFKA-2114) Unable to change min.insync.replicas default

2015-04-11 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira reassigned KAFKA-2114: --- Assignee: Gwen Shapira > Unable to change min.insync.replicas default > -

[jira] [Created] (KAFKA-2114) Unable to change min.insync.replicas default

2015-04-11 Thread Bryan Baugher (JIRA)
Bryan Baugher created KAFKA-2114: Summary: Unable to change min.insync.replicas default Key: KAFKA-2114 URL: https://issues.apache.org/jira/browse/KAFKA-2114 Project: Kafka Issue Type: Bug

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-11 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/#review79813 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491172#comment-14491172 ] Jay Kreps commented on KAFKA-1646: -- This is pretty critical code and there have been a fe

Re: Review Request 29091: Improve 1646 fix by reduce check if Os.IsWindows

2015-04-11 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/#review79812 --- I think this looks more reasonable. I am pretty confused by the code

Re: [DISCUSS] KIP-18 - JBOD Support

2015-04-11 Thread Jay Kreps
Hey Todd, The problem you pointed out is real. Unfortunately, placing by available size at creation time actually makes things worse. The original plan was to place new partitions on the disk with the most space, but consider a common case: disk 1: 500M disk 2: 0M Now say you are creating 10 par

Re: [DISCUSS] KIP-18 - JBOD Support

2015-04-11 Thread Jay Kreps
I think this KIP is not really about JBOD support it is just about remaining available in the presence of individual disk failures. I agree this is nice to have but in the large scope of things is this really a big deal? Kafka deployments are usually a lot smaller than Hadoop deployments so even i