[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502327#comment-14502327 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- Odd, I don't see those, but I

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502317#comment-14502317 ] Jun Rao commented on KAFKA-2118: [~rsivaram], your latest patch looks good to me. [~jkrep

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502306#comment-14502306 ] Steven Zhen Wu commented on KAFKA-2121: --- BTW, when I ran "./gradlew clients:test" on

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502297#comment-14502297 ] Steven Zhen Wu commented on KAFKA-2121: --- [~ewencp] I have applied same fix to KafkaC

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502295#comment-14502295 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-19_20:30:18.patch > prevent potential resource leak in KafkaProdu

Re: Review Request 33242: Patch for KAFKA-2121

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 20, 2015, 3:30 a.m.) Review request for kafka. Bugs: KAFKA-212

Re: Review Request 33242: Patch for KAFKA-2121

> On April 19, 2015, 11:11 p.m., Ewen Cheslack-Postava wrote: > > LGTM! If this gets merged as is, we should file a follow-up issue for the > > new consumer, which has the same issue. OK. I applied the same fix for new consumer. also updated jira title to reflect the expanded scope. - Steven

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-19_20:08:45.patch > prevent potential resource leak in KafkaProdu

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502275#comment-14502275 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard https://reviews.apache.

Re: Review Request 33242: Patch for KAFKA-2121

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 20, 2015, 3:08 a.m.) Review request for kafka. Bugs: KAFKA-212

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Summary: prevent potential resource leak in KafkaProducer and KafkaConsumer (was: error handlin

Re: Review Request 33242: Patch for KAFKA-2121

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/#review80642 --- Ship it! LGTM! If this gets merged as is, we should file a follow-u

Re: Review Request 33088: add heartbeat to coordinator

> On April 18, 2015, 11:14 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/coordinator/DelayedHeartbeat.scala, line 37 > > > > > > Is it possible to get rid of this kind of ad hoc synchronization? You > > seem to

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502104#comment-14502104 ] Rajini Sivaram commented on KAFKA-2118: --- [~junrao] Thank you for the review. Code co

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502083#comment-14502083 ] Sriharsha Chintalapani commented on KAFKA-2122: --- Thanks for the quick review

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502082#comment-14502082 ] Sriharsha Chintalapani commented on KAFKA-2122: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2122: -- Attachment: KAFKA-2122_2015-04-19_12:44:41.patch > Remove controller.message.que

Re: Review Request 33342: Patch for KAFKA-2122

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/ --- (Updated April 19, 2015, 7:44 p.m.) Review request for kafka. Bugs: KAFKA-212

Build failed in Jenkins: Kafka-trunk #469

See Changes: [junrao] kafka-1990; Add unlimited time-based log retention; patched by Jeff Holoman; reviewed by Jun Rao -- [...truncated 1943 lines...] kafka.log.CleanerTest > testCleaningWithUnkeyedM

Re: Review Request 33342: Patch for KAFKA-2122

> On April 19, 2015, 7:10 p.m., Onur Karaman wrote: > > Just a heads up: there are a few system tests that try to set this property. Thanks for the note will check the system tests and also address Jun's comment. - Sriharsha --- This is

Re: Review Request 33168: Fix recovery of swap files after broker crash

> On April 17, 2015, 10:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 775-777 > > > > > > It's not clear what "this operation" is. It seems to refer to > > replaceSegments(), bit replaceSe

Re: Review Request 33342: Patch for KAFKA-2122

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/#review80638 --- Ship it! Just a heads up: there are a few system tests that try to

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502065#comment-14502065 ] Onur Karaman commented on KAFKA-2046: - I forgot to give an update on Clark's case. I l

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502061#comment-14502061 ] Rajini Sivaram commented on KAFKA-2118: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2118: -- Status: Patch Available (was: In Progress) > Cleaner cannot clean after shutdown during replace

[jira] [Updated] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2118: -- Attachment: KAFKA-2118_2015-04-19_19:02:38.patch > Cleaner cannot clean after shutdown during re

Re: Review Request 33168: Fix recovery of swap files after broker crash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/ --- (Updated April 19, 2015, 7:03 p.m.) Review request for kafka. Bugs: KAFKA-211

[jira] [Updated] (KAFKA-1990) Add unlimited time-based log retention

[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1990: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Re: Review Request 33342: Patch for KAFKA-2122

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/#review80633 --- Thanks for the patch. Just a minor comment below. core/src/main/sc

[jira] [Resolved] (KAFKA-2133) Deadlock in DeleteTopicsThread

[ https://issues.apache.org/jira/browse/KAFKA-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Ozeritskiy resolved KAFKA-2133. -- Resolution: Fixed > Deadlock in DeleteTopicsThread > -- > >

[jira] [Updated] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2122: -- Status: Patch Available (was: Open) > Remove controller.message.queue.size Conf

[jira] [Updated] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2122: -- Attachment: KAFKA-2122.patch > Remove controller.message.queue.size Config > ---

Review Request 33342: Patch for KAFKA-2122

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33342/ --- Review request for kafka. Bugs: KAFKA-2122 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502039#comment-14502039 ] Sriharsha Chintalapani commented on KAFKA-2122: --- Created reviewboard https:/

[jira] [Commented] (KAFKA-2133) Deadlock in DeleteTopicsThread

[ https://issues.apache.org/jira/browse/KAFKA-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502028#comment-14502028 ] Alexey Ozeritskiy commented on KAFKA-2133: -- We've set it to 128. I think that def

[jira] [Commented] (KAFKA-1990) Add unlimited time-based log retention

[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502017#comment-14502017 ] Jeff Holoman commented on KAFKA-1990: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1990) Add unlimited time-based log retention

[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1990: Status: Patch Available (was: In Progress) > Add unlimited time-based log retention > -

[jira] [Commented] (KAFKA-2133) Deadlock in DeleteTopicsThread

[ https://issues.apache.org/jira/browse/KAFKA-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502018#comment-14502018 ] Sriharsha Chintalapani commented on KAFKA-2133: --- [~aozeritsky] This looks li

[jira] [Assigned] (KAFKA-2122) Remove controller.message.queue.size Config

[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-2122: - Assignee: Sriharsha Chintalapani > Remove controller.message.queue.size C

[jira] [Updated] (KAFKA-1990) Add unlimited time-based log retention

[ https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1990: Attachment: KAFKA-1990_2015-04-19_13:41:23.patch > Add unlimited time-based log retention >

Re: Review Request 31590: Patch for KAFKA-1990

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31590/ --- (Updated April 19, 2015, 5:41 p.m.) Review request for kafka and Gwen Shapira.

[jira] [Created] (KAFKA-2133) Deadlock in DeleteTopicsThread

Alexey Ozeritskiy created KAFKA-2133: Summary: Deadlock in DeleteTopicsThread Key: KAFKA-2133 URL: https://issues.apache.org/jira/browse/KAFKA-2133 Project: Kafka Issue Type: Bug Affe

[jira] [Resolved] (KAFKA-1974) NPE in SelectorTest on trunk

[ https://issues.apache.org/jira/browse/KAFKA-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1974. Resolution: Cannot Reproduce Closing this for now. We can reopen it if it shows up again. > NPE in Selector

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2082: --- Status: In Progress (was: Patch Available) > Kafka Replication ends up in a bad state > -

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501998#comment-14501998 ] Jun Rao commented on KAFKA-2082: In the case when a broker is isolated from ZK, the easies

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1929: --- Status: In Progress (was: Patch Available) > Convert core kafka module to use the errors in org.apache.kafka.

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501989#comment-14501989 ] Jun Rao commented on KAFKA-1929: [~jholoman], thanks for the patch. A couple of comments.

Jenkins build is back to normal : Kafka-trunk #468

See

[jira] [Updated] (KAFKA-2131) Update new producer javadocs with correct documentation links

[ https://issues.apache.org/jira/browse/KAFKA-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2131: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1982: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

Jun, 1. Yes, seems we can add lag info to the TMR. But before that I wonder whether there are other reasons we need this info except for reassign partition command? As we discussed earlier the problem with poor monitoring capabilities for reassign-partitions (as currently we only inform users Comp

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501743#comment-14501743 ] Ashish K Singh commented on KAFKA-313: -- [~nehanarkhede] and [~gwenshap], pinging you g

Re: Review Request 31369: Patch for KAFKA-1982

Jun, My apologies for not catching the checkstyle issues before. Should be fine now. Thanks for the prompt reviews. On Sun, Apr 19, 2015 at 1:14 AM, Ashish Singh wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > Review request for

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1982: -- Attachment: KAFKA-1982_2015-04-19_01:14:24.patch > change kafka.examples.Producer to use the new

[jira] [Commented] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501739#comment-14501739 ] Ashish K Singh commented on KAFKA-1982: --- Updated reviewboard https://reviews.apache.

Re: Review Request 31369: Patch for KAFKA-1982

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated April 19, 2015, 8:14 a.m.) Review request for kafka. Bugs: KAFKA-198