Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85905 --- Ship it! Thanks for the latest patch. +1. BTW, is there any perform

[jira] [Created] (KAFKA-2232) make MockProducer generic

Jun Rao created KAFKA-2232: -- Summary: make MockProducer generic Key: KAFKA-2232 URL: https://issues.apache.org/jira/browse/KAFKA-2232 Project: Kafka Issue Type: Bug Components: clients

[jira] [Updated] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2232: --- Fix Version/s: 0.8.3 > make MockProducer generic > - > > Key: KAFKA-22

Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85916 --- Ship it! Locally test 10+ runs without seeing NPE. - Guozhang Wang

Re: Review Request 33196: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/#review85920 --- Thanks for the explanation Ewen. I agree that a delayed scheduler wo

Re: Review Request 33196: Patch for KAFKA-2123

> On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: > > Thanks for the explanation Ewen. I agree that a delayed scheduler would be > > a good fit here, but was originally more concerned about the complexity we > > introduced by adding two queues (one for delayed actions and another for > > hand

Anyone else sees SocketServerTest failing on trunk?

Hi, I'm running: ./gradlew cleanTest test on trunk and all of SocketServerTest tests are failing with: java.net.SocketException: Socket closed at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:33

Re: [DISCUSSION] Can we move the ack timeout in ProducerRequest to broker?

The replication.timeout means how long a producer would be willing to wait for its produced data to be replicated according to the ack mode. Hence I think it is really a producer config rather than a broker config: one producer could set a smaller replication timeout indicating it does not want to

Re: Review Request 33065: Patch for KAFKA-1928

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33065/ --- (Updated May 31, 2015, 9:49 p.m.) Review request for kafka. Bugs: 1928 and KA

[jira] [Updated] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1928: Attachment: KAFKA-1928_2015-06-01_00:48:08.patch > Move kafka.network over to using the network clas

[jira] [Commented] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566764#comment-14566764 ] Gwen Shapira commented on KAFKA-1928: - Updated reviewboard https://reviews.apache.org/

Review Request 34865: Patch for KAFKA-2101

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34865/ --- Review request for kafka. Bugs: KAFKA-2101 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566767#comment-14566767 ] Tim Brooks commented on KAFKA-2101: --- Created reviewboard https://reviews.apache.org/r/34

[jira] [Updated] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2101: -- Attachment: KAFKA-2101.patch > Metric metadata-age is reset on a failed update > ---

[jira] [Updated] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2101: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Metric metadata-age is reset on a fail

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566770#comment-14566770 ] Tim Brooks commented on KAFKA-2101: --- As I mentioned earlier, this overlaps some with the

[jira] [Created] (KAFKA-2233) Log deletion is not removing log metrics

Stevo Slavic created KAFKA-2233: --- Summary: Log deletion is not removing log metrics Key: KAFKA-2233 URL: https://issues.apache.org/jira/browse/KAFKA-2233 Project: Kafka Issue Type: Bug

Re: Review Request 34524: Fix KAFKA-2208

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34524/ --- (Updated June 1, 2015, 12:05 a.m.) Review request for kafka. Bugs: KAFKA-2208

[jira] [Commented] (KAFKA-1335) Add rebalancing logic to the coordinator / consumer

[ https://issues.apache.org/jira/browse/KAFKA-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566839#comment-14566839 ] Guozhang Wang commented on KAFKA-1335: -- This has been incorporated in KAFKA-2208, clo

[jira] [Resolved] (KAFKA-1335) Add rebalancing logic to the coordinator / consumer

[ https://issues.apache.org/jira/browse/KAFKA-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1335. -- Resolution: Fixed > Add rebalancing logic to the coordinator / consumer > --

Re: Review Request 34524: Fix KAFKA-2208

> On May 28, 2015, 11:42 p.m., Onur Karaman wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 98-133 > > > > > > Let's say a consumer sends a JoinGroupRequest for a new group g and

[jira] [Updated] (KAFKA-2208) Consumer should detect coordinator failures

[ https://issues.apache.org/jira/browse/KAFKA-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2208: - Attachment: KAFKA-2208_2015-05-31_17:05:06.patch > Consumer should detect coordinator failures > -

[jira] [Commented] (KAFKA-2208) Consumer should detect coordinator failures

[ https://issues.apache.org/jira/browse/KAFKA-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566841#comment-14566841 ] Guozhang Wang commented on KAFKA-2208: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review85791 --- Thanks for that patch. A few comments below. Also, two common types

[jira] [Updated] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2187: - Reviewer: Neha Narkhede > Introduce merge-kafka-pr.py script > --

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566884#comment-14566884 ] Neha Narkhede commented on KAFKA-2187: -- [~ijuma] This looks great. I can check it in,

[jira] [Updated] (KAFKA-2233) Log deletion is not removing log metrics

[ https://issues.apache.org/jira/browse/KAFKA-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2233: - Labels: newbie (was: ) > Log deletion is not removing log metrics > -

[jira] [Commented] (KAFKA-2231) Deleting a topic fails

[ https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566889#comment-14566889 ] Neha Narkhede commented on KAFKA-2231: -- [~JGH] Thanks for reporting the issue. Would

RE: [VOTE] KIP-21 Dynamic Configuration

2. There was a typo in my previous email. I meant to say that we should use snake case because it's more consistent. I couldn't find any examples of camel case but did find some snake case (jmx_port). Other than that, most other entries are single word keys. 3. The purge frequency is short (15

[jira] [Commented] (KAFKA-2222) Write "Input/output error" did not result in broker shutdown

[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566956#comment-14566956 ] Jason Rosenberg commented on KAFKA-: Agreed. I think in the past there was a