Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35187/#review86972 --- Is it still possible that in tryCompleteElseWatch after we get the

Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35187/#review86951 --- core/src/main/scala/kafka/server/DelayedOperation.scala

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

2015-06-07 Thread Bo Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Description: kafka-run-class.sh 128 line has a syntax error(missing a space): 127-loggc) 128 if [ -z

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576593#comment-14576593 ] Guozhang Wang commented on KAFKA-2253: -- Created reviewboard

Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
On June 7, 2015, 6:03 a.m., Onur Karaman wrote: core/src/main/scala/kafka/server/DelayedOperation.scala, line 262 https://reviews.apache.org/r/35187/diff/1/?file=980465#file980465line262 Forgot to mention that the commented out code should be removed. Ack. - Guozhang

Review Request 35201: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/ --- Review request for kafka. Bugs: KAFKA-2253

[jira] [Updated] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2253: - Attachment: KAFKA-2253.patch Deadlock in delayed operation purgatory

Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
On June 7, 2015, 6:08 p.m., Jiangjie Qin wrote: Is it still possible that in tryCompleteElseWatch after we get the watcher from watchersForKey() but before we call watchers.watch(), that watcher get removed from purgatory? If so, is it possible that operation got lost? Ack. On June

[jira] [Created] (KAFKA-2255) Missing documentation for max.in.flight.requests.per.connection

2015-06-07 Thread Navina Ramesh (JIRA)
Navina Ramesh created KAFKA-2255: Summary: Missing documentation for max.in.flight.requests.per.connection Key: KAFKA-2255 URL: https://issues.apache.org/jira/browse/KAFKA-2255 Project: Kafka

[jira] [Commented] (KAFKA-2232) make MockProducer generic

2015-06-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576488#comment-14576488 ] Jun Rao commented on KAFKA-2232: [~apakulov], since the partitioner is always instantiated

[jira] [Created] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

2015-06-07 Thread Bo Wang (JIRA)
Bo Wang created KAFKA-2254: -- Summary: The shell script should be optimized , even kafka-run-class.sh has a syntax error. Key: KAFKA-2254 URL: https://issues.apache.org/jira/browse/KAFKA-2254 Project: Kafka