[jira] [Created] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

2015-06-17 Thread TAO XIAO (JIRA)
TAO XIAO created KAFKA-2281: --- Summary: org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value Key: KAFKA-2281 URL: https://issues.apache.org/jira/browse/KAFKA-2281

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

2015-06-17 Thread TAO XIAO (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Description: org.apache.kafka.clients.producer.internals.ErrorLoggingCallback is constructed with byte[] va

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

2015-06-17 Thread TAO XIAO (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Attachment: KAFKA-2281.patch Patch submitted > org.apache.kafka.clients.producer.internals.ErrorLoggingCall

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

2015-06-17 Thread TAO XIAO (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Status: Patch Available (was: Open) > org.apache.kafka.clients.producer.internals.ErrorLoggingCallback hold

Fwd: At-least-once guarantees with high-level consumer

2015-06-17 Thread Carl Heymann
Hi I've sent this to the user mailing list on Monday, but maybe it's more dev oriented, so this is for the dev list. ** Disclaimer: I know there's a new consumer API on the way, this mail is about the currently available API. I also apologise if the below has already been discussed previously. I

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
> On June 16, 2015, 11:04 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 406 > > > > > > Can we now avoid this additional copy of retained messages by sending > > retained messages di

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated June 17, 2015, 10:38 a.m.) Review request for kafka. Bugs: KAFKA-221

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589610#comment-14589610 ] Manikumar Reddy commented on KAFKA-2213: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Status: Patch Available (was: In Progress) > Log cleaner should write compacted messages usin

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213_2015-06-17_16:05:53.patch > Log cleaner should write compacted messages

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

2015-06-17 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589634#comment-14589634 ] Gianmarco De Francisci Morales commented on KAFKA-2092: --- Thanks for

[jira] [Created] (KAFKA-2282) ConsumerConnector enhance

2015-06-17 Thread Jiankang Liu (JIRA)
Jiankang Liu created KAFKA-2282: --- Summary: ConsumerConnector enhance Key: KAFKA-2282 URL: https://issues.apache.org/jira/browse/KAFKA-2282 Project: Kafka Issue Type: Improvement Compo

[jira] [Updated] (KAFKA-2282) ConsumerConnector enhance

2015-06-17 Thread Jiankang Liu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiankang Liu updated KAFKA-2282: Attachment: KAFKA-2282.patch Attached patch to fix this issue. > ConsumerConnector enhance > --

[jira] [Created] (KAFKA-2283) scheduler exception on non-controller node when shutdown

2015-06-17 Thread allenlee (JIRA)
allenlee created KAFKA-2283: --- Summary: scheduler exception on non-controller node when shutdown Key: KAFKA-2283 URL: https://issues.apache.org/jira/browse/KAFKA-2283 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-06-17 Thread Sayat Satybaldiyev (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589891#comment-14589891 ] Sayat Satybaldiyev commented on KAFKA-2078: --- Thanks! No I don't see something wr

Re: Review Request 33049: Patch for KAFKA-2084

2015-06-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review88180 --- This is looking very good. clients/src/main/java/org/apache/kafka/

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88247 --- Hey Onur, I got some rebase errors applying the patch after applyin

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-17 Thread Onur Karaman
> On June 17, 2015, 5:53 p.m., Guozhang Wang wrote: > > Hey Onur, > > > > I got some rebase errors applying the patch after applying KAFKA-1740. > > Could you double check? When I apply KAFKA-1740 first and then KAFKA-2245, I get: ``` > git apply ~/Downloads/rb35231.patch > git apply ~/Downloa

Any reason why LogConfig defaults are different from KafkaConfig defaults?

2015-06-17 Thread Gwen Shapira
Hi, I'm migrating KafkaConfig and LogConfig over to AbstractConfig interface,and I've ran into something strange: All of LogConfig parameters also exist at KafkaConfig level. However the defaults are completely different. Few examples: Maximum message size is 100 + MessageSet.LogOverhead in

Re: Any reason why LogConfig defaults are different from KafkaConfig defaults?

2015-06-17 Thread Jay Kreps
I think this is just a mistake and you should definitely fix it. Nice catch. -Jay On Wed, Jun 17, 2015 at 4:34 PM, Gwen Shapira wrote: > Hi, > > I'm migrating KafkaConfig and LogConfig over to AbstractConfig > interface,and I've ran into something strange: > > All of LogConfig parameters also e

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
> On June 11, 2015, 11:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 > > > > > > Is this castable since props is a map? Also, toProps is really just > > used by LogConfi

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- (Updated June 18, 2015, 12:35 a.m.) Review request for kafka. Bugs: KAFKA-224

[jira] [Updated] (KAFKA-2249) KafkaConfig does not preserve original Properties

2015-06-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2249: Status: Patch Available (was: In Progress) > KafkaConfig does not preserve original Properties > --

[jira] [Updated] (KAFKA-2249) KafkaConfig does not preserve original Properties

2015-06-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2249: Attachment: KAFKA-2249_2015-06-17_17:35:35.patch > KafkaConfig does not preserve original Properties

[jira] [Commented] (KAFKA-2249) KafkaConfig does not preserve original Properties

2015-06-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590932#comment-14590932 ] Gwen Shapira commented on KAFKA-2249: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
> On June 11, 2015, 11:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 > > > > > > Is this castable since props is a map? Also, toProps is really just > > used by LogConfi

Re: Review Request 35231: Fix KAFKA-1740

2015-06-17 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35231/#review88301 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/C

[jira] [Updated] (KAFKA-2282) ConsumerConnector enhance

2015-06-17 Thread Jiankang Liu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiankang Liu updated KAFKA-2282: Status: Patch Available (was: Open) > ConsumerConnector enhance > - > >