Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review89429 --- Thanks for the updated patch. Few more comments.. clients/src/main

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

We were talking on the call about a logo...so here I present "The Original Copycat": http://shirtoid.com/67790/the-original-copycat/ -Jay On Tue, Jun 23, 2015 at 6:28 PM, Gwen Shapira wrote: > One more reason to have CopyCat as a separate project is to sidestep > the entire "Why CopyCat and not

Re: Incomplete Messages

The documentation currently includes the caveat that "As an optimization the server is allowed to return a partial message at the end of the message set. Clients should handle this case." As to whether or not this is a good feature: it is definitely a bad feature. It was originally there because w

Re: high level consumer memory footprint

Hi, I found that the consumer config param fetch.message.max.bytes is set to 100 MB on the consumer and I think this is what caused the problem. It would really be helpful if anyone can explain how much memory the consumer (running 100 threads) is going to need for consuming 100K 1 MB messages fr

[jira] [Commented] (KAFKA-2077) Add ability to specify a TopicPicker class for KafkaLog4jApender

[ https://issues.apache.org/jira/browse/KAFKA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601987#comment-14601987 ] Benoy Antony commented on KAFKA-2077: - [~junrao], could I please get a review of this

[jira] [Commented] (KAFKA-2041) Add ability to specify a KeyClass for KafkaLog4jAppender

[ https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601985#comment-14601985 ] Benoy Antony commented on KAFKA-2041: - [~junrao], could I please get a review of this

Re: Incomplete Messages

Yes that is a bit of a caveat in using zero-copy when sending FetchResponses. i.e., the broker cannot introspect the message-set and lop off any trailing piece. I think this is just something that needs to be documented clearly on that wiki. So there is some overhead for the client implementation i

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601817#comment-14601817 ] Grant Henke commented on KAFKA-972: --- This solutions sounds reasonable to me. > MetadataR

Incomplete Messages

The fetch/message protocol described here shows that the MessageSet returned from a FetchRequest should be structured as: MessageSet => [Offset MessageSize Message] Offset =>

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89379 --- build.gradle (line 57)

[jira] [Resolved] (KAFKA-1540) Gradle error "Could not create task of type 'ScalaDoc'"

[ https://issues.apache.org/jira/browse/KAFKA-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1540. Resolution: Not A Problem This is gradle related issue with java8. This got fixed in gradle

[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601476#comment-14601476 ] Manikumar Reddy commented on KAFKA-2295: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Assignee: Manikumar Reddy (was: Jun Rao) Status: Patch Available (was: Open) > Dynamic

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Attachment: KAFKA-2295.patch > Dynamically loaded classes (encoders, etc.) may not be found by

Re: Review Request 35880: Patch for KAFKA-2295

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated June 25, 2015, 4:25 p.m.) Review request for kafka. Bugs: KAFKA-2295

Review Request 35880: Patch for KAFKA-2295

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- Review request for kafka. Bugs: KAFKA-2295 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601431#comment-14601431 ] Kurt Harriger commented on KAFKA-2300: -- We eventually resolved the problem after hour

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89366 --- Ship it! Thanks for doing this, it all looks good from here - Jaso

Re: Review Request 35867: Patch for KAFKA-1901

> On June 25, 2015, 3:33 p.m., Jason Rosenberg wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 58 > > > > > > what's the reason for this change? This change is for new java

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89364 --- clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.j

[jira] [Commented] (KAFKA-2292) failed fetch request logging doesn't indicate source of request

[ https://issues.apache.org/jira/browse/KAFKA-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601134#comment-14601134 ] Ted Malaska commented on KAFKA-2292: Do you mind if I take a look at this one? > fail

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Move Kafka version to b

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901.patch > Move Kafka version to be generated in code by build (instead of

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600961#comment-14600961 ] Manikumar Reddy commented on KAFKA-1901: Created reviewboard https://reviews.apach

Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- Review request for kafka. Bugs: KAFKA-1901 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Attachment: (was: KAFKA-2281.patch) > org.apache.kafka.clients.producer.internals.ErrorLoggingCallback h

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Attachment: KAFKA-2281_2015-06-25.patch > org.apache.kafka.clients.producer.internals.ErrorLoggingCallback h

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Attachment: (was: KAFKA-2281.patch.1) > org.apache.kafka.clients.producer.internals.ErrorLoggingCallback

[jira] [Updated] (KAFKA-2281) org.apache.kafka.clients.producer.internals.ErrorLoggingCallback holds unnecessary byte[] value

[ https://issues.apache.org/jira/browse/KAFKA-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TAO XIAO updated KAFKA-2281: Attachment: KAFKA-2281.patch.1 Updated patch. Remove reference to byte[] value when logAsString is false >

[jira] [Updated] (KAFKA-2302) Currently iterated chunk is not cleared during consumer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Sprunck updated KAFKA-2302: Component/s: (was: core) consumer > Currently iterated chunk is not cle

[jira] [Created] (KAFKA-2302) Currently iterated chunk is not cleared during consumer shutdown

Matthieu Sprunck created KAFKA-2302: --- Summary: Currently iterated chunk is not cleared during consumer shutdown Key: KAFKA-2302 URL: https://issues.apache.org/jira/browse/KAFKA-2302 Project: Kafka

[jira] [Updated] (KAFKA-2302) Currently iterated chunk is not cleared during consumer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Sprunck updated KAFKA-2302: Affects Version/s: 0.8.1.1 > Currently iterated chunk is not cleared during consumer shutdow