[jira] [Commented] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694837#comment-14694837 ] Ismael Juma commented on KAFKA-1782: Guozhang meant that it has now been committed to

[jira] [Resolved] (KAFKA-2398) Transient test failure for SocketServerTest - Socket closed.

[ https://issues.apache.org/jira/browse/KAFKA-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-2398. Resolution: Duplicate Ewen confirmed that KAFKA-1782 fixes this by avoiding leaks due to teardown no

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694929#comment-14694929 ] Ismael Juma commented on KAFKA-2425: [~omkreddy], I think it's OK because what appears

[jira] [Created] (KAFKA-2430) Listing of PR commits in commit message should be optional

Ismael Juma created KAFKA-2430: -- Summary: Listing of PR commits in commit message should be optional Key: KAFKA-2430 URL: https://issues.apache.org/jira/browse/KAFKA-2430 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-2430) Listing of PR commits in commit message should be optional

[ https://issues.apache.org/jira/browse/KAFKA-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2430: --- Description: Listing of PR commits is useful for curated branches, but the PRs for the Kafka project

[jira] [Created] (KAFKA-2431) Test SSL/TLS impact on performance

Ismael Juma created KAFKA-2431: -- Summary: Test SSL/TLS impact on performance Key: KAFKA-2431 URL: https://issues.apache.org/jira/browse/KAFKA-2431 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-2431) Test SSL/TLS impact on performance

[ https://issues.apache.org/jira/browse/KAFKA-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2431: --- Fix Version/s: 0.8.3 > Test SSL/TLS impact on performance > -- > >

[jira] [Commented] (KAFKA-2431) Test SSL/TLS impact on performance

[ https://issues.apache.org/jira/browse/KAFKA-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695086#comment-14695086 ] Ismael Juma commented on KAFKA-2431: A sensible way to do this is to allow SSL/TLS to

[jira] [Commented] (KAFKA-2417) Ducktape tests for SSL/TLS

[ https://issues.apache.org/jira/browse/KAFKA-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695087#comment-14695087 ] Ismael Juma commented on KAFKA-2417: Performance is now being tracked in KAFKA-2431 so

[jira] [Updated] (KAFKA-2417) Ducktape tests for SSL/TLS

[ https://issues.apache.org/jira/browse/KAFKA-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2417: --- Description: The tests should be complementary to the unit/integration tests written as part of KAFKA

[GitHub] kafka pull request: KAFKA-2430; Listing of PR commits in commit me...

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/136 KAFKA-2430; Listing of PR commits in commit message should be optional If there is a single commit in the PR, then it's never listed. You can merge this pull request into a Git repository by running:

Re: NEW: API Stability annotations!

Very cool! Congrats! :) My only comment is that, as Gwen pointed out in the first email, it is a set of API compatibility annotations, but the name is InterfaceStability. Wouldn't ApiStability be a better name? InterfaceStability looks a bit restrictive, imho. https://github.com/apache/kafka/pu

Re: NEW: API Stability annotations!

We could potentially add more annotations to cover things like public/private APIs, deprecation, etc. I lifted this initial implementation from Hadoop (thanks for the pointer Gwen!). Hadoop also has a public/private annotation that we could lift, and they use this to filter javadocs. These are usef

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695421#comment-14695421 ] Manikumar Reddy commented on KAFKA-2214: [~gwenshap] pinging for review > kafka-r

[jira] [Comment Edited] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694602#comment-14694602 ] Guozhang Wang edited comment on KAFKA-1782 at 8/13/15 4:35 PM: -

Re: NEW: API Stability annotations!

On Thu, Aug 13, 2015 at 8:36 AM, Ewen Cheslack-Postava wrote: > On deprecation, I think we should definitely use the standard annotation to > handle this. Thanks Ewen. I agree that we should use @Deprecated for language-level deprecations. My question was regarding the following: - unstable -

[GitHub] kafka pull request: KAFKA-2411; [WIP] remove usage of blocking cha...

Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695565#comment-14695565 ] ASF GitHub Bot commented on KAFKA-2411: --- Github user ijuma closed the pull request a

[jira] [Assigned] (KAFKA-2274) Add integration test for consumer coordinator

[ https://issues.apache.org/jira/browse/KAFKA-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-2274: -- Assignee: Jason Gustafson > Add integration test for consumer coordinator > ---

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695575#comment-14695575 ] Ismael Juma commented on KAFKA-2411: I pushed an additional commit that updates `Contr

[jira] [Updated] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2389: Status: Patch Available (was: Open) > CommitType seems not necessary in commit(). > ---

[jira] [Comment Edited] (KAFKA-2411) remove usage of BlockingChannel in the broker

[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695575#comment-14695575 ] Ismael Juma edited comment on KAFKA-2411 at 8/13/15 5:09 PM: -

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: {format} [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0 e

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0 expired o

[jira] [Created] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

Mayuresh Gharat created KAFKA-2432: -- Summary: Controlled shutdown does not proceed successfully while shutting down the broker. Key: KAFKA-2432 URL: https://issues.apache.org/jira/browse/KAFKA-2432 P

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: {code} [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0 exp

[jira] [Commented] (KAFKA-2189) Snappy compression of message batches less efficient in 0.8.2.1

[ https://issues.apache.org/jira/browse/KAFKA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695589#comment-14695589 ] Andrew Otto commented on KAFKA-2189: Hi all, The Wikimedia Foundation had a serious p

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker. Follow up from KAFKA-2351

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Summary: Controlled shutdown does not proceed successfully while shutting down the broker. Fol

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695608#comment-14695608 ] Jason Gustafson commented on KAFKA-2388: [~onurkaraman] Have you had a chance to g

[GitHub] kafka pull request: KAFKA-2430; Listing of PR commits in commit me...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2430) Listing of PR commits in commit message should be optional

[ https://issues.apache.org/jira/browse/KAFKA-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695623#comment-14695623 ] ASF GitHub Bot commented on KAFKA-2430: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2430) Listing of PR commits in commit message should be optional

[ https://issues.apache.org/jira/browse/KAFKA-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2430: - Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available)

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695654#comment-14695654 ] Alexander Pakulov commented on KAFKA-1782: -- [~ewencp] [~guozhang] thanks for taki

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695753#comment-14695753 ] Onur Karaman commented on KAFKA-2388: - You could take it over if you want. Sorry, I s

[jira] [Commented] (KAFKA-2398) Transient test failure for SocketServerTest - Socket closed.

[ https://issues.apache.org/jira/browse/KAFKA-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695775#comment-14695775 ] Ewen Cheslack-Postava commented on KAFKA-2398: -- Sadly this does not seem to h

[jira] [Reopened] (KAFKA-2398) Transient test failure for SocketServerTest - Socket closed.

[ https://issues.apache.org/jira/browse/KAFKA-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava reopened KAFKA-2398: -- > Transient test failure for SocketServerTest - Socket closed. > ---

Re: [DISCUSS] Client-side Assignment for New Consumer

Hey Onur and Jiangjie, I've updated that wiki with a proposal to add regex subscriptions to the consumer metadata. Can you have a look to see if it addresses your concern? In general, I think we should be a little careful when we are talking about the scalability of the protocol. Regardless of whe

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/ --- (Updated Aug. 13, 2015, 8:10 p.m.) Review request for kafka. Bugs: KAFKA-2351

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-08-13_13:10:05.patch > Brokers are having a problem shutting down

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Status: Patch Available (was: In Progress) > Brokers are having a problem shutting down corre

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695859#comment-14695859 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard https://reviews.apach

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695877#comment-14695877 ] Jason Gustafson commented on KAFKA-2388: [~onurkaraman] I'll take a shot at it. If

Re: [DISCUSS] Client-side Assignment for New Consumer

Jason, The protocol has to consider the scalability. The protocol in the wiki means the JoinGroupResoponse size would be: NumberOfTopics * (AvgTopicNameLength + 4) * (NumberOfConsumers)^2 To give some real number, we have 26-node Mirror Maker cluster, each with 4 consumers. That is 104 consumers

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695932#comment-14695932 ] Jiangjie Qin commented on KAFKA-2406: - [~junrao] ping for review. > ISR propagation s

Re: [DISCUSS] Client-side Assignment for New Consumer

Becket, Did you see the updates to the "ConsumerEmbeddedProtocol" section, specifically on how regex subscriptions like you're describing are handled? The updated version removes almost all the metadata in the regex case by taking advantage of exactly the point you made in (2). The clients don't a

Re: [DISCUSS] Client-side Assignment for New Consumer

Thanks Jiangjie, that information helps. I agree the protocol must consider scalability. My point was that the synchronization barrier in the current protocol already effectively limits the number of consumers since it provides no way to gracefully handle churn. It wouldn't be worth worrying about

[GitHub] kafka pull request: MINOR: expose vagrant base box as variable

GitHub user granders opened a pull request: https://github.com/apache/kafka/pull/137 MINOR: expose vagrant base box as variable Added base_box variable to Vagrantfile. This makes it possible to override the base box in Vagrantfile.local. You can merge this pull request into a Git r

Re: NEW: API Stability annotations!

IMO, both old producer and old consumer APIs should be marked as deprecated for 0.8.3 (since the new code will be in and we want to encourage the switch). I'd like to see 0.9 released with just the new java clients. On Thu, Aug 13, 2015 at 6:47 AM, Ismael Juma wrote: > On Thu, Aug 13, 2015 at

[GitHub] kafka pull request: KAFKA-2406: Throttle ISR propagation

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696012#comment-14696012 ] ASF GitHub Bot commented on KAFKA-2406: --- Github user asfgit closed the pull request

[jira] [Resolved] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2406. Resolution: Fixed Fix Version/s: 0.8.3 Issue resolved by pull request 114 [https://github.com/apache/

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696026#comment-14696026 ] Allen Wang commented on KAFKA-1215: --- [~junrao] Can you review the GitHub pull request or

[GitHub] kafka pull request: MINOR: expose vagrant base box as variable

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696072#comment-14696072 ] James Cheng commented on KAFKA-2367: Using Avro makes sense to me, instead of writing

Re: NEW: API Stability annotations!

On Thu, Aug 13, 2015 at 10:41 PM, Gwen Shapira wrote: > IMO, both old producer and old consumer APIs should be marked as deprecated > for 0.8.3 (since the new code will be in and we want to encourage the > switch). > I can see the appeal of this, but it's also worth considering the downsides for

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review95344 --- build.gradle (line 383)

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696141#comment-14696141 ] Alexander Pakulov commented on KAFKA-1782: -- [~guozhang] am I able to use github P

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696161#comment-14696161 ] Guozhang Wang commented on KAFKA-1782: -- [~apakulov] we are currently moving to the PR

Re: NEW: API Stability annotations!

Thanks for starting the discussion around API annotations, Gwen! I think it is better to add the deprecated annotation after the new consumer API is successfully deployed at a couple places. On Thu, Aug 13, 2015 at 3:42 PM, Ismael Juma wrote: > On Thu, Aug 13, 2015 at 10:41 PM, Gwen Shapira wro

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696196#comment-14696196 ] Jiangjie Qin commented on KAFKA-2406: - Thanks, [~junrao]. > ISR propagation should be

Re: [DISCUSS] Client-side Assignment for New Consumer

Ewen and Jason, Thanks for the reply. Sorry I missed the metadata hash. Yes, that is a clever approach and would solve my concern about the data passing around. I can see both pros and cons from doing this, though. The advantage is we don't need the topic metadata in JoinGroupResponse anymore. The

Re: Review Request 33049: Patch for KAFKA-2084

> On Aug. 13, 2015, 11:13 p.m., Joel Koshy wrote: > > build.gradle, line 383 > > > > > > I don't think these changes 383-385 are needed. > > > > Also, (unrelated to this change) I'm seeing NPE errors in run

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review95369 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.ja

[jira] [Commented] (KAFKA-2397) leave group request

[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696327#comment-14696327 ] Ewen Cheslack-Postava commented on KAFKA-2397: -- Can we be more concrete about

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-08-13_19:08:27.patch > byte rate metrics per client ID (produc

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 14, 2015, 2:08 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696333#comment-14696333 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 14, 2015, 2:09 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2397) leave group request

[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696334#comment-14696334 ] Jiangjie Qin commented on KAFKA-2397: - [~ewencp] Are you saying that the coordinator s

Re: Review Request 33049: Patch for KAFKA-2084

> On Aug. 14, 2015, 1:57 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, > > lines 69-77 > > > > > > This is probably not the right place to throw QuotaViolationExcept

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 14, 2015, 2:19 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-08-13_19:19:16.patch > byte rate metrics per client ID (produc

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696339#comment-14696339 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 14, 2015, 2:20 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Created] (KAFKA-2433) Remove documentation on dead configuration item: replica.lag.max.messages

Stephen Powis created KAFKA-2433: Summary: Remove documentation on dead configuration item: replica.lag.max.messages Key: KAFKA-2433 URL: https://issues.apache.org/jira/browse/KAFKA-2433 Project: Kafk

[jira] [Updated] (KAFKA-2433) Remove documentation on dead configuration item: replica.lag.max.messages

[ https://issues.apache.org/jira/browse/KAFKA-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Powis updated KAFKA-2433: - Status: Patch Available (was: Open) Attached a patch > Remove documentation on dead configuratio

[jira] [Updated] (KAFKA-2433) Remove documentation on dead configuration item: replica.lag.max.messages

[ https://issues.apache.org/jira/browse/KAFKA-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Powis updated KAFKA-2433: - Attachment: documentation-update.diff > Remove documentation on dead configuration item: replica.l

[jira] [Commented] (KAFKA-2397) leave group request

[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696351#comment-14696351 ] Jason Gustafson commented on KAFKA-2397: [~ewencp] The only case I can come up wit

Nightly build snapshots?

There are certain features in the latest trunk for 0.8.3 release which we would like to test in our dev environments. Is there some place where we can get the official nightly snapshot packaged builds or is the recommended way to always fetch latest source code and build it locally to try out t

Re: Review Request 34766: Patch for KAFKA-2229

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review95376 --- core/src/main/scala/kafka/server/TopicCommandHelper.scala (line 57)

Re: NEW: API Stability annotations!

Got it! I was under the impression that deprecated means "there is something better now and we'll remove this in few releases". But yeah, lets avoid marking it for now. On Thu, Aug 13, 2015 at 4:58 PM, Neha Narkhede wrote: > Thanks for starting the discussion around API annotations, Gwen! I thin

[Copycat] How will copycat serialize its metadata

Hi Team Kafka, As you know from KIP-26 and PR-99, when you will use Copycat to move data from an external system to Kafka, in addition to storing the data itself, Copycat will also need to store some metadata. This metadata is currently offsets on the source system (say, SCN# from Oracle redo log

[copycat] How to upgrade connectors

Hi Team Kafka, This may be a slightly premature discussion, but forgetting about upgrades is a newbie mistake I'd like us to avoid :) So, we have connector-plugins, and users use them to create connector-instances. This requires some configuration - database connection string, HDFS namenode, etc.

[copycat] support for "batch" jobs

Hi Team Kafka, (sorry for the flood, this is last one! promise!) If you tried out PR-99, you know that CopyCat now does on-going export/import. So it will continuously read data from a source and write it to Kafka (or vice versa). This is great for tailing logs and replicating from MySQL binlog.

Re: Copycat (KIP-26. PR-99) - plan on moving forward

Reminder: If no one objects, I'm planning on merging PR-99 tomorrow. On Wed, Aug 12, 2015 at 11:17 AM, Gwen Shapira wrote: > Hi Kafka fans, > > I'd like to move ahead with getting the initial Copycat patches into Kafka. > > If you'll look at the PR, we still have a number of open questions on th

[jira] [Updated] (KAFKA-2433) Remove documentation on dead configuration item: replica.lag.max.messages

[ https://issues.apache.org/jira/browse/KAFKA-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2433: Reviewer: Gwen Shapira > Remove documentation on dead configuration item: replica.lag.max.messages >

[jira] [Commented] (KAFKA-2433) Remove documentation on dead configuration item: replica.lag.max.messages

[ https://issues.apache.org/jira/browse/KAFKA-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696505#comment-14696505 ] Gwen Shapira commented on KAFKA-2433: - Thank you! Your patch modifies the docs both f

Re: [DISCUSS] Client-side Assignment for New Consumer

Ewen/Jason, The metadata hash is a clever approach and certainly addresses the problem of large metadata for consumers like mirror maker. Few comments - 1. In the interest of simplifying the format of the consumer's metadata - Why not just always include only the topic names in the metadat

Re: [DISCUSS] Client-side Assignment for New Consumer

Becket, As you say, the metadata hash addresses the concern you originally raised about large topic subscriptions. Can you please list other problems you are raising more clearly? It is more helpful to know problems that the proposal does not address or addresses poorly. Regarding other things yo

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696540#comment-14696540 ] James Cheng commented on KAFKA-2367: I just read through PR-99. I saw that even just t

Re: [Copycat] How will copycat serialize its metadata

Copycat enables streaming data in and out of Kafka. Connector writers need to define the serde of the data as it is different per system. Metadata should be entirely hidden by the copycat framework and isn't something users or connector implementors need to serialize differently as long as we provi

[jira] [Commented] (KAFKA-2397) leave group request

[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696551#comment-14696551 ] Onur Karaman commented on KAFKA-2397: - Sooo... ship it?! > leave group request >

Re: Copycat (KIP-26. PR-99) - plan on moving forward

+1 on resolving some of these open issues separately. It is a pain to maintain, review, discuss and commit these type of large patches. Typically the set of improvements to really stabilize new features like this go well beyond one large initial patch anyway. On Thu, Aug 13, 2015 at 10:24 PM, Gwen