GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/149
MINOR: Use `EasyMock.newCapture` instead of deprecated `new Capture`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
[
https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Anderson updated KAFKA-2439:
-
Reviewer: Ewen Cheslack-Postava
Add MirrorMakerService to ducktape system tests
GitHub user granders opened a pull request:
https://github.com/apache/kafka/pull/148
KAFKA-2439: Add MirrorMaker service class for system tests
Added MirrorMaker service and a few corresponding sanity checks, as well as
necessary config template files. A few additional updates to
[
https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700909#comment-14700909
]
ASF GitHub Bot commented on KAFKA-2439:
---
GitHub user granders opened a pull request:
Hi Jun,
Answers below:
1. When there are multiple common protocols in the JoinGroupRequest, which
one would the coordinator pick?
I was intending to use the list to indicate preference. If all group
members support protocols [A, B] in that order, then we will choose
A. If some support [B, A],
I sort of follow Daniel Nelson on this issue: cut a 0.8.2.2 but not include
much thing besides Snappy fixes. I mean, include a couple of additional
critical bug fixes, if really urgent, and that's it.
On Tue, Aug 18, 2015 at 3:25 PM, Daniel Nelson daniel.nel...@vungle.com
wrote:
I am strongly
[
https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2308:
Fix Version/s: 0.8.2.2
New producer + Snappy face un-compression errors after broker restart
[
https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2235:
Fix Version/s: 0.8.2.2
LogCleaner offset map overflow
--
[
https://issues.apache.org/jira/browse/KAFKA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2189:
Fix Version/s: 0.8.2.2
Snappy compression of message batches less efficient in 0.8.2.1
Jason,
Thanks for the writeup. A few comments below.
1. When there are multiple common protocols in the JoinGroupRequest, which
one would the coordinator pick?
2. If the protocols don't agree, the group construction fails. What exactly
does it mean? Do we send an error in every JoinGroupResponse
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani updated KAFKA-1690:
--
Attachment: KAFKA-1690_2015-08-18_11:24:46.patch
Add SSL support to Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701735#comment-14701735
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/
---
(Updated Aug. 18, 2015, 6:24 p.m.)
Review request for kafka.
Bugs:
How about looking at the scope for the 0.8.3 release first before we cut
yet another point release off of 0.8.2.2? Each release includes some
overhead and if there is a larger release in the works, it might be worth
working on getting that. My take is that the 2 things the community has
been
Dong Lin created KAFKA-2442:
---
Summary: QuotasTest should not fail when cpu is busy
Key: KAFKA-2442
URL: https://issues.apache.org/jira/browse/KAFKA-2442
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1883:
Fix Version/s: 0.8.2.2
NullPointerException in RequestSendThread
[
https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1836:
Fix Version/s: 0.8.2.2
metadata.fetch.timeout.ms set to zero blocks forever
I agree: keep it simple :) The latest stable version of Kafka right now has a
critical bug in it. Fixing that would be good enough. 0.8.2.2 should probably
just a maintenance/bugfix release.
On Aug 18, 2015, at 14:29, Edward Ribeiro edward.ribe...@gmail.com wrote:
I sort of follow
The the following are the notes for today's KIP discussion.
* client-side assignment strategy: We discussed concerns about rebalancing
time due to metadata inconsistency, especially when lots of topics are
subscribed. Will discuss a bit more on the mailing list.
* CopyCat data api: The
[
https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1057:
Fix Version/s: 0.8.2.2
Trim whitespaces from user specified configs
[
https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1758:
Fix Version/s: 0.8.2.2
corrupt recovery file prevents startup
[
https://issues.apache.org/jira/browse/KAFKA-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2114:
Fix Version/s: 0.8.2.2
Unable to change min.insync.replicas default
[
https://issues.apache.org/jira/browse/KAFKA-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1668:
Fix Version/s: 0.8.2.2
TopicCommand doesn't warn if --topic argument doesn't match any topics
[
https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2096:
Fix Version/s: 0.8.2.2
Enable keepalive socket option for broker to prevent socket leak
Thanks Jun.
I updated the list with your suggestions.
If anyone feels we are missing a critical patch for 0.8.2.2, please speak
up.
Gwen
On Mon, Aug 17, 2015 at 5:40 PM, Jun Rao j...@confluent.io wrote:
Hi, Grant,
I took a look at that list. None of those is really critical as you said.
Jun,
Yes, I agree. If the metadata can be synced quickly there should not be an
issue. It just occurred to me that there is a proposal to allow consuming
from followers in ISR, that could potentially cause more frequent metadata
change for consumers. Would that be an issue?
Thanks,
Jiangjie
On Aug. 18, 2015, 4:09 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 438
https://reviews.apache.org/r/33620/diff/17/?file=1042291#file1042291line438
Hmm, do we want to break here? It seems that we want to continue in the
[
https://issues.apache.org/jira/browse/KAFKA-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoff Anderson updated KAFKA-2439:
--
Labels: patch-available (was: )
Add MirrorMakerService to ducktape system tests
Jun,
KAFKA-2147 doesn't seem to have a commit associated with it, so I can't
cherrypick just this fix.
I suggest leaving this out since there is a 0.8.2.x workaround in the JIRA.
Gwen
On Mon, Aug 17, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote:
Gwen,
Thanks for putting the list
On Aug. 18, 2015, 4:09 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 450
https://reviews.apache.org/r/33620/diff/17/?file=1042291#file1042291line450
The termination condition doesn't seem quite right. If dst has no
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-08-18_13:24:00.patch
Client side protocol changes to return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/
---
(Updated Aug. 18, 2015, 8:24 p.m.)
Review request for kafka, Joel Koshy and
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701929#comment-14701929
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702059#comment-14702059
]
Sriharsha Chintalapani commented on KAFKA-1070:
---
[~paetling] Here
Any objections if I leave KAFKA-2114 (setting min.insync.replicas default)
out?
The test code is using changes that were done after 0.8.2.x cut-off, which
makes it difficult to cherry-pick.
Gwen
On Tue, Aug 18, 2015 at 12:16 PM, Gwen Shapira g...@confluent.io wrote:
Jun,
KAFKA-2147
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-08-18_13:19:57.patch
Client side protocol changes to return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/
---
(Updated Aug. 18, 2015, 8:20 p.m.)
Review request for kafka, Joel Koshy and
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701925#comment-14701925
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701894#comment-14701894
]
ASF GitHub Bot commented on KAFKA-2436:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Thanks for the notes, Jun. There was a mention of single-writer behavior, if I
understood correctly, in the context of the new consumer, and I was wondering
if that's specific to the new consumer work or if it's going to have any
dependency or relation to KIP-27.
-Flavio
On 18 Aug 2015, at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/
---
(Updated Aug. 18, 2015, 8:24 p.m.)
Review request for kafka, Joel Koshy and
[
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702030#comment-14702030
]
Alex Etling commented on KAFKA-1070:
Hello Kafka Geniuses,
I have a question
[
https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702063#comment-14702063
]
Neha Narkhede commented on KAFKA-2367:
--
I think there are various tradeoffs, as with
[
https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2330:
-
Reviewer: Gwen Shapira (was: Joe Stein)
Vagrantfile sets global configs instead
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1690:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
[~sriharsha], thanks a lot for your
On Aug. 19, 2015, 1:56 a.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 520
https://reviews.apache.org/r/33620/diff/18/?file=1043256#file1043256line520
second flip after `BUFFER_OVERFLOW` in `handshakeWrap` - you had
mentioned offline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review95765
---
I haven't finished going through the latest patch, but discussed
[
https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702443#comment-14702443
]
Ewen Cheslack-Postava commented on KAFKA-2330:
--
[~gwenshap] Reassigned to you
On Aug. 19, 2015, 1:56 a.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 520
https://reviews.apache.org/r/33620/diff/18/?file=1043256#file1043256line520
second flip after `BUFFER_OVERFLOW` in `handshakeWrap` - you had
mentioned offline
See https://builds.apache.org/job/Kafka-trunk/590/changes
Changes:
[cshapi] KAFKA-2436; log.retention.hours should be honored by LogManager
--
[...truncated 1501 lines...]
kafka.api.test.ProducerCompressionTest testCompression[2] PASSED
Yes, that's related to the zombie consumer. Basically, if a consumer is in
a long GC, it may be taken out of the group. However, when the consumer
wakes up from the GC, it may still be able to consume data that it's no
longer responsible for. We protect this a little bit by not allowing a
zombie
Follow-up from the kip call:
1. Onur brought up the question of whether this protocol provides enough
coordination capabilities to be generally useful in practice (is that
accurate, Onur?). If it doesn't, then each use case would probably need a
dependence on zookeeper anyway, and we haven't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review95798
---
Ship it!
Looks good to me. Could you rebase?
- Jun Rao
On Aug.
On Aug. 18, 2015, 11:33 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaManager.scala, line 147
https://reviews.apache.org/r/33049/diff/28/?file=1040947#file1040947line147
The window used here is a bit different from that used in
Rate.measure() and it doesn't
Aditya Auradkar created KAFKA-2443:
--
Summary: Expose windowSize on Measurable
Key: KAFKA-2443
URL: https://issues.apache.org/jira/browse/KAFKA-2443
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702223#comment-14702223
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review95793
---
I am strongly in favor of cutting a 0.8.2.2 release, but I don’t think that it
needs to include anything other than the fix for Snappy that kicked off this
discussion in the first place. If there are additional critical issues that can
be included without delaying the process, I see no
[
https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702161#comment-14702161
]
Benoy Antony commented on KAFKA-2041:
-
[~junrao], Would you be able to review the
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani updated KAFKA-1690:
--
Attachment: KAFKA-1690_2015-08-18_17:24:48.patch
Add SSL support to Kafka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/
---
(Updated Aug. 19, 2015, 12:24 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36652/#review95824
---
Patch needs a rebase.
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701393#comment-14701393
]
Gwen Shapira commented on KAFKA-2203:
-
Thanks [~aw]. The report in HADOOP-12129 looks
[
https://issues.apache.org/jira/browse/KAFKA-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701294#comment-14701294
]
Prabhjot Singh Bharaj commented on KAFKA-2385:
--
I had reported the shell does
[
https://issues.apache.org/jira/browse/KAFKA-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira reopened KAFKA-2385:
-
Ok, I'll check, and in the meanwhile, you can just get a copy of the zk
distribution
On Aug. 5, 2015, 4:44 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java,
line 55
https://reviews.apache.org/r/33378/diff/10/?file=1010009#file1010009line55
We actually will need different constructors for different versions. We
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701571#comment-14701571
]
Flavio Junqueira commented on KAFKA-1387:
-
[~guozhang] it looks like
[
https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2436:
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701418#comment-14701418
]
Flavio Junqueira commented on KAFKA-1387:
-
It doesn't look like it 'd be a small
On Aug. 3, 2015, 4:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
lines 368-381
https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line368
If handshake status is BUFFER_OVERFLOW, we will return to the caller
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701509#comment-14701509
]
Guozhang Wang commented on KAFKA-1387:
--
Thanks [~fpj], that makes sense to me.
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701486#comment-14701486
]
Allen Wittenauer commented on KAFKA-2203:
-
We've got a ways to go before we do a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review95671
---
Ship it!
Thanks for the latest patch. +1. I only have a few minor
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701502#comment-14701502
]
Jun Rao commented on KAFKA-1690:
[~sriharsha], thanks for the latest patch. It looks good
75 matches
Mail list logo
