Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Michal Borowiecki
Well, another concern, apart from potential confusion, is that you won't be able to peek the actual next key, just the timestamp. So the tradeoff is between having consistency in return types versus consistency in having the ability to know the next key without moving the iterator. To me the lat

Re: [DISCUSS] Modify / Remove "Unstable" annotations in Streams API

2017-05-10 Thread Ismael Juma
Thanks for the proposal Guozhang. This sounds good to me. Ismael On Thu, May 11, 2017 at 6:02 AM, Guozhang Wang wrote: > Hello folks, > > As we are approaching the feature freeze deadline of 0.11.0.0, one thing I > realized is that currently the Streams public APIs are still marked as > "Unstab

Build failed in Jenkins: kafka-trunk-jdk8 #1501

2017-05-10 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-5213; Mark a MemoryRecordsBuilder as full as soon as the append -- [...truncated 3.57 MB...] kafka.server.ReplicaFetcherThreadTest > shouldMov

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Eno Thereska
+1 Thanks Eno > On 10 May 2017, at 20:25, Michal Borowiecki > wrote: > > Apologies, I missed the discussion (or lack thereof) about the return type of: > > WindowStoreIterator> fetch(K from, K to, long timeFrom, long > timeTo) > > > WindowStoreIterator (as the KIP mentions) is a subclass o

[jira] [Commented] (KAFKA-5209) Transient failure: kafka.server.MetadataRequestTest.testControllerId

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005898#comment-16005898 ] ASF GitHub Bot commented on KAFKA-5209: --- GitHub user umesh9794 opened a pull request

[GitHub] kafka pull request #3018: KAFKA-5209 : Transient failure: kafka.server.Metad...

2017-05-10 Thread umesh9794
GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3018 KAFKA-5209 : Transient failure: kafka.server.MetadataRequestTest.testControllerId Added sleep after creating the socket so that socket can be spawned properly and ready to send the request. @guo

[DISCUSS] Modify / Remove "Unstable" annotations in Streams API

2017-05-10 Thread Guozhang Wang
Hello folks, As we are approaching the feature freeze deadline of 0.11.0.0, one thing I realized is that currently the Streams public APIs are still marked as "Unstable", which is to indicate that the API itself does not provide guarantees about backward compatibility across releases. On the other

Re: [VOTE] KIP-146: Isolation of dependencies and classes in Kafka Connect (restarted voting thread)

2017-05-10 Thread Konstantine Karantasis
The KIP description has been updated to reflect the use of the term plugin.path instead. -Konstantine On Wed, May 10, 2017 at 2:10 PM, Ismael Juma wrote: > Konstantine, I am not convinced that it will represent similar > functionality as the goals are different. Also, I don't see a migration

[jira] [Updated] (KAFKA-5204) Connect needs to validate Connector type during instantiation

2017-05-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-5204: --- Fix Version/s: (was: 0.10.2.1) > Connect needs to validate Connector type during instantiation > -

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Jason Gustafson
+1 On Wed, May 10, 2017 at 1:45 PM, Xavier Léauté wrote: > Thank you for the feedback Michal. > > While I agree the return may be a little bit more confusing to reason > about, the reason for doing so was to keep the range query interfaces > consistent with their single-key counterparts. > > In

Jenkins build is back to normal : kafka-trunk-jdk8 #1500

2017-05-10 Thread Apache Jenkins Server
See

[jira] [Updated] (KAFKA-5194) KIP-153: Include only client traffic in BytesOutPerSec metric

2017-05-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-5194: --- Status: Patch Available (was: Open) > KIP-153: Include only client traffic in BytesOutPerSec metric >

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005754#comment-16005754 ] ASF GitHub Bot commented on KAFKA-5213: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #3015: KAFKA-5213; Mark a MemoryRecordsBuilder as full as...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-5213. Resolution: Fixed Issue resolved by pull request 3015 [https://github.com/apache/kafka/pull/

Re: [VOTE] KIP-143: Controller Health Metrics

2017-05-10 Thread Ismael Juma
Thanks everyone for the feedback and votes. The vote has passed with 5 binding +1s (Sriram, Neha, Gwen, Jun, Ismael) and 5 non-binding +1s (Michael, Tom, Mickael, James, Onur). Ismael On Fri, May 5, 2017 at 3:34 AM, Ismael Juma wrote: > Hi everyone, > > It seems like the discussion has converge

[GitHub] kafka pull request #3017: Kafka 5218: New Short serializer, deserializer, se...

2017-05-10 Thread mmolimar
GitHub user mmolimar opened a pull request: https://github.com/apache/kafka/pull/3017 Kafka 5218: New Short serializer, deserializer, serde You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmolimar/kafka KAFKA-5218 Alternatively

Re: [VOTE] KIP-143: Controller Health Metrics

2017-05-10 Thread Ismael Juma
Sorry for missing this question Onur. I think we covered that in the discussion thread since (thanks for raising it again). On Sat, May 6, 2017 at 2:08 AM, Onur Karaman wrote: > I noticed that both the ControllerState metric and the *RateAndTimeMs > metrics only cover a subset of the controller

Re: [VOTE] KIP-143: Controller Health Metrics

2017-05-10 Thread Jun Rao
Hi, Ismael, Thanks for the latest update. +1 from me, Jun On Thu, May 4, 2017 at 7:34 PM, Ismael Juma wrote: > Hi everyone, > > It seems like the discussion has converged, so I would like to initiate the > voting process for KIP-143: Controller Health Metrics: > > https://cwiki.apache.org/conf

Re: [DISCUSS] KIP-143: Controller Health Metrics

2017-05-10 Thread Ismael Juma
Thanks Jun. Discussed this offline with Onur and Jun and I believe there's agreement so updated the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action? pageId=69407758&selectedPageVersions=8&selectedPageVersions=7 Ismael On Wed, May 10, 2017 at 4:46 PM, Jun Rao wrote: > H

Re: [VOTE] KIP-153 (separating replication traffic from BytesOutPerSec metric)

2017-05-10 Thread Jun Rao
Hi, Thanks for everyone who have voted. The results are 6 binding +1 (Ismael, Sriram, Guozhang, Rajini, Becket, Joel) 5 non-binding +1 (James, Michael, Edoardo, Roger, Dong) 0 -1 The vote passes. Jun On Tue, May 9, 2017 at 11:54 AM, Xavier Léauté wrote: > +1 (non-binding) > > On Tue, May 9,

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Colin McCabe
Thanks, all! With +1s from Jun Rao, Gwen Shapira, Ismael Juma, Ram Subramanian, Michael Pearce, and Dongjin Lee, the vote passes. Thanks for all the comments. cheers, Colin On Wed, May 10, 2017, at 17:51, Jun Rao wrote: > Hi, Colin, > > Thanks for the KIP. +1 from me. > > Jun > > On Wed, M

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Colin McCabe
On Wed, May 10, 2017, at 17:41, Jason Gustafson wrote: > > > > Hmm... I agree that the request is invalid, but it's invalid because the > > version is not supported. I guess I think UnsupportedVersionException > > is a very specific exception that tells users exactly what is wrong > > (aha! it's t

[jira] [Created] (KAFKA-5218) New Short serializer, deserializer, serde

2017-05-10 Thread Mario Molina (JIRA)
Mario Molina created KAFKA-5218: --- Summary: New Short serializer, deserializer, serde Key: KAFKA-5218 URL: https://issues.apache.org/jira/browse/KAFKA-5218 Project: Kafka Issue Type: Improvement

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Jun Rao
Hi, Colin, Thanks for the KIP. +1 from me. Jun On Wed, May 10, 2017 at 1:24 PM, Colin McCabe wrote: > Hi all, > > Some folks said that the previous VOTE thread was getting collapsed by > gmail into a different thread, so I am reposting this. > > The KIP page is here: > https://cwiki.apache.org

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Gwen Shapira
+1 The email title made me do a double-take: I thought you are adding a new thread to Kafka for handling the admin RPC... On Wed, May 10, 2017 at 5:42 PM Jason Gustafson wrote: > +1 > > On Wed, May 10, 2017 at 3:01 PM, Ismael Juma wrote: > > > Repeating my vote here, +1 (binding). > > > > Isma

[jira] [Created] (KAFKA-5217) Improve Streams internal exception handling

2017-05-10 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5217: -- Summary: Improve Streams internal exception handling Key: KAFKA-5217 URL: https://issues.apache.org/jira/browse/KAFKA-5217 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Jason Gustafson
+1 On Wed, May 10, 2017 at 3:01 PM, Ismael Juma wrote: > Repeating my vote here, +1 (binding). > > Ismael > > On Wed, May 10, 2017 at 9:24 PM, Colin McCabe wrote: > > > Hi all, > > > > Some folks said that the previous VOTE thread was getting collapsed by > > gmail into a different thread, so I

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Jason Gustafson
> > Hmm... I agree that the request is invalid, but it's invalid because the > version is not supported. I guess I think UnsupportedVersionException > is a very specific exception that tells users exactly what is wrong > (aha! it's the version!) whereas InvalidRequestException is kind of a > gener

[jira] [Updated] (KAFKA-5194) KIP-153: Include only client traffic in BytesOutPerSec metric

2017-05-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-5194: --- Summary: KIP-153: Include only client traffic in BytesOutPerSec metric (was: KIP-153 : Include only c

Build failed in Jenkins: kafka-trunk-jdk8 #1499

2017-05-10 Thread Apache Jenkins Server
See Changes: [junrao] KAFKA-5099; Replica Deletion Regression from KIP-101 -- [...truncated 3.58 MB...] kafka.coordinator.transaction.TransactionCoordinatorTest > should

[jira] [Updated] (KAFKA-5216) Cached Session/Window store may return error on iterator.peekNextKey()

2017-05-10 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-5216: - Status: Patch Available (was: Open) > Cached Session/Window store may return error on iterator.pe

[jira] [Commented] (KAFKA-5216) Cached Session/Window store may return error on iterator.peekNextKey()

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005683#comment-16005683 ] ASF GitHub Bot commented on KAFKA-5216: --- GitHub user xvrl opened a pull request:

[GitHub] kafka pull request #3016: KAFKA-5216 fix error on peekNextKey in cached wind...

2017-05-10 Thread xvrl
GitHub user xvrl opened a pull request: https://github.com/apache/kafka/pull/3016 KAFKA-5216 fix error on peekNextKey in cached window/session store iterators @guozhangwang @mjsax @dguy You can merge this pull request into a Git repository by running: $ git pull https://github

[jira] [Created] (KAFKA-5216) Cached Session/Window store may return error on iterator.peekNextKey()

2017-05-10 Thread JIRA
Xavier Léauté created KAFKA-5216: Summary: Cached Session/Window store may return error on iterator.peekNextKey() Key: KAFKA-5216 URL: https://issues.apache.org/jira/browse/KAFKA-5216 Project: Kafka

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Colin McCabe
On Wed, May 10, 2017, at 15:54, Jason Gustafson wrote: > Hey Colin, > > Thanks, I think continuing to bump the protocol makes sense. It's nice to > be consistent with the other APIs. In the KIP, you have the following: > > > If the client is newer than the broker, some of the fields may show up a

[jira] [Commented] (KAFKA-4950) ConcurrentModificationException when iterating over Kafka Metrics

2017-05-10 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005658#comment-16005658 ] Vahid Hashemian commented on KAFKA-4950: [~dpostoronca] Thanks for providing the a

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread dan norwood (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005651#comment-16005651 ] dan norwood commented on KAFKA-5213: awesome we found a real problem. i did run this

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-10 Thread Jason Gustafson
+1 Thanks for the KIP. On Wed, May 10, 2017 at 8:55 AM, Jun Rao wrote: > Hi, Ismael, > > Thanks for the KIP. Looks good overall. A couple of minor comments. > > 1. Currently, quotas can be updated at the combination > level. So, it seems that we need to reflect that somehow in both the wire > p

Re: [VOTE] KIP-138: Change punctuate semantics

2017-05-10 Thread Guozhang Wang
+1. Thanks Michal! On Wed, May 10, 2017 at 4:35 AM, Thomas Becker wrote: > +1 > > On Wed, 2017-05-10 at 10:52 +0100, Michal Borowiecki wrote: > > Hi all, > > > > This vote thread has gone quiet. > > > > In view of the looming cut-off for 0.11.0.0 I'd like to encourage > > anyone > > who cares ab

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Jason Gustafson
Hey Colin, Thanks, I think continuing to bump the protocol makes sense. It's nice to be consistent with the other APIs. In the KIP, you have the following: > If the client is newer than the broker, some of the fields may show up as UNKNOWN on the broker side. In this case, the filter will get an

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005584#comment-16005584 ] Apurva Mehta commented on KAFKA-5213: - This also explains why it wasn't seen till now:

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005581#comment-16005581 ] ASF GitHub Bot commented on KAFKA-5213: --- GitHub user apurvam opened a pull request:

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005578#comment-16005578 ] Ismael Juma commented on KAFKA-5213: Good catch. > IllegalStateException in ensureOpe

[GitHub] kafka pull request #3015: KAFKA-5213; Mark a MemoryRecordsBuilder as full as...

2017-05-10 Thread apurvam
GitHub user apurvam opened a pull request: https://github.com/apache/kafka/pull/3015 KAFKA-5213; Mark a MemoryRecordsBuilder as full as soon as the append stream is closed You can merge this pull request into a Git repository by running: $ git pull https://github.com/apurvam/

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005575#comment-16005575 ] Apurva Mehta commented on KAFKA-5213: - The fix is to mark the builder as `full` if the

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005570#comment-16005570 ] Apurva Mehta commented on KAFKA-5213: - I found the bug. The problem is that in a parti

[jira] [Commented] (KAFKA-5182) Transient failure: RequestQuotaTest.testResponseThrottleTime

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005550#comment-16005550 ] ASF GitHub Bot commented on KAFKA-5182: --- GitHub user rajinisivaram opened a pull req

[GitHub] kafka pull request #3014: KAFKA-5182: Close txn coordinator threads during b...

2017-05-10 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3014 KAFKA-5182: Close txn coordinator threads during broker shutdown Shutdown delayed delete purgatory thread, transaction marker purgatory thread and send thread in `TransactionMarkerChannelManag

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Colin McCabe
Hi Jason, Thanks for taking a look. I think it's likely that we will bump the ApiVersion of the various requests if we add a new resource type, operation type, or permission type. Although it may not strictly be required, bumping the version number makes it a little bit clearer that the protocol

Re: [DISCUSS] KIP-133: List and Alter Configs Admin APIs

2017-05-10 Thread Ismael Juma
Hi Jason, Thanks for the feedback. I agree that it's useful and reasonably simple to implement. So, I've updated the KIP. Ismael On Wed, May 10, 2017 at 10:48 PM, Jason Gustafson wrote: > Hey Ismael, > > Thanks for the KIP. The use of the Describe API might be a little limited > if it always r

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Ismael Juma
Repeating my vote here, +1 (binding). Ismael On Wed, May 10, 2017 at 9:24 PM, Colin McCabe wrote: > Hi all, > > Some folks said that the previous VOTE thread was getting collapsed by > gmail into a different thread, so I am reposting this. > > The KIP page is here: > https://cwiki.apache.org/co

[jira] [Commented] (KAFKA-5215) Small JavaDoc fix for AdminClient#describeTopics

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005528#comment-16005528 ] ASF GitHub Bot commented on KAFKA-5215: --- GitHub user cmccabe opened a pull request:

[jira] [Created] (KAFKA-5215) Small JavaDoc fix for AdminClient#describeTopics

2017-05-10 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5215: -- Summary: Small JavaDoc fix for AdminClient#describeTopics Key: KAFKA-5215 URL: https://issues.apache.org/jira/browse/KAFKA-5215 Project: Kafka Issue Type

[GitHub] kafka pull request #3013: KAFKA-5215. Small JavaDoc fix for AdminClient#desc...

2017-05-10 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3013 KAFKA-5215. Small JavaDoc fix for AdminClient#describeTopics You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka KAFKA-5215 Alternati

[jira] [Commented] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread dan norwood (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005525#comment-16005525 ] dan norwood commented on KAFKA-5213: turns out i was running trunk client against 0.10

[GitHub] kafka pull request #3012: KAFKA-5214: KafkaAdminClient#apiVersions should re...

2017-05-10 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3012 KAFKA-5214: KafkaAdminClient#apiVersions should return a public class You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka KAFKA-5214

[jira] [Commented] (KAFKA-5214) KafkaAdminClient#apiVersions should return a public class

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005523#comment-16005523 ] ASF GitHub Bot commented on KAFKA-5214: --- GitHub user cmccabe opened a pull request:

[jira] [Created] (KAFKA-5214) KafkaAdminClient#apiVersions should return a public class

2017-05-10 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5214: -- Summary: KafkaAdminClient#apiVersions should return a public class Key: KAFKA-5214 URL: https://issues.apache.org/jira/browse/KAFKA-5214 Project: Kafka I

Re: [DISCUSS] KIP-133: List and Alter Configs Admin APIs

2017-05-10 Thread Jason Gustafson
Hey Ismael, Thanks for the KIP. The use of the Describe API might be a little limited if it always returns the full set of topics for the requested resource. I wonder if we can let the client provide a list of the configs they are interested in. Perhaps something like this: DescribeConfigs Reques

[jira] [Commented] (KAFKA-5173) SASL tests failing with Could not find a 'KafkaServer' or 'sasl_plaintext.KafkaServer' entry in the JAAS configuration

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005510#comment-16005510 ] ASF GitHub Bot commented on KAFKA-5173: --- Github user rajinisivaram closed the pull r

[GitHub] kafka pull request #3011: KAFKA-5173: Close txn coordinator threads during b...

2017-05-10 Thread rajinisivaram
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3011 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (KAFKA-5173) SASL tests failing with Could not find a 'KafkaServer' or 'sasl_plaintext.KafkaServer' entry in the JAAS configuration

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005504#comment-16005504 ] ASF GitHub Bot commented on KAFKA-5173: --- GitHub user rajinisivaram opened a pull req

[GitHub] kafka pull request #3011: KAFKA-5173: Close txn coordinator threads during b...

2017-05-10 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3011 KAFKA-5173: Close txn coordinator threads during broker shutdown Shutdown delayed delete purgatory thread, transaction marker purgatory thread and send thread in `TransactionMarkerChannelManag

[jira] [Updated] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-5213: --- Priority: Critical (was: Major) > IllegalStateException in ensureOpenForRecordAppend > --

[jira] [Updated] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-5213: --- Fix Version/s: 0.11.0.0 > IllegalStateException in ensureOpenForRecordAppend > ---

[jira] [Commented] (KAFKA-5184) Transient failure: MultipleListenersWithAdditionalJaasContextTest.testProduceConsume

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005495#comment-16005495 ] ASF GitHub Bot commented on KAFKA-5184: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread dan norwood (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dan norwood updated KAFKA-5213: --- Description: i have a streams app that was working recently while pointing at trunk. this morning i r

[GitHub] kafka pull request #3010: KAFKA-5184, KAFKA-5173; Various improvements to SA...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Created] (KAFKA-5213) IllegalStateException in ensureOpenForRecordAppend

2017-05-10 Thread dan norwood (JIRA)
dan norwood created KAFKA-5213: -- Summary: IllegalStateException in ensureOpenForRecordAppend Key: KAFKA-5213 URL: https://issues.apache.org/jira/browse/KAFKA-5213 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-5212) Consumer ListOffsets request can starve group heartbeats

2017-05-10 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-5212: --- Component/s: consumer > Consumer ListOffsets request can starve group heartbeats > ---

Re: [VOTE] KIP-146: Isolation of dependencies and classes in Kafka Connect (restarted voting thread)

2017-05-10 Thread Ismael Juma
Konstantine, I am not convinced that it will represent similar functionality as the goals are different. Also, I don't see a migration path. To use Jigsaw, it makes sense to configure the module path during start-up (-mp) like one configures the classpath. Whatever we are implementing in Connect wi

Build failed in Jenkins: kafka-trunk-jdk8 #1498

2017-05-10 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: Add a release script that helps generate release candidates. -- [...truncated 851.72 KB...] kafka.coordinator.transaction.TransactionCoordina

[jira] [Created] (KAFKA-5212) Consumer ListOffsets request can starve group heartbeats

2017-05-10 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-5212: -- Summary: Consumer ListOffsets request can starve group heartbeats Key: KAFKA-5212 URL: https://issues.apache.org/jira/browse/KAFKA-5212 Project: Kafka Is

[jira] [Commented] (KAFKA-1194) The kafka broker cannot delete the old log files after the configured time

2017-05-10 Thread Jose Alberto Gutierrez (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005392#comment-16005392 ] Jose Alberto Gutierrez commented on KAFKA-1194: --- Still a problem. Kafka : k

[GitHub] kafka pull request #2986: KAFKA-5099: Replica Deletion Regression from KIP-1...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (KAFKA-5099) Replica Deletion Regression from KIP-101

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005374#comment-16005374 ] ASF GitHub Bot commented on KAFKA-5099: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-5099) Replica Deletion Regression from KIP-101

2017-05-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-5099: --- Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 2986 [https:

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Xavier Léauté
Thank you for the feedback Michal. While I agree the return may be a little bit more confusing to reason about, the reason for doing so was to keep the range query interfaces consistent with their single-key counterparts. In the case of the window store, the "key" of the single-key iterator is th

Re: [VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Sriram Subramanian
+1 On Wed, May 10, 2017 at 1:24 PM, Colin McCabe wrote: > Hi all, > > Some folks said that the previous VOTE thread was getting collapsed by > gmail into a different thread, so I am reposting this. > > The KIP page is here: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 140%3A+Add+ad

[VOTE] KIP-140: A new thread for adding administrative RPCs for adding deleting and listing ACLs

2017-05-10 Thread Colin McCabe
Hi all, Some folks said that the previous VOTE thread was getting collapsed by gmail into a different thread, so I am reposting this. The KIP page is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-140%3A+Add+administrative+RPCs+for+adding%2C+deleting%2C+and+listing+ACLs The previous

[GitHub] kafka pull request #2795: MINOR: Add a release script that helps generate re...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2795 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: [VOTE] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-10 Thread Jason Gustafson
Hi Colin, Thanks for the KIP. Looks good overall. One thing I wasn't too clear about is whether new resource types, operations, or permissions require a version bump for the three new request types. On reading the proposal, it sort of sounds like the intent is not to bump the versions and let the

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Michal Borowiecki
Apologies, I missed the discussion (or lack thereof) about the return type of: WindowStoreIterator> fetch(K from, K to, long timeFrom, long timeTo) WindowStoreIterator (as the KIP mentions) is a subclass of KeyValueIterator KeyValueIterator has the following method: /** * Peek at the nex

[jira] [Assigned] (KAFKA-5182) Transient failure: RequestQuotaTest.testResponseThrottleTime

2017-05-10 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram reassigned KAFKA-5182: - Assignee: Rajini Sivaram > Transient failure: RequestQuotaTest.testResponseThrottleTime >

Re: [VOTE] KIP-146: Isolation of dependencies and classes in Kafka Connect (restarted voting thread)

2017-05-10 Thread Konstantine Karantasis
Thank you Ismael for your vote as well as your comment. To give some context, it's exactly because of the similarities with Jigsaw that module.path was selected initially. The thought was that it could allow for a potential integration with Jigsaw in the future, without having to change property n

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Sriram Subramanian
+1 On Wed, May 10, 2017 at 11:42 AM, Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Wed, May 10, 2017 at 2:38 PM, Guozhang Wang wrote: > > > +1. Thank you! > > > > On Wed, May 10, 2017 at 11:30 AM, Xavier Léauté > > wrote: > > > > > Hi everyone, > > > > > > Since there aren't any objections

[jira] [Created] (KAFKA-5211) KafkaConsumer should not skip a corrupted record after throwing an exception.

2017-05-10 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-5211: --- Summary: KafkaConsumer should not skip a corrupted record after throwing an exception. Key: KAFKA-5211 URL: https://issues.apache.org/jira/browse/KAFKA-5211 Project: Ka

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Bill Bejeck
+1 Thanks, Bill On Wed, May 10, 2017 at 2:38 PM, Guozhang Wang wrote: > +1. Thank you! > > On Wed, May 10, 2017 at 11:30 AM, Xavier Léauté > wrote: > > > Hi everyone, > > > > Since there aren't any objections to this addition, I would like to start > > the voting on KIP-155 so we can hopefully

Re: [VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Guozhang Wang
+1. Thank you! On Wed, May 10, 2017 at 11:30 AM, Xavier Léauté wrote: > Hi everyone, > > Since there aren't any objections to this addition, I would like to start > the voting on KIP-155 so we can hopefully get this into 0.11. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+ > 155+-+Ad

Re: [VOTE] KIP-151: Expose Connector type in REST API (first attempt :)

2017-05-10 Thread Guozhang Wang
+1 On Wed, May 10, 2017 at 10:27 AM, Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Mon, May 8, 2017 at 11:39 PM, dan wrote: > > > i'd like to begin voting on > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 151+Expose+Connector+type+in+REST+API > > > > d

[VOTE] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Xavier Léauté
Hi everyone, Since there aren't any objections to this addition, I would like to start the voting on KIP-155 so we can hopefully get this into 0.11. https://cwiki.apache.org/confluence/display/KAFKA/KIP+155+-+Add+range+scan+for+windowed+state+stores Voting will stay active for at least 72 hours.

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Guozhang Wang
Sounds great, thanks! On Wed, May 10, 2017 at 10:43 AM, Xavier Léauté wrote: > I'll be driving the implementation as well. Unless there are specific > concerns about the implementation, I mainly wrote the KIP to agree on the > additional public interfaces. > > Current window store fetch operatio

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Xavier Léauté
I'll be driving the implementation as well. Unless there are specific concerns about the implementation, I mainly wrote the KIP to agree on the additional public interfaces. Current window store fetch operations already rely on range scanning & filtering the relevant keys in the underlying state s

Re: [VOTE] KIP-151: Expose Connector type in REST API (first attempt :)

2017-05-10 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Mon, May 8, 2017 at 11:39 PM, dan wrote: > i'd like to begin voting on > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 151+Expose+Connector+type+in+REST+API > > discussion should remain on > http://mail-archives.apache.org/mod_mbox/kafka-de

Re: [VOTE] KIP-151: Expose Connector type in REST API (first attempt :)

2017-05-10 Thread Sriram Subramanian
+1 On Wed, May 10, 2017 at 10:20 AM, Ewen Cheslack-Postava wrote: > +1 binding > > Thanks, > Ewen > > On Mon, May 8, 2017 at 4:54 PM, BigData dev > wrote: > > > +1 (non-binding) > > > > Thanks, > > Bharat > > > > > > On Mon, May 8, 2017 at 4:39 PM, Konstantine Karantasis < > > konstant...@confl

Re: [VOTE] KIP-146: Isolation of dependencies and classes in Kafka Connect (restarted voting thread)

2017-05-10 Thread Ewen Cheslack-Postava
+1 binding, and I'm flexible on the config name. Somehow I am guessing no matter what terminology we use there somebody will find a way to be confused. -Ewen On Wed, May 10, 2017 at 9:27 AM, Gwen Shapira wrote: > +1 and proposing 'plugin.path' as we use the term connector plugins when > referri

Re: [VOTE] KIP-154 Add Kafka Connect configuration properties for creating internal topics

2017-05-10 Thread Ewen Cheslack-Postava
+1 binding -Ewen On Wed, May 10, 2017 at 9:34 AM, Gwen Shapira wrote: > +1 > Thanks for doing this, Randall. It will be a huge usability improvement. > > On Mon, May 8, 2017 at 8:43 PM BigData dev > wrote: > > > +1 (non-binding) > > > > On Mon, May 8, 2017 at 3:25 PM, Dongjin Lee wrote: > > >

Re: [VOTE] KIP-151: Expose Connector type in REST API (first attempt :)

2017-05-10 Thread Ewen Cheslack-Postava
+1 binding Thanks, Ewen On Mon, May 8, 2017 at 4:54 PM, BigData dev wrote: > +1 (non-binding) > > Thanks, > Bharat > > > On Mon, May 8, 2017 at 4:39 PM, Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > +1 (non-binding) > > > > On Mon, May 8, 2017 at 3:39 PM, dan wrote: > > > >

Re: [VOTE] KIP-156 Add option "dry run" to Streams application reset tool

2017-05-10 Thread BigData dev
Thanks everyone for voting. KIP-156 has passed with +4 binding (Neha, Jay Kreps, Sriram Subramanian and Gwen Shapira) and +3 non-binding (Eno Thereska, Matthias J. Sax and Bill Bejeck) Thanks, Bharat Viswanadham On Wed, May 10, 2017 at 9:46 AM, Sriram Subramanian wrote: > +1 > > On Wed, May 1

  1   2   >