[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

2017-09-12 Thread original-brownbear
Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2901 ---

[GitHub] kafka pull request #2889: KAFKA-4928: Add integration test for DumpLogSegmen...

2017-09-12 Thread original-brownbear
Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2889 ---

[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

2017-09-12 Thread original-brownbear
Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2903 ---

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-12 Thread Damian Guy
Hi All, A minor update to the KIP, i needed to add KTable.to(Produced) for consistency. KTable.through will be deprecated in favour of using KTable.toStream().through() Thanks, Damian On Thu, 7 Sep 2017 at 08:52 Damian Guy wrote: > Thanks all. The vote is now closed and the KIP has been accept

[GitHub] kafka pull request #3828: MINOR: update processor topology test driver

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3828 ---

[GitHub] kafka pull request #3833: MINOR: refactor build method to extract methods fr...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3833 ---

[jira] [Created] (KAFKA-5872) Transient failure in SslSelectorTest.testMuteOnOOM

2017-09-12 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-5872: - Summary: Transient failure in SslSelectorTest.testMuteOnOOM Key: KAFKA-5872 URL: https://issues.apache.org/jira/browse/KAFKA-5872 Project: Kafka Issue Type

[GitHub] kafka pull request #3836: KAFKA-5872: Fix transient failure in SslSelectorTe...

2017-09-12 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3836 KAFKA-5872: Fix transient failure in SslSelectorTest.testMuteOnOOM You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KA

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-12 Thread Tom Bentley
2. About using the create topics policy, I'm not sure. Aside from the > naming issue, there's also the problem that the policy doesn't know if a > creation or update is taking place. This matters because one may not want > to allow the number of partitions to be changed after creation as it > affec

Build failed in Jenkins: kafka-trunk-jdk8 #2008

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: update processor topology test driver -- [...truncated 2.52 MB...] org.apache.kafka.streams.integration.RegexSourceIntegrationTest > test

Build failed in Jenkins: kafka-trunk-jdk7 #2748

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: update processor topology test driver -- [...truncated 2.51 MB...] org.apache.kafka.streams.integration.KTableKTableJoinIntegrationTest >

[jira] [Created] (KAFKA-5873) Add Materialized overloads to StreamBuilder

2017-09-12 Thread Damian Guy (JIRA)
Damian Guy created KAFKA-5873: - Summary: Add Materialized overloads to StreamBuilder Key: KAFKA-5873 URL: https://issues.apache.org/jira/browse/KAFKA-5873 Project: Kafka Issue Type: Sub-task

Build failed in Jenkins: kafka-trunk-jdk8 #2009

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: refactor build method to extract methods from if statements -- [...truncated 2.03 MB...] org.apache.kafka.common.security.ssl.SslFactoryT

[jira] [Created] (KAFKA-5874) Incorrect command line handling

2017-09-12 Thread Viliam Durina (JIRA)
Viliam Durina created KAFKA-5874: Summary: Incorrect command line handling Key: KAFKA-5874 URL: https://issues.apache.org/jira/browse/KAFKA-5874 Project: Kafka Issue Type: Bug Compo

Re: [VOTE] 0.11.0.1 RC0

2017-09-12 Thread Ismael Juma
Hi Damian, Thanks for managing the release. This may just be the first ever RC0 to be promoted to final. :) +1 (binding) from me. I verified some signatures/hashes, verified quickstart on binary Scala 2.12 artifact, ran tests and broker quickstart on the source artifact. Ismael On Tue, Sep 5, 20

Build failed in Jenkins: kafka-trunk-jdk7 #2749

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: refactor build method to extract methods from if statements -- [...truncated 2.51 MB...] org.apache.kafka.streams.KafkaStreamsTest > shou

[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

2017-09-12 Thread original-brownbear
GitHub user original-brownbear reopened a pull request: https://github.com/apache/kafka/pull/2903 MINOR: Fix needless GC + Result time unit in JMH Fixes two issues with the JMH benchmark example: * Trivial: The output should be in `ops/ms` for readability reasons (it's in the mi

Re: [VOTE] 0.11.0.1 RC0

2017-09-12 Thread Manikumar
+1 (non-binding) , verified artifacts, quick start using binary and ran tests on source artifact. Thanks for running the release. On Tue, Sep 12, 2017 at 4:30 PM, Ismael Juma wrote: > Hi Damian, > > Thanks for managing the release. This may just be the first ever RC0 to be > promoted to final.

Re: [VOTE] 0.11.0.1 RC0

2017-09-12 Thread Thomas Crayford
Heroku has vetted this through our typical performance and regression testing, and everything looks good. +1 (non-binding) from us. On Tue, Sep 5, 2017 at 9:34 PM, Damian Guy wrote: > Hello Kafka users, developers and client-developers, > > This is the first candidate for release of Apache Kafka

Re: [VOTE] 0.11.0.1 RC0

2017-09-12 Thread Damian Guy
Thanks all the vote has now closed and the release has been accepted. I'll post an announcement to the dev list shortly. On Tue, 12 Sep 2017 at 13:14 Thomas Crayford wrote: > Heroku has vetted this through our typical performance and regression > testing, and everything looks good. +1 (non-bindi

[RESULTS] [VOTE] Release Kafka version 0.11.0.1

2017-09-12 Thread Damian Guy
This vote passes with 6 +1 votes (3 bindings) and no 0 or -1 votes. +1 votes PMC Members: * Jun Rao * Gouzhang Wang * Ismael Juma Community: * Manikumar Reddy * Thomas Crawford * Magnus Edenhill 0 votes * No votes -1 votes * No votes Vote threads (two as some votes were on user list only):ht

[jira] [Resolved] (KAFKA-1630) ConsumerFetcherThread locked in Tomcat

2017-09-12 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1630. -- Resolution: Cannot Reproduce Closing inactive issue. Please reopen if you think the issue still exists

[jira] [Resolved] (KAFKA-1834) No Response when handle LeaderAndIsrRequest some case

2017-09-12 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1834. -- Resolution: Fixed This was fixed in newer Kafka versions. > No Response when handle LeaderAndIsrRequest

[jira] [Resolved] (KAFKA-5861) KStream close( withTimeout ) - does not work under load conditions in the multi-threaded KStream application

2017-09-12 Thread Seweryn Habdank-Wojewodzki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seweryn Habdank-Wojewodzki resolved KAFKA-5861. --- Resolution: Workaround > KStream close( withTimeout ) - does not work

Jenkins build is back to normal : kafka-0.11.0-jdk7 #305

2017-09-12 Thread Apache Jenkins Server
See

[GitHub] kafka pull request #3826: KAFKA:5653: add join overloads to KTable

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3826 ---

[jira] [Created] (KAFKA-5875) Consumer group repeatedly fails to join, even across JVM restarts: BufferUnderFlowException reading the {{version}} field in the consumer protocol header

2017-09-12 Thread Evan Pollan (JIRA)
Evan Pollan created KAFKA-5875: -- Summary: Consumer group repeatedly fails to join, even across JVM restarts: BufferUnderFlowException reading the {{version}} field in the consumer protocol header Key: KAFKA-5875 URL

Reg: Read External API response Producer

2017-09-12 Thread Mohan, Prithiv
Hi, I am investigating Kafka as a message bus service for my MANO Monitoring module. I have a python producer that will take the message from a file and will put it in the message bus in json format. I have a consumer that reads the message and does some operation in the external OpenStack API.

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-12 Thread Ismael Juma
Hi Tom, OK, I suggest not calling any policy then. We can do a separate KIP for overhauling topic policies so that they work with all operations for 1.1.0. Regarding the loophole issue, keep in mind that the alter topics authorization would still be required, so I don't think it's an issue. Users

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Roger Hoover
Randall/Ewen, I think the timing info is still useful even if it's measured since the last rebalance. How else do you know where time is being spent? The use case for seeing the batch size is that you generally have two knobs to configure - max batch size and max wait time. The batch size metri

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-12 Thread Tom Bentley
Hi Ismael, Thanks for your comments. Regarding the loophole issue, keep in mind that the alter topics > authorization would still be required, so I don't think it's an issue > It could be an issue for people trying to provide a Kafka-as-a-Service offering, couldn't it? I mean if the providers ar

Build failed in Jenkins: kafka-trunk-jdk8 #2010

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA:5653: add join overloads to KTable -- [...truncated 2.52 MB...] org.apache.kafka.streams.integration.RegexSourceIntegrationTest > testRege

Build failed in Jenkins: kafka-trunk-jdk7 #2750

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA:5653: add join overloads to KTable -- [...truncated 2.51 MB...] org.apache.kafka.streams.integration.QueryableStateIntegrationTest > shoul

[jira] [Resolved] (KAFKA-5655) Add new API methods to KGroupedTable

2017-09-12 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-5655. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 3829 [https://github.com/

[GitHub] kafka pull request #3829: KAFKA-5655: materialized count, aggregate, reduce ...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3829 ---

[GitHub] kafka pull request #3837: KAFKA-5873: add materialized overloads to StreamsB...

2017-09-12 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3837 KAFKA-5873: add materialized overloads to StreamsBuilder Add overloads for `table` and `globalTable` that use `Materialized` You can merge this pull request into a Git repository by running: $ git

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Tom Bentley
Following additional comments from Ismael I have updated the KIP slightly to: * No longer apply the CreateTopicPolicy (a future KIP will address applying a policy to topic changes) * Clarify that the request must be sent to the controller and the response will only be sent once the changes are ref

[jira] [Resolved] (KAFKA-5872) Transient failure in SslSelectorTest.testMuteOnOOM

2017-09-12 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-5872. --- Resolution: Fixed Issue resolved by pull request 3836 [https://github.com/apache/kafka/pull/38

[GitHub] kafka pull request #3836: KAFKA-5872: Fix transient failure in SslSelectorTe...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3836 ---

Re: [VOTE] KIP-199: Add Kafka Connect Offset Tool

2017-09-12 Thread Randall Hauch
I'm actually going to withdraw this vote. Recent discussion has made apparent there are a few issues still to be worked out, and the proposal is not complete. Apologies. Best regards, Randall On Mon, Sep 11, 2017 at 8:42 PM, Sriram Subramanian wrote: > +1 > > On Mon, Sep 11, 2017 at 2:56 PM, G

[jira] [Created] (KAFKA-5876) IQ should throw different exceptions for different errors

2017-09-12 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5876: -- Summary: IQ should throw different exceptions for different errors Key: KAFKA-5876 URL: https://issues.apache.org/jira/browse/KAFKA-5876 Project: Kafka I

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Jun Rao
Hi, Tom, Thanks for the KIP. +1. Just a couple of minor comments below. 1. The KIP has "INVALID_PARTITIONS (37) If the partition count was <= the current partition count for the topic." We probably want to add one more constraint: # of replicas in each new partition has to be the same as the exi

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-12 Thread Guozhang Wang
Hi Damian, Why we are deprecating KTable.through while keeping KTable.to? Should we either keep both of them or deprecate both of them in favor or KTable.toStream if people agree that it is confusing to users? Guozhang On Tue, Sep 12, 2017 at 1:18 AM, Damian Guy wrote: > Hi All, > > A minor

Build failed in Jenkins: kafka-trunk-jdk7 #2751

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5655; materialized count, aggregate, reduce to KGroupedTable -- [...truncated 2.03 MB...] org.apache.kafka.common.ClusterTest > testBootst

Build failed in Jenkins: kafka-trunk-jdk8 #2011

2017-09-12 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5655; materialized count, aggregate, reduce to KGroupedTable -- [...truncated 2.53 MB...] org.apache.kafka.streams.integration.RegexSourceI

Re: [DISCUSS] KIP-199: Add Kafka Connect offset reset tool

2017-09-12 Thread Randall Hauch
Thanks for the comments. As mentioned in the VOTE thread, I've withdrawn the vote since this proposal is obviously incomplete. I have updated the KIP with your comments, and will discuss each inline below: On Mon, Sep 11, 2017 at 11:30 PM, Ewen Cheslack-Postava wrote: > A couple of comments: > >

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
Hi, James. I was mistaken about how the Kafka metrics are converted to MBeans and attributes. The MBean is constructed from the group and tags, and the metrics show up as attributes on the MBean. I'll update the KIP to reflect this. On Tue, Sep 12, 2017 at 1:43 AM, James Cheng wrote: > Thanks fo

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Tom Bentley
Hi Jun, Thanks for the comments. On 12 September 2017 at 18:15, Jun Rao wrote: > Hi, Tom, > > Thanks for the KIP. +1. Just a couple of minor comments below. > > 1. The KIP has "INVALID_PARTITIONS (37) If the partition count was <= the > current partition count for the topic." We probably want

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
On Tue, Sep 12, 2017 at 10:36 AM, Roger Hoover wrote: > Randall/Ewen, > > I think the timing info is still useful even if it's measured since the > last rebalance. How else do you know where time is being spent? > I think Ewen's concern (correct me if I'm wrong) is that measuring time-based met

[GitHub] kafka pull request #3838: [KAFKA-1194 Invokes unmap if on Windows OS]

2017-09-12 Thread manmedia
GitHub user manmedia opened a pull request: https://github.com/apache/kafka/pull/3838 [KAFKA-1194 Invokes unmap if on Windows OS] If on Windows OS, forces unmapping of mmap so that segment suffixes can be changed. You can merge this pull request into a Git repository by running:

Re: [DISCUSS] KIP-199: Add Kafka Connect offset reset tool

2017-09-12 Thread Gwen Shapira
> > > > * re: naming, can we avoid including 'source' in the command name? even > if > > that's all it supports today, I don't think we want to restrict it. While > > we only *require* this for source offsets, I think for users it will, > > long-term, be way more natural to consider connect offsets

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Gwen Shapira
Ewen, you gave a nice talk at Kafka Summit where you warned about the danger of SMTs that slow down the data pipe. If we don't provide the time metrics, how will users know when their SMTs are causing performance issues? Gwen On Mon, Sep 11, 2017 at 7:50 PM Ewen Cheslack-Postava wrote: > re: qu

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-12 Thread Gwen Shapira
+1 (binding) On Mon, Sep 11, 2017 at 8:25 PM Ewen Cheslack-Postava wrote: > +1 binding. > > Thanks for the contribution Ted! Simple addition, but makes the API > significantly more usable. > > -Ewen > > On Fri, Sep 8, 2017 at 7:46 PM, Sriram Subramanian > wrote: > > > +1 > > > > On Fri, Sep 8,

Re: [VOTE] KIP-131 - Add access to OffsetStorageReader from SourceConnector

2017-09-12 Thread Gwen Shapira
Thanks for clarifying. +1 again :) On Sat, Sep 9, 2017 at 6:57 AM Randall Hauch wrote: > Gwen, > > I've had more time to look into the code. First, the OffsetStorageReader > JavaDoc says: "OffsetStorageReader provides access to the offset storage > used by sources. This can be used by connect

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-12 Thread Ted Yu
Ismael had a vote on the DISCUSS thread: http://search-hadoop.com/m/Kafka/uyzND18F2Bu15PQaW1?subj=Re+DISCUSS+KIP+197+Include+Connector+type+in+Connector+REST+API On Tue, Sep 12, 2017 at 11:14 AM, Gwen Shapira wrote: > +1 (binding) > > On Mon, Sep 11, 2017 at 8:25 PM Ewen Cheslack-Postava > wro

Re: [DISCUSS] KIP-190: Handle client-ids consistently between clients and brokers

2017-09-12 Thread Gwen Shapira
If I understand you correctly, you are saying: 1. KIP-190 will not affect anyone who doesn't use special characters in their client IDs 2. Those who have special characters in client IDs already have tons of metrics issues and won't be inconvenienced by a KIP that fixes them. Did I get it right?

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-12 Thread Gwen Shapira
Yes. I think you can close the vote (3 days passed and you have 4 binding votes). Gwen On Tue, Sep 12, 2017 at 11:21 AM Ted Yu wrote: > Ismael had a vote on the DISCUSS thread: > > > http://search-hadoop.com/m/Kafka/uyzND18F2Bu15PQaW1?subj=Re+DISCUSS+KIP+197+Include+Connector+type+in+Connector+

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-12 Thread Ted Yu
I was waiting for the end of day since there were two days across the weekend. Thanks for your reminder. On Tue, Sep 12, 2017 at 11:23 AM, Gwen Shapira wrote: > Yes. I think you can close the vote (3 days passed and you have 4 binding > votes). > > Gwen > > On Tue, Sep 12, 2017 at 11:21 AM Ted

Build failed in Jenkins: kafka-trunk-jdk8 #2012

2017-09-12 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-5872; Fix transient failure in SslSelectorTest.testMuteOnOOM -- [...truncated 2.53 MB...] org.apache.kafka.streams.integration.RegexSo

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
Okay, I think I've incorporated all feedback except for Gwen and Roger than would like to have timing metrics. Given the deadline and Ewen's concern about degraded performance, I think it's prudent to leave those out of this KIP and proceed as is. On Tue, Sep 12, 2017 at 12:48 PM, Randall Hauch

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-12 Thread Matthias J. Sax
+1 Thanks for voting. I am closing this as accepted with 3 binding votes (Guozhang, Sriram, Damian) 2 non-binding votes (Bill, Matthias) -Matthias On 9/9/17 2:12 AM, Damian Guy wrote: > +1 > On Sat, 9 Sep 2017 at 03:46, Sriram Subramanian wrote: > >> +1 >> >> On Fri, Sep 8, 2017 at 3:04 PM

Build failed in Jenkins: kafka-trunk-jdk7 #2752

2017-09-12 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-5872; Fix transient failure in SslSelectorTest.testMuteOnOOM -- [...truncated 2.51 MB...] org.apache.kafka.streams.KafkaStreamsTest >

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Jun Rao
Hi, Tom, 2. Thanks for the explanation. That makes sense and we can leave this as it is. Jun On Tue, Sep 12, 2017 at 10:46 AM, Tom Bentley wrote: > Hi Jun, > > Thanks for the comments. > > On 12 September 2017 at 18:15, Jun Rao wrote: > > > Hi, Tom, > > > > Thanks for the KIP. +1. Just a cou

[jira] [Resolved] (KAFKA-5621) The producer should retry expired batches when retries are enabled

2017-09-12 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apurva Mehta resolved KAFKA-5621. - Resolution: Won't Fix > The producer should retry expired batches when retries are enabled > -

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
The KIP was modified (most changes due to reorganization of metrics). Feel free to re-vote if you dislike the changes. On Mon, Sep 11, 2017 at 8:40 PM, Sriram Subramanian wrote: > +1 > > On Mon, Sep 11, 2017 at 2:56 PM, Gwen Shapira wrote: > > > +1 > > > > Thanks for this. Can't wait for more c

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Gwen Shapira
My +1 remains :) On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > The KIP was modified (most changes due to reorganization of metrics). Feel > free to re-vote if you dislike the changes. > > On Mon, Sep 11, 2017 at 8:40 PM, Sriram Subramanian > wrote: > > > +1 > > > > On Mon, Sep 11, 201

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Sriram Subramanian
+1 On Tue, Sep 12, 2017 at 12:41 PM, Gwen Shapira wrote: > My +1 remains :) > > On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > > > The KIP was modified (most changes due to reorganization of metrics). > Feel > > free to re-vote if you dislike the changes. > > > > On Mon, Sep 11, 2017 a

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Jason Gustafson
+1. Thanks for the KIP. On Tue, Sep 12, 2017 at 12:42 PM, Sriram Subramanian wrote: > +1 > > On Tue, Sep 12, 2017 at 12:41 PM, Gwen Shapira wrote: > > > My +1 remains :) > > > > On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > > > > > The KIP was modified (most changes due to reorganiza

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Ewen Cheslack-Postava
On Tue, Sep 12, 2017 at 10:55 AM, Gwen Shapira wrote: > Ewen, you gave a nice talk at Kafka Summit where you warned about the > danger of SMTs that slow down the data pipe. If we don't provide the time > metrics, how will users know when their SMTs are causing performance > issues? > Metrics are

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Roger Hoover
Ewen, I don't know the details of the perf concern. How is it that the Kafka broker can keep latency stats per request without suffering too much performance? Maybe SMTs are the only concern b/c they are per-message. If so, let's remove those and keep timing info for everything else like flushe

[jira] [Created] (KAFKA-5877) Controller should only update reassignment znode if there is change in the reassignment data

2017-09-12 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5877: --- Summary: Controller should only update reassignment znode if there is change in the reassignment data Key: KAFKA-5877 URL: https://issues.apache.org/jira/browse/KAFKA-5877 Proj

[GitHub] kafka pull request #3839: KAFKA-5877; Controller should only update reassign...

2017-09-12 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3839 KAFKA-5877; Controller should only update reassignment znode if there is change in the reassignment data You can merge this pull request into a Git repository by running: $ git pull https:/

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Ewen Cheslack-Postava
Requests are generally substantial batches of data, you are not guaranteed that for the processing batches both because source connectors can hand you batches of whatever size they want and consumer's max.poll.records can be overridden. Both SMTs and converters are a concern because they can both

[jira] [Created] (KAFKA-5878) Add sensor for queue size of the controller-event-thread

2017-09-12 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5878: --- Summary: Add sensor for queue size of the controller-event-thread Key: KAFKA-5878 URL: https://issues.apache.org/jira/browse/KAFKA-5878 Project: Kafka Issue Type: Bug

[GitHub] kafka pull request #3745: [KAFKA-4468] Correctly calculate the window end ti...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3745 ---

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
Regarding the existing rebalance metrics under "kafka.connect:type=connect-coordinator-metrics", I think we should just plan on reusing them rather than duplicating them. On Tue, Sep 12, 2017 at 5:06 PM, Ewen Cheslack-Postava wrote: > Requests are generally substantial batches of data, you are n

[jira] [Created] (KAFKA-5879) Controller should read the latest IsrChangeNotification znodes when handling IsrChangeNotification event

2017-09-12 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5879: --- Summary: Controller should read the latest IsrChangeNotification znodes when handling IsrChangeNotification event Key: KAFKA-5879 URL: https://issues.apache.org/jira/browse/KAFKA-5879

[GitHub] kafka pull request #3840: KAFKA-5879; Controller should read the latest IsrC...

2017-09-12 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3840 KAFKA-5879; Controller should read the latest IsrChangeNotification znodes when handling IsrChangeNotification event … You can merge this pull request into a Git repository by running: $ g

Build failed in Jenkins: kafka-trunk-jdk7 #2753

2017-09-12 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-4468: Correctly calculate the window end timestamp after read from -- [...truncated 2.51 MB...] org.apache.kafka.streams.integration.KTableK

Build failed in Jenkins: kafka-trunk-jdk8 #2013

2017-09-12 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-4468: Correctly calculate the window end timestamp after read from -- [...truncated 2.53 MB...] org.apache.kafka.streams.integration.RegexS

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Roger Hoover
Thanks, Ewen. I agree with you on the overhead of measuring time for SMTs and converters. I'd still argue for keeping other metrics like flush time b/c even small batches should still be small overhead compared to writing to a sink. On Tue, Sep 12, 2017 at 3:06 PM, Ewen Cheslack-Postava wrote:

Re: [DISCUSS] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Sriram Subramanian
FWIW, I agree that time metrics have been very useful in the past. The reasoning around perf overhead seems reasonable as well. Can we agree on a subset of time metrics that we feel would be super useful for debugging? On Tue, Sep 12, 2017 at 6:08 PM, Roger Hoover wrote: > Thanks, Ewen. > > I ag

[GitHub] kafka pull request #3841: KAFKA-5833: Reset thread interrupt state in case o...

2017-09-12 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/3841 KAFKA-5833: Reset thread interrupt state in case of InterruptedException You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka kafka-5833-in

[jira] [Resolved] (KAFKA-2887) TopicMetadataRequest creates topic if it does not exist

2017-09-12 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-2887. -- Resolution: Fixed > TopicMetadataRequest creates topic if it does not exist > --

Re: [DISCUSS] KIP-199: Add Kafka Connect offset reset tool

2017-09-12 Thread Ewen Cheslack-Postava
I don't think it's bikeshedding and it is a fair question. I try to avoid that because this is part of the point of KIPs -- avoid extra pain around usability, documentation, maintenance, and compatibility and deprecation by just trying to get things right on the first go around. It's obviously jus

[GitHub] kafka pull request #3842: [Kafka-5301] Improve exception handling on consume...

2017-09-12 Thread ConcurrencyPractitioner
GitHub user ConcurrencyPractitioner opened a pull request: https://github.com/apache/kafka/pull/3842 [Kafka-5301] Improve exception handling on consumer path This is an improvised approach towards fixing @guozhangwang 's second issue. I have changed the method return type as we

[jira] [Created] (KAFKA-5880) Transactional producer and read committed consumer causes consumer to stuck

2017-09-12 Thread Lae (JIRA)
Lae created KAFKA-5880: -- Summary: Transactional producer and read committed consumer causes consumer to stuck Key: KAFKA-5880 URL: https://issues.apache.org/jira/browse/KAFKA-5880 Project: Kafka Issue

Re: [DISCUSS] KIP-199: Add Kafka Connect offset reset tool

2017-09-12 Thread Gwen Shapira
Totally agree about getting things right in the first round. In addition, I believe that it is important that names of our tools will describe what the tools do as accurately as possible - this improves usability. Therefore, we should shift the discussion to whether the tool should handle all offse

[jira] [Created] (KAFKA-5881) Consuming from added partitions without restarting the consumer

2017-09-12 Thread Viliam Durina (JIRA)
Viliam Durina created KAFKA-5881: Summary: Consuming from added partitions without restarting the consumer Key: KAFKA-5881 URL: https://issues.apache.org/jira/browse/KAFKA-5881 Project: Kafka

[jira] [Created] (KAFKA-5882) NullPointerException in ConsumerCoordinator

2017-09-12 Thread Seweryn Habdank-Wojewodzki (JIRA)
Seweryn Habdank-Wojewodzki created KAFKA-5882: - Summary: NullPointerException in ConsumerCoordinator Key: KAFKA-5882 URL: https://issues.apache.org/jira/browse/KAFKA-5882 Project: Kafka