GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/3884
MINOR: various random minor fixes and improve KafkaConsumer JavaDocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka
minor-fixed-disc
Thanks !
Vito
On Mon, Sep 18, 2017 at 7:26 AM, Guozhang Wang wrote:
> It's done. Cheers.
>
>
> Guozhang
>
> On Sat, Sep 16, 2017 at 4:52 PM, 鄭紹志 wrote:
>
> > My id: vitojeng
> >
> > Thanks, Guozhang.
> >
> >
> > Vito
> >
> >
> > On Sat, Sep 16, 2017 at 11:39 AM, Guozhang Wang
> > wrote:
> >
It's done. Cheers.
Guozhang
On Sat, Sep 16, 2017 at 4:52 PM, 鄭紹志 wrote:
> My id: vitojeng
>
> Thanks, Guozhang.
>
>
> Vito
>
>
> On Sat, Sep 16, 2017 at 11:39 AM, Guozhang Wang
> wrote:
>
> > What's your apache id?
> >
> > On Sat, Sep 16, 2017 at 8:24 AM, 鄭紹志 wrote:
> >
> > > I want to work
GitHub user ConcurrencyPractitioner reopened a pull request:
https://github.com/apache/kafka/pull/3880
KAFKA-5765 Move merge() from StreamsBuilder to KStream
I have defined a {{merge()}} method to KStream.
KStreamImpl overrides the {{merge()}} method.
You can merge this pull re
Hi,
I would like to try to start contributing to the Kafka project, look at
some JIRAs and maybe raise some KIPs.
Could you please give me the JIRA rights to pick up some issues and the
rights to raise KIPs in Confluence Wiki? My username is scholzj for both
JIRA and Confluence.
Thanks & Regards
GitHub user scholzj opened a pull request:
https://github.com/apache/kafka/pull/3883
KAFKA-5918: Fix minor typos and errors in the Kafka Streams turotial
I found several minor issues with the Kafka Streams tutorial:
* Some typos
* "As shown above, it illustrate that the con
Jakub Scholz created KAFKA-5918:
---
Summary: Fix minor typos and errors in the Kafka Streams turotial
Key: KAFKA-5918
URL: https://issues.apache.org/jira/browse/KAFKA-5918
Project: Kafka
Issue Ty
Thanks for updating the KIP.
You are of course right, that we internally need access to
InternalStreamBuilder, but that should not be too hard and effectively
be an internal implementation detail.
Two more comments:
the new method should be
> KStream merge(KStream stream);
and not
> KStream
GitHub user 56quarters reopened a pull request:
https://github.com/apache/kafka/pull/3876
KAFKA-5896: Force Connect tasks to stop via thread interruption
Interrupt the thread of Kafka Connect tasks that do not stop within
the timeout via `Worker::stopAndAwaitTasks()`. Previously
Github user 56quarters closed the pull request at:
https://github.com/apache/kafka/pull/3876
---
Correction: When the current merge() method is called with multiple
streams, a warning will be printed (or logged), but this should not hinder
ability to read the log.
There is a missing unchecked warning suppression for the old method.
However, it is not high priority due to deprecation of the old
With regards to Xavier's comment, this practice I do no think applies to
this PR. There is not much potential here for warnings to be thrown. Note
that in StreamsBuilder's merge, their is no
@SuppressWarnings("unchecked")--indicating that warnings is sparse, if not
nonexistent.
On Sun, Sep 17, 20
GitHub user rajinisivaram opened a pull request:
https://github.com/apache/kafka/pull/3882
MINOR: Add metric templates for sender/fetcher rate totals
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajinisivaram/kafka
MINOR-KAFK
KIP-202 has been changed according to the conditions of your suggestion.
On Sun, Sep 17, 2017 at 8:51 AM, Richard Yu
wrote:
> I added StreamsBuilder under the assumption that InternalStreamBuilder
> would be required to merge
> two streams. However, if that is not the case, then I would still ne
Github user ConcurrencyPractitioner closed the pull request at:
https://github.com/apache/kafka/pull/3880
---
I added StreamsBuilder under the assumption that InternalStreamBuilder
would be required to merge
two streams. However, if that is not the case, then I would still need a
couple of things:
1) An InternalStreamBuilder instance to instantiate a new KStream
2) The merge_name that the merged streams
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3881
MINOR: Update powermock and enable its tests when running with Java 9
Also fix WorkerTest to use the correct `Mock` annotations.
`org.easymock.Mock`
is not supported by PowerMock 2.x.
You can mer
Hi Richard,
Thanks a lot for the KIP!
I have three question:
- why is the new merge() method static?
- why does the new merge() method take StreamsBuilder as a parameter?
- did you think about Xavier's comment (see the JIRA in case you did
not notice it yet) about varargs vs adding some overlo
18 matches
Mail list logo
