Re: [DISCUSS] KIP-209 Connection String Support

2017-10-24 Thread Michael André Pearce
Fair enough on URL encoding but as mentioned it is important to be able to escape, I agree with backslash option. I would still like some form of prefix to the string to denote it is for kafka. E.g. kafka:: (if semicolon separators) Sent from my iPad > On 24 Oct 2017, at 17:27, Colin McCabe

[GitHub] kafka pull request #4130: HOTFIX: Remove sysout logging

2017-10-24 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4130 HOTFIX: Remove sysout logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-0110-remove-logging Alternatively

[GitHub] kafka pull request #4129: KAFKA-6115: TaskManager should be type aware

2017-10-24 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/4129 KAFKA-6115: TaskManager should be type aware - remove type specific methods from Task interface - add generics to preserve task type - add sub classes for different task types You can merge

Re: [DISCUSS] KIP-205: Add getAllKeys() API to ReadOnlyWindowStore

2017-10-24 Thread Richard Yu
I think we can come up with this compromise: range(long timeFrom, long timeTo) will be changed to getKeys(long timeFrom, long timeTo). Sounds fair? On Tue, Oct 24, 2017 at 10:44 AM, Xavier Léauté wrote: > > > > Generally I think having `all / range` is better in terms of consistency > > with ke

[jira] [Resolved] (KAFKA-6116) Major performance issue due to excessive logging during leader election

2017-10-24 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-6116. Resolution: Fixed Fixed in 0.11.0, 1.0 and trunk. Commit for 0.11.0: https://github.com/apache/kafk

[jira] [Created] (KAFKA-6116) Major performance issue due to excessive logging during leader election

2017-10-24 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-6116: -- Summary: Major performance issue due to excessive logging during leader election Key: KAFKA-6116 URL: https://issues.apache.org/jira/browse/KAFKA-6116 Project: Kafka

[jira] [Created] (KAFKA-6115) TaskManager should be type aware

2017-10-24 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-6115: -- Summary: TaskManager should be type aware Key: KAFKA-6115 URL: https://issues.apache.org/jira/browse/KAFKA-6115 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-6114) kafka Java API Consumer and producer Offset value comparison?

2017-10-24 Thread veerendra nath jasthi (JIRA)
veerendra nath jasthi created KAFKA-6114: Summary: kafka Java API Consumer and producer Offset value comparison? Key: KAFKA-6114 URL: https://issues.apache.org/jira/browse/KAFKA-6114 Project:

[jira] [Created] (KAFKA-6113) broker failure leads to under replicated partitions

2017-10-24 Thread Takao Kobayashi (JIRA)
Takao Kobayashi created KAFKA-6113: -- Summary: broker failure leads to under replicated partitions Key: KAFKA-6113 URL: https://issues.apache.org/jira/browse/KAFKA-6113 Project: Kafka Issue T

[GitHub] kafka pull request #4128: MINOR: random cleanup and JavaDoc improvements for...

2017-10-24 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/4128 MINOR: random cleanup and JavaDoc improvements for clients and Streams You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka minor-cleanup

[GitHub] kafka-site pull request #103: MINOR: Fix typo in title

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/103 ---

[GitHub] kafka-site issue #103: MINOR: Fix typo in title

2017-10-24 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/103 LGTM. Merged to `asf-site`. ---

[GitHub] kafka-site issue #103: MINOR: Fix typo in title

2017-10-24 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/103 Could you submit a patch to `kafka` repo under `docs/streams/index.html` as well? ---

[GitHub] kafka pull request #4127: MINOR use proper template classes for internalSele...

2017-10-24 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4127 MINOR use proper template classes for internalSelectKey() As pointed out in this thread: http://search-hadoop.com/m/Kafka/uyzND1fy2K7I85G1?subj=Kafka+source+code+Build+Error , Eclipse shows syntax er

Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

2017-10-24 Thread Colin McCabe
On Tue, Oct 24, 2017, at 11:28, Sönke Liebau wrote: > Hi, > > after reading your messages I'll grant that I might have picked a > somewhat > draconic option to solve these issues. > > In general I believe that properly encoding the URLs after having created > the connectors should solve a lot of

Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

2017-10-24 Thread Sönke Liebau
Hi, after reading your messages I'll grant that I might have picked a somewhat draconic option to solve these issues. In general I believe that properly encoding the URLs after having created the connectors should solve a lot of the issues already. For some characters the rest api returns an erro

Re: Before creating KIP : Kafka Connect / Add a configuration provider class

2017-10-24 Thread Florian Hussonnois
Yes, the provider classes will need to be installed on each worker (same installation mechanism than a connector-plugin). A new provider instance should be create for each connector instance but will be configure at the worker level. A provider class may have two behaviors : - provide a default

Re: [DISCUSS] KIP-205: Add getAllKeys() API to ReadOnlyWindowStore

2017-10-24 Thread Xavier Léauté
> > Generally I think having `all / range` is better in terms of consistency > with key-value windows. I.e. queries with key are named as `get / fetch` > for kv / window stores, and queries without key are named as `range / all`. > For kv stores, range takes a range of keys, and with this proposal

[GitHub] kafka-site issue #103: MINOR: Fix typo in title

2017-10-24 Thread joel-hamill
Github user joel-hamill commented on the issue: https://github.com/apache/kafka-site/pull/103 ping @guozhangwang ---

[GitHub] kafka-site pull request #103: MINOR: Fix typo in title

2017-10-24 Thread joel-hamill
GitHub user joel-hamill opened a pull request: https://github.com/apache/kafka-site/pull/103 MINOR: Fix typo in title You can merge this pull request into a Git repository by running: $ git pull https://github.com/joel-hamill/kafka-site dev-guide-tittle Alternatively you can

[GitHub] kafka-site pull request #102: Dev guide title fix

2017-10-24 Thread joel-hamill
Github user joel-hamill closed the pull request at: https://github.com/apache/kafka-site/pull/102 ---

[GitHub] kafka-site pull request #102: Dev guide title fix

2017-10-24 Thread joel-hamill
GitHub user joel-hamill opened a pull request: https://github.com/apache/kafka-site/pull/102 Dev guide title fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/joel-hamill/kafka-site dev-guide-title-fix Alternatively you can re

[GitHub] kafka-site pull request #101: MINOR: Fix typo in Dev Guide title

2017-10-24 Thread joel-hamill
Github user joel-hamill closed the pull request at: https://github.com/apache/kafka-site/pull/101 ---

[GitHub] kafka-site pull request #101: Dev guide title

2017-10-24 Thread joel-hamill
GitHub user joel-hamill opened a pull request: https://github.com/apache/kafka-site/pull/101 Dev guide title You can merge this pull request into a Git repository by running: $ git pull https://github.com/joel-hamill/kafka-site dev-guide-title Alternatively you can review and

Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

2017-10-24 Thread Colin McCabe
It should be possible to use entity references to encode these characters in URLs. See https://dev.w3.org/html5/html-author/charref Maybe I'm misunderstanding the problem, but can we simply encode the URLs, rather than restricting the names? best, Colin On Mon, Oct 23, 2017, at 14:12, Randall

[GitHub] kafka pull request #4126: KAFKA-6072: User ZookeeperClient in GroupCoordinat...

2017-10-24 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/4126 KAFKA-6072: User ZookeeperClient in GroupCoordinator and TransactionCoordinator You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka

Re: [DISCUSS] KIP-209 Connection String Support

2017-10-24 Thread Colin McCabe
Hi Clebert, As some other people mentioned, a comma is probably not a great choice for the entry separator. We have a lot of configuration values that already include commas. How about using a semicolon instead? You also need an escaping system in case someone needs a semicolon (or whatever) th

Re: [VOTE] KIP-205: Add all() and range() API to ReadOnlyWindowStore

2017-10-24 Thread Guozhang Wang
+1. Thanks. On Mon, Oct 23, 2017 at 8:11 PM, Richard Yu wrote: > Hi all, > > I want to propose KIP-205 for the addition of new API. It is about adding > methods similar to those found in ReadOnlyKeyValueStore to the > ReadOnlyWindowStore class. As it appears the discussion has reached a > conclu

[jira] [Created] (KAFKA-6112) SSL + ACL does not seem to work

2017-10-24 Thread Jagadish Prasath Ramu (JIRA)
Jagadish Prasath Ramu created KAFKA-6112: Summary: SSL + ACL does not seem to work Key: KAFKA-6112 URL: https://issues.apache.org/jira/browse/KAFKA-6112 Project: Kafka Issue Type: Bug

Re: Metadata class doesn't "expose" topics with errors

2017-10-24 Thread Paolo Patierno
Hi Guozhang, thanks for replying ! I see your point about the Metadata class which doesn't need to expose errors because transient. Regarding the KIP-204, the delete operations in the "legacy" client doesn't have any retry logic but it just returns the error to the user which should retry h

Re: [DISCUSS] KIP-208: Add SSL support to Kafka Connect REST interface

2017-10-24 Thread Jakub Scholz
There has been no discussion since my last update week ago. Unless someone has some further comments in the next 48 hours, I will start the voting for this KIP. Thanks & Regards Jakub On Tue, Oct 17, 2017 at 5:54 PM, Jakub Scholz wrote: > Ok, so I updated the KIP according to what we discussed.

Build failed in Jenkins: kafka-0.11.0-jdk7 #325

2017-10-24 Thread Apache Jenkins Server
See Changes: [wangguoz] HOTFIX: poll with zero millis during restoration -- [...truncated 2.45 MB...] org.apache.kafka.streams.integration.EosIntegrationTest > shouldBeA