Re: [DISCUSS] KIP-227: Introduce Incremental FetchRequests to Increase Partition Scalability

2017-11-25 Thread Dong Lin
Hey Colin, Thanks for the reply. Please see my comments inline. On Sat, Nov 25, 2017 at 3:33 PM, Colin McCabe wrote: > On Fri, Nov 24, 2017, at 22:06, Dong Lin wrote: > > Hey Colin, > > > > Thanks for the reply! Please see my comment inline. > > > > On Fri, Nov 24, 2017 at

Re: [DISCUSS] KIP-213 Support non-key joining in KTable

2017-11-25 Thread Jan Filipiak
Hi Matthias, 2 things that pop into my mind sunday morning. Can we provide an KTableValueGetter when key in the store is different from the key forwarded? 1. we would need a backwards mapper 2. I am not sure if we can pull it of w/o said forth generic type in KTable (that I am in favour of

Build failed in Jenkins: kafka-trunk-jdk7 #3001

2017-11-25 Thread Apache Jenkins Server
See Changes: [me] KAFKA-5563: Standardize validation and substitution of connector names -- [...truncated 402.92 KB...] kafka.zk.KafkaZkClientTest > testGetDataAndVersion

Build failed in Jenkins: kafka-trunk-jdk8 #2240

2017-11-25 Thread Apache Jenkins Server
See Changes: [me] KAFKA-5563: Standardize validation and substitution of connector names -- [...truncated 403.64 KB...] kafka.utils.CoreUtilsTest > testCircularIterator

[GitHub] kafka pull request #4230: KAFKA-5563: Moved comparison of connector name fro...

2017-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/4230 ---

[jira] [Resolved] (KAFKA-5563) Clarify handling of connector name in config

2017-11-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-5563. -- Resolution: Fixed Fix Version/s: 1.1.0 Issue resolved by pull request

[GitHub] kafka pull request #4265: KAFKA-6065: Latency metric for KafkaZkClient

2017-11-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4265 KAFKA-6065: Latency metric for KafkaZkClient Measures the latency of each request batch. Updated existing `ZkUtils` test to use `KafkaZkClient` instead. ### Committer Checklist

Re: [DISCUSS] KIP-227: Introduce Incremental FetchRequests to Increase Partition Scalability

2017-11-25 Thread Colin McCabe
On Fri, Nov 24, 2017, at 22:06, Dong Lin wrote: > Hey Colin, > > Thanks for the reply! Please see my comment inline. > > On Fri, Nov 24, 2017 at 9:39 PM, Colin McCabe wrote: > > > On Thu, Nov 23, 2017, at 18:35, Dong Lin wrote: > > > Hey Colin, > > > > > > Thanks for the

[GitHub] kafka pull request #4264: MINOR: small fix for doc comment in NetworkClient....

2017-11-25 Thread sweat123
Github user sweat123 closed the pull request at: https://github.com/apache/kafka/pull/4264 ---

[GitHub] kafka pull request #4264: MINOR: small fix for doc comment in NetworkClient....

2017-11-25 Thread sweat123
GitHub user sweat123 opened a pull request: https://github.com/apache/kafka/pull/4264 MINOR: small fix for doc comment in NetworkClient.DefaultMetadataUpdater You can merge this pull request into a Git repository by running: $ git pull https://github.com/sweat123/kafka

Looking for a review on my PR

2017-11-25 Thread charly molter
Hi all, I've been trying to get a review on my PR: https://github.com/apache/kafka/pull/4188 Could someone please help out? Also could someone assign me the Jira: https://issues.apache.org/jira/browse/KAFKA-6180 ? Thanks! Charly -- Charly Molter