[GitHub] kafka pull request #3998: Fix array index out of bounds

2017-12-09 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/kafka/pull/3998 ---

Re: [VOTE] KIP-218: Make KafkaFuture.Function java 8 lambda compatible

2017-12-09 Thread Steven Aerts
Hello Xavier, for me it is perfect to take it along. I made a few small remarks in your PR. Thanks Op za 9 dec. 2017 om 01:29 schreef Xavier Léauté : > Hi Steve, I just posted in the discussion thread, there's just one tiny fix > I think would be useful to add while we're making changes to this

[jira] [Created] (KAFKA-6339) Integration test with embedded kafka.

2017-12-09 Thread DHRUV BANSAL (JIRA)
DHRUV BANSAL created KAFKA-6339: --- Summary: Integration test with embedded kafka. Key: KAFKA-6339 URL: https://issues.apache.org/jira/browse/KAFKA-6339 Project: Kafka Issue Type: Bug Affects

Re: [DISCUSS] KIP-236 Interruptible Partition Reassignment

2017-12-09 Thread Ted Yu
For the znodes created under /admin/reassignments/, would it be better if the partition znodes for the same topic are put under subtree headed by topic name ? In Tom's example, instead of: /admin/reassignments/mytopic-42 the znode would be: /admin/reassignments/mytopic/42 Cheers On Fri, Dec 8,

[jira] [Created] (KAFKA-6340) Support of transactions in KafkaConnect

2017-12-09 Thread Oleg Kuznetsov (JIRA)
Oleg Kuznetsov created KAFKA-6340: - Summary: Support of transactions in KafkaConnect Key: KAFKA-6340 URL: https://issues.apache.org/jira/browse/KAFKA-6340 Project: Kafka Issue Type: Improveme

Re: [DISCUSS] KIP-237: More Controller Health Metrics

2017-12-09 Thread Dong Lin
Hey Jun, Thanks for the suggestion. That is good point. I have updated the KIP as suggested. Thanks, Dong On Fri, Dec 8, 2017 at 5:04 PM, Jun Rao wrote: > Hi, Dong, > > Thanks for the KIP. It looks reasonable. > > Just one minor comment. In the following metric, it seems that RequestRate > is

Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

2017-12-09 Thread Dong Lin
Hey Jun, Thanks much for your comments. Given that client needs to de-serialize the metadata anyway, the extra overhead of checking the per-partition version for every partition should not be a big concern. Thus it makes sense to use leader epoch as the per-partition version instead of creating a

[DISCUSS] Allowing write access to GitHub repositories

2017-12-09 Thread Ismael Juma
Hi all, The Apache Infra team has started a new project earlier this year called GitBox that supports two-way synchronization between GitHub and git-wip-us.apache.org and, most importantly, provides GitHub write access to committers. GitBox is not generally available yet, but individual projects c

Re: [DISCUSS] Allowing write access to GitHub repositories

2017-12-09 Thread Ismael Juma
One thing I forgot to mention, many projects have requested and been using GitBox for a while: https://issues.apache.org/jira/browse/INFRA-15271?jql=project%20%3D%20INFRA%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20component%20%3D%20GitBox%20ORDER%20BY%20updated%20DESC%2C%20priority%20DES