Re: [VOTE] Allowing write access to GitHub repositories (aka GitBox)

2017-12-21 Thread Guozhang Wang
Thanks Ismael, I have setup the account and can verify that it works on kafka / kafka-site PRs now! Guozhang On Thu, Dec 21, 2017 at 5:12 PM, Ismael Juma wrote: > The previous Apache git repos don't exist anymore. The new ones are at: > >

[jira] [Resolved] (KAFKA-3496) Add reconnect attemps policies for client

2017-12-21 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-3496. Resolution: Won't Fix We decided to add configs for enabling exponential backoff instead. > Add

[jira] [Resolved] (KAFKA-5895) Gradle 3.0+ is needed on the build

2017-12-21 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5895. Resolution: Fixed Fix Version/s: 1.1.0 > Gradle 3.0+ is needed on the build >

Re: [VOTE] Allowing write access to GitHub repositories (aka GitBox)

2017-12-21 Thread Ismael Juma
The previous Apache git repos don't exist anymore. The new ones are at: https://gitbox.apache.org/repos/asf/?p=kafka.git https://gitbox.apache.org/repos/asf/?p=kafka-site.git In any case, we should merge to the GitHub repo now and the following PR updates the merge script to default to that:

Re: [VOTE] Allowing write access to GitHub repositories (aka GitBox)

2017-12-21 Thread Ismael Juma
It's done! Committers, please set up your account: https://gitbox.apache.org/setup/ On Wed, Dec 20, 2017 at 12:30 AM, Ismael Juma wrote: > Forgot the link to the relevant Infra JIRA: https://issues.apache. > org/jira/browse/INFRA-15676 > > On Tue, Dec 19, 2017 at 11:59 PM,

Re: [VOTE] KIP-237: More Controller Health Metrics

2017-12-21 Thread Dong Lin
Bump up the thread so that we can have these sensors to monitor our Kafka service sooner. On Mon, Dec 18, 2017 at 2:03 PM, Dong Lin wrote: > Hi all, > > Since there are no more outstanding comments, I would like to start voting > thread for KIP-237:

Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

2017-12-21 Thread Dong Lin
Hey Jun, Thanks much for your comments. Yeah I have not considered the case where the offset is stored externally. Based Jason's question, I think we probably have to use a global metadata_epoch. And since we have a global metadata_epoch, this KIP probably no longer needs the per-partition

[GitHub] kafka pull request #4351: kafka-6320: move ZK metrics in KafkaHealthCheck to...

2017-12-21 Thread junrao
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/4351 kafka-6320: move ZK metrics in KafkaHealthCheck to ZookeeperClient * Moved metrics in KafkaHealthCheck to ZookeeperClient. * Converted remaining ZkUtils usage in KafkaServer to ZookeeperClient

Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

2017-12-21 Thread Dong Lin
Hey Jason, Thanks much. Great question. I have considered topic deletion but I have not considered the scenario that user creates topic very soon after topic deletion. After thinking through this scenario, I think the only option is to have a global metadata_epoch that keeps increasing every

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Jason Gustafson
I didn't sense much resistance in that thread, just an effort to keep the streams and core client config APIs consistent ;). I'd prefer seeing a KIP for a more general improvement, but this change seems harmless and improves consistency between the clients, so +1 from me. -Jason On Thu, Dec 21,

[jira] [Created] (KAFKA-6398) Stream-Table join fails, if table is not materialized

2017-12-21 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-6398: -- Summary: Stream-Table join fails, if table is not materialized Key: KAFKA-6398 URL: https://issues.apache.org/jira/browse/KAFKA-6398 Project: Kafka

Re: [DISCUSS] KIP 145 - Expose Record Headers in Kafka Connect

2017-12-21 Thread Randall Hauch
All, I've updated KIP-145 to reflect my proposal. The proposal addresses SMTs and a different HeaderConverter default, but I'll be updating my PR ( https://github.com/apache/kafka/pull/4319) soon. Feedback is very welcome! Best regards, Randall On Thu, Dec 14, 2017 at 10:20 AM, Randall Hauch

Build failed in Jenkins: kafka-trunk-jdk8 #2294

2017-12-21 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Improve Streams Dev Guide content on web docs -- [...truncated 3.38 MB...] kafka.utils.CoreUtilsTest > testReadInt STARTED

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Matthias J. Sax
I personally love the builder pattern idea. There was some push back in the past though from some people. cf https://issues.apache.org/jira/browse/KAFKA-4436 Happy to propose the builder pattern but than we should have a proper DISCUSS thread. Maybe we do this as a follow up and just do this KIP

[GitHub] kafka pull request #4252: Migrate Streams Dev Guide content to AK

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/4252 ---

[jira] [Created] (KAFKA-6397) Consumer should not block setting initial positions of unavailable partitions

2017-12-21 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-6397: -- Summary: Consumer should not block setting initial positions of unavailable partitions Key: KAFKA-6397 URL: https://issues.apache.org/jira/browse/KAFKA-6397

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Jason Gustafson
Hey Matthias, Let me suggest an alternative. As you have mentioned, these config classes do not give users much benefit currently. Maybe we change that? I think many users would appreciate having a builder for configuration since it provides type safety and is generally a much friendlier pattern

[GitHub] kafka pull request #4350: Cached hashCode of a Node instance since it is imm...

2017-12-21 Thread esevastyanov
GitHub user esevastyanov opened a pull request: https://github.com/apache/kafka/pull/4350 Cached hashCode of a Node instance since it is immutable `Node` structure is immutable so it is possible to cache `hashCode` of a `Node` instance as it's done in the `TopicPartition` class.

Re: KIP-244: Add Record Header support to Kafka Streams

2017-12-21 Thread Bill Bejeck
Jorge, Thanks for the KIP, I know this is a feature others in the community have been interested in getting into Kafka Streams. I took a quick pass over it, and I have one initial question. We recently reduced overloads with KIP-182, and in this KIP we are increasing them again. I can see from

[jira] [Created] (KAFKA-6396) Possibly kafka-connect converter should be able to stop processing chain

2017-12-21 Thread Alexander Koval (JIRA)
Alexander Koval created KAFKA-6396: -- Summary: Possibly kafka-connect converter should be able to stop processing chain Key: KAFKA-6396 URL: https://issues.apache.org/jira/browse/KAFKA-6396 Project:

KIP-244: Add Record Header support to Kafka Streams

2017-12-21 Thread Jorge Esteban Quilcate Otoya
Hi all, I have created a KIP to add Record Headers support to Kafka Streams API: https://cwiki.apache.org/confluence/display/KAFKA/KIP-244%3A+Add+Record+Header+support+to+Kafka+Streams The main goal is to be able to use headers to filter, map and process records as streams. Stateful processing

[jira] [Created] (KAFKA-6395) KIP: Add Record Header support to Kafka Streams

2017-12-21 Thread Jorge Quilcate (JIRA)
Jorge Quilcate created KAFKA-6395: - Summary: KIP: Add Record Header support to Kafka Streams Key: KAFKA-6395 URL: https://issues.apache.org/jira/browse/KAFKA-6395 Project: Kafka Issue Type:

Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable

2017-12-21 Thread Damian Guy
+1 On Wed, 20 Dec 2017 at 21:09 Ted Yu wrote: > Ping for more (binding) votes. > > The pull request is ready. > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang > wrote: > > > +1 (binding), thanks! > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu