Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

2018-01-06 Thread Ewen Cheslack-Postava
re: whitespace characters, I'm fine with the restriction since I don't see it becoming an issue in practice. I just don't see any reason to restrict it so it seems like we're going out of our way and doing extra work to be restrictive, but without clear motivation. In general my default approach (

Re: [DISCUSS] KIP-227: Introduce Incremental FetchRequests to Increase Partition Scalability

2018-01-06 Thread Colin McCabe
On Thu, Jan 4, 2018, at 10:37, Jun Rao wrote: > Hi, Collin, > > A few more comments on the KIP. > > 1. About fetch sequence number. My understanding is that the sequence > number is really used to provide better fencing for requests coming from > different TCP sessions for a given client. Suppose

[jira] [Created] (KAFKA-6429) dirtyNonActiveSegments in `cleanableOffsets` should only be created when log.cleaner.min.compaction.lag.ms > 0

2018-01-06 Thread huxihx (JIRA)
huxihx created KAFKA-6429: - Summary: dirtyNonActiveSegments in `cleanableOffsets` should only be created when log.cleaner.min.compaction.lag.ms > 0 Key: KAFKA-6429 URL: https://issues.apache.org/jira/browse/KAFKA-6429