Jenkins build is back to normal : kafka-trunk-jdk7 #3395

2018-05-02 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-02 Thread Ron Dagostino
Hi everyone. Might it help resolve the issue posed by strange resource names if the wildcard ACLs were stored in a different place in Zookeeper? For example, the KIP proposes this: *$ get /kafka-acl/Topic/teamA**

Build failed in Jenkins: kafka-trunk-jdk8 #2614

2018-05-02 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-6657: Add StreamsConfig prefix for different consumers (#4805) [wangguoz] HOTFIX: Simplify ConsoleConsumer stripWithPrefix function --

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-02 Thread Piyush Vijay
Thank you everyone for the interest and, prompt and valuable feedback. I really appreciate the quick turnaround. I’ve tried to organize the comments into common headings. See my replies below: *Case of ‘*’ might already be present in consumer groups and transactional ids* - We definitely

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-05-02 Thread Jason Gustafson
Hey John, Yeah, I appreciate Becket's point. We do tend to abuse the initial intent of ApiException. It's just that it can be awkward to come up with another name when the ApiException already has a reasonable and appropriate name for the user API. `ClientTimeoutException` is a perfect example of

Jenkins build is back to normal : kafka-trunk-jdk8 #2613

2018-05-02 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk7 #3394

2018-05-02 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-6657: Add StreamsConfig prefix for different consumers (#4805) [wangguoz] HOTFIX: Simplify ConsoleConsumer stripWithPrefix function --

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-05-02 Thread Richard Yu
Hi John, I don't have any objections to this KIP change. Please go ahead. Thanks, Richard On Wed, May 2, 2018 at 2:54 PM, John Roesler wrote: > Thanks Jason, > > I did find some production use cases "on the internet" that use poll(0) > *just* to join the group initially and

[jira] [Resolved] (KAFKA-6657) Add StreamsConfig prefix for different consumers

2018-05-02 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-6657. Resolution: Delivered The code is merged: https://github.com/apache/kafka/pull/4805 > Add

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-05-02 Thread John Roesler
Thanks Jason, I did find some production use cases "on the internet" that use poll(0) *just* to join the group initially and ignore the response. I suppose the assumption is that it'll be empty on the very first call to poll with timeout=0. In my opinion, this usage is unsafe, since there's a

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-02 Thread Guozhang Wang
Hello Andy, Thanks for the KIP. The motivation and the general proposal looks good to me. I think in KTable it is indeed valuable to add the functions that does not change key, such as mapValues, transformValues, and filter. There are a few meta comments I have about the semantics of the newly

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-02 Thread Guozhang Wang
Hello Luís, Sorry for the late reply. My understanding is that such duplicates will only happen if the non-offset version value, either the timestamp or some long-typed header key, are the same (i.e. we cannot break ties). 1. For timestamp, which is in milli-seconds, I think in practice the

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-02 Thread Guozhang Wang
Hi Jorge, Thanks for the written KIP! Made a pass over it and left some comments (some of them overlapped with John's): 1. We need to have a clear inheritance protocol of headers in our topology: 1.a. In PAPI's context.forward() call, it should be straight-forward. 1.b. In DSL stateless

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-05-02 Thread Jason Gustafson
I think John's proposal look reasonable to me. My only doubt is about use cases for the new `awaitAssignmentMetadata` API. I think the basic idea is that we want a way to block until we have joined the consumer group, but we do not want to await fetched data. Maybe another way to accomplish this

Build failed in Jenkins: kafka-trunk-jdk7 #3393

2018-05-02 Thread Apache Jenkins Server
See Changes: [github] KAFKA-6825: Make -- [...truncated 416.62 KB...] kafka.admin.ResetConsumerGroupOffsetTest > testResetOffsetsShiftPlus PASSED

Re: [VOTE] KIP-219 - Improve Quota Communication

2018-05-02 Thread Jonghyun Lee
Hi Magnus and Jun, do you have any feedback on this? Since two of the original voters (Becket and Rajini) showed a preference for bumping up all request versions, I'll wait till tomorrow and start implementing it unless someone expresses different opinions. As for the implementation, the current

Re: [DISCUSS] KIP-293 Add new metrics for consumer/replication fetch requests

2018-05-02 Thread Ted Yu
bq. would force subclassing MetricRegistry Probably not to be done in this KIP due to the yammer API visibility issue you mentioned. On Wed, May 2, 2018 at 11:08 AM, Adam Kotwasinski < adam.kotwasin...@gmail.com> wrote: > Looks like my understanding of decaying metrics was wrong, could not get

Re: [DISCUSS] KIP-293 Add new metrics for consumer/replication fetch requests

2018-05-02 Thread Adam Kotwasinski
Looks like my understanding of decaying metrics was wrong, could not get the viable example. The difference in values when marking one metric 10k times, and then marking the other 10k after 1 minute were to the order of 10^-12, what is not interesting. So, I had updated the pull request

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-02 Thread charly molter
The fact that consumer groups and transactionalProducerId don't have a strict format is problematic (we have problems with people with empty spaces at the end of their consumer group for example). With 2.0 around the corner and the possibility to fix these errors from the past should we create a

Re: [DISCUSS] KIP-278: Add version option to Kafka's commands

2018-05-02 Thread Colin McCabe
Hi Manikumar, We already have a tool for getting the Kafka broker API versions, "./bin/kafka-broker-api-versions.sh". It was added as part of KIP-97. What Saski is proposing here is having a way of getting the version of locally installed Kafka software, which may be different from the server

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-02 Thread Colin McCabe
Hi Piyush, Thanks for the KIP! It seems like it will be really useful. As Rajini commented, the names for some resources (such as consumer groups) can include stars. So your consumer group might be named "foo*". We need a way of explicitly referring to that consumer group name, rather than

Re: [VOTE] KIP-283: Efficient Memory Usage for Down-Conversion

2018-05-02 Thread Ted Yu
+1 On Wed, May 2, 2018 at 9:27 AM, Dhruvil Shah wrote: > Hi all, > > I would like to start the vote on KIP-238: Efficient Memory Usage for > Down-Conversion. > > For reference, the link to the KIP is here: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

[VOTE] KIP-283: Efficient Memory Usage for Down-Conversion

2018-05-02 Thread Dhruvil Shah
Hi all, I would like to start the vote on KIP-238: Efficient Memory Usage for Down-Conversion. For reference, the link to the KIP is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-283%3A+Efficient+Memory+Usage+for+Down-Conversion and the discussion thread is here:

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-02 Thread John Roesler
Hi Jorge, Thanks for the design work. I agree that de-scoping the work to just the Processor API will help contain the design and implementation complexity. In the KIP, it mentions that the headers would be available in the ProcessorContext, (like "context.headers()"). It also says that

Re: [DISCUSS] KIP-293 Add new metrics for consumer/replication fetch requests

2018-05-02 Thread Ted Yu
Can you explain Rejected Alternatives #2 in more detail ? Maybe give some concrete example to show the summation of the two new metrics is not equal to the existing metric. On Wed, May 2, 2018 at 6:49 AM, Adam Kotwasinski wrote: > Hello, > > I have created a KIP to

[jira] [Created] (KAFKA-6852) Allow Log Levels to be dynamically configured

2018-05-02 Thread Yeva Byzek (JIRA)
Yeva Byzek created KAFKA-6852: - Summary: Allow Log Levels to be dynamically configured Key: KAFKA-6852 URL: https://issues.apache.org/jira/browse/KAFKA-6852 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-6851) Kafka CLI commands should support specifying the servers in environment variables

2018-05-02 Thread Peter Horvath (JIRA)
Peter Horvath created KAFKA-6851: Summary: Kafka CLI commands should support specifying the servers in environment variables Key: KAFKA-6851 URL: https://issues.apache.org/jira/browse/KAFKA-6851

[DISCUSS] KIP-293 Add new metrics for consumer/replication fetch requests

2018-05-02 Thread Adam Kotwasinski
Hello, I have created a KIP to add some additional metrics re number of fetch requests made to brokers - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=80452537 Feedback and suggestions are welcome. Best regards, Adam Kotwasinski

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-02 Thread Jorge Esteban Quilcate Otoya
Hi Matthias, I've created a new JIRA to track this, updated the KIP and create a PR. Looking forward to your feedback, Jorge. El mar., 13 feb. 2018 a las 22:43, Matthias J. Sax () escribió: > Hi Jorge, > > I would like to unblock this KIP to make some progress. The

[jira] [Created] (KAFKA-6850) KIP-244: Add Record Header support to Kafka Streams Processor API

2018-05-02 Thread Jorge Quilcate (JIRA)
Jorge Quilcate created KAFKA-6850: - Summary: KIP-244: Add Record Header support to Kafka Streams Processor API Key: KAFKA-6850 URL: https://issues.apache.org/jira/browse/KAFKA-6850 Project: Kafka

[jira] [Created] (KAFKA-6849) Add transformValues() method to KTable

2018-05-02 Thread Andy Coates (JIRA)
Andy Coates created KAFKA-6849: -- Summary: Add transformValues() method to KTable Key: KAFKA-6849 URL: https://issues.apache.org/jira/browse/KAFKA-6849 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-6848) Kafka consumer failed to get correct offset after commit

2018-05-02 Thread YY.Roy (JIRA)
YY.Roy created KAFKA-6848: - Summary: Kafka consumer failed to get correct offset after commit Key: KAFKA-6848 URL: https://issues.apache.org/jira/browse/KAFKA-6848 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-6847) PeriodicProducerExpirationCheck

2018-05-02 Thread Sunil Kumar (JIRA)
Sunil Kumar created KAFKA-6847: -- Summary: PeriodicProducerExpirationCheck Key: KAFKA-6847 URL: https://issues.apache.org/jira/browse/KAFKA-6847 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-290: Support for wildcard suffixed ACLs

2018-05-02 Thread Rajini Sivaram
Hi Piyush, Thanks for the KIP for this widely requested feature. A few comments/questions: 1. Some resource names can contain '*'. For example, consumer groups or transactional ids. I am wondering whether we need to restrict characters for these entities or provide a way to distinguish

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-02 Thread Luís Cabral
Hi Guozhang, Have you managed to have a look at my reply? How do you feel about this? Kind Regards, Luís Cabral On Monday, April 30, 2018, 9:27:15 AM GMT+2, Luís Cabral wrote: Hi Guozhang, I understand the argument, but this is a hazardous compromise for

[jira] [Created] (KAFKA-6846) Controller can spend long time in shutting down RequestSendThread when processing BrokerChange event

2018-05-02 Thread Zhanxiang Huang (JIRA)
Zhanxiang Huang created KAFKA-6846: -- Summary: Controller can spend long time in shutting down RequestSendThread when processing BrokerChange event Key: KAFKA-6846 URL: