Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-07-12 Thread Dong Lin
Thanks for the update Lucas. I think the motivation section is intuitive. It will be good to learn more about the comments from other reviewers. On Thu, Jul 12, 2018 at 9:48 PM, Lucas Wang wrote: > Hi Dong, > > I've updated the motivation section of the KIP by explaining the cases that > would

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

2018-07-12 Thread Lucas Wang
Hi Jun, About 3, thanks for the clarification. I like your proposal in that it avoids the delay for controller requests when the data request queue is empty. In comparison, the approach I described earlier is simpler to understand and implement. Between these two I actually like your suggested

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-07-12 Thread Lucas Wang
Hi Dong, I've updated the motivation section of the KIP by explaining the cases that would have user impacts. Please take a look at let me know your comments. Thanks, Lucas On Mon, Jul 9, 2018 at 5:53 PM, Lucas Wang wrote: > Hi Dong, > > The simulation of disk being slow is merely for me to

Build failed in Jenkins: kafka-trunk-jdk8 #2799

2018-07-12 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Additional detail in description for zookeeper.connect (#5358) -- [...truncated 2.48 MB...]

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-07-12 Thread Dong Lin
Hey Jason, It is a great summary. The solution sounds good. I might have minor comments regarding the method name. But we can discuss that minor points later after we reach consensus on the high level API. Thanks, Dong On Thu, Jul 12, 2018 at 11:41 AM, Jason Gustafson wrote: > Hey Anna and

Re: KIP-327: Add describe all topics API to AdminClient

2018-07-12 Thread Jason Gustafson
Hey Manikumar, As Kafka begins to scale to larger and larger numbers of topics/partitions, I'm a little concerned about the scalability of APIs such as this. The API looks benign, but imagine you have have a few million partitions. We already expose similar APIs in the producer and consumer, so

[jira] [Resolved] (KAFKA-6488) Prevent log corruption in case of OOM

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6488. - Resolution: Won't Do > Prevent log corruption in case of OOM > - > >

[jira] [Resolved] (KAFKA-3089) VerifiableProducer should do a clean shutdown in stop_node()

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-3089. - Resolution: Fixed > VerifiableProducer should do a clean shutdown in stop_node() >

[jira] [Resolved] (KAFKA-4820) ConsumerNetworkClient.send() should not require global lock

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-4820. - Resolution: Fixed > ConsumerNetworkClient.send() should not require global lock >

[jira] [Resolved] (KAFKA-3145) CPU Usage Spike to 100% when network connection is to error port

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-3145. - Resolution: Cannot Reproduce > CPU Usage Spike to 100% when network connection is to error port >

[jira] [Resolved] (KAFKA-6617) Improve controller performance by batching reassignment znode write operation

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6617. - Resolution: Fixed > Improve controller performance by batching reassignment znode write operation >

[jira] [Resolved] (KAFKA-5812) Represent logDir with case class where absolute path is required

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-5812. - Resolution: Won't Do > Represent logDir with case class where absolute path is required >

[jira] [Resolved] (KAFKA-6618) Prevent two controllers from updating znodes concurrently

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6618. - Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/KAFKA-6082 > Prevent two

[jira] [Resolved] (KAFKA-6636) ReplicaFetcherThread should not die if hw < 0

2018-07-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6636. - Resolution: Fixed This is no longer an issue after KAFKA-3978; Ensure high watermark is always

Re: [VOTE] 1.1.1 RC3

2018-07-12 Thread Harsha
+1. 1. Ran unit tests 2. Ran 3 node cluster to run few tests. Thanks, Harsha On Thu, Jul 12, 2018, at 7:29 AM, Manikumar wrote: > +1 (non-binding) Ran tests, Verified quick start, producer/consumer perf > tests > > > > On Thu, Jul 12, 2018 at 11:06 AM Brett Rann > wrote: > > > +1 (non

Re: KIP-327: Add describe all topics API to AdminClient

2018-07-12 Thread Harsha
Very useful. LGTM. Thanks, Harsha On Thu, Jul 12, 2018, at 9:56 AM, Manikumar wrote: > Hi all, > > I have created a KIP to add describe all topics API to AdminClient . > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-327%3A+Add+describe+all+topics+API+to+AdminClient > > Please take a

Re: [VOTE] 2.0.0 RC2

2018-07-12 Thread Harsha
+1 1. Ran unit tests 2. Tested few use cases through 3-node cluster. Thanks, Harsha On Thu, Jul 12, 2018, at 9:33 AM, Mickael Maison wrote: > +1 non-binding > Built from source, ran tests, ran quickstart and check signatures > > Thanks! > > > On Wed, Jul 11, 2018 at 10:48 PM, Jakub Scholz

[jira] [Resolved] (KAFKA-6746) Allow ZK Znode configurable for Kafka broker

2018-07-12 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-6746. -- Resolution: Fixed Fixed via https://github.com/apache/kafka/pull/5358 > Allow ZK Znode configurable

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-07-12 Thread Jason Gustafson
Hey Anna and Dong, Thanks a lot for the great discussion. I've been hanging back a bit because honestly the best option hasn't seemed clear. I agree with Anna's general observation that there is a distinction between the position of the consumer and its fetch state up to that position. If you

[jira] [Created] (KAFKA-7158) Duplicates when searching kafka stream state store with caching

2018-07-12 Thread Christian Henry (JIRA)
Christian Henry created KAFKA-7158: -- Summary: Duplicates when searching kafka stream state store with caching Key: KAFKA-7158 URL: https://issues.apache.org/jira/browse/KAFKA-7158 Project: Kafka

KIP-327: Add describe all topics API to AdminClient

2018-07-12 Thread Manikumar
Hi all, I have created a KIP to add describe all topics API to AdminClient . https://cwiki.apache.org/confluence/display/KAFKA/KIP-327%3A+Add+describe+all+topics+API+to+AdminClient Please take a look. Thanks,

Re: [VOTE] 2.0.0 RC2

2018-07-12 Thread Mickael Maison
+1 non-binding Built from source, ran tests, ran quickstart and check signatures Thanks! On Wed, Jul 11, 2018 at 10:48 PM, Jakub Scholz wrote: > +1 (non-binbding) ... I built the RC2 from source, run tests and used it > with several of my applications without any problems. > > Thanks & Regards

[jira] [Created] (KAFKA-7157) Connect TimestampConverter SMT doesn't handle null values

2018-07-12 Thread Randall Hauch (JIRA)
Randall Hauch created KAFKA-7157: Summary: Connect TimestampConverter SMT doesn't handle null values Key: KAFKA-7157 URL: https://issues.apache.org/jira/browse/KAFKA-7157 Project: Kafka

Re: [VOTE] 1.1.1 RC3

2018-07-12 Thread Manikumar
+1 (non-binding) Ran tests, Verified quick start, producer/consumer perf tests On Thu, Jul 12, 2018 at 11:06 AM Brett Rann wrote: > +1 (non binding) > rolling upgrade of shared staging multitenacy (200+ consumer groups) > cluster from 1.1.0 to 1.1.1-rc3 using the kafka_2.11-1.1.1.tgz

Build failed in Jenkins: kafka-trunk-jdk8 #2798

2018-07-12 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Print exception stack traces in ConsumerGroupCommand. (#5286) -- [...truncated 552.94 KB...] kafka.zk.KafkaZkClientTest >

[jira] [Created] (KAFKA-7156) Deleting topics with long names can bring all brokers to unrecoverable state

2018-07-12 Thread Petr Pchelko (JIRA)
Petr Pchelko created KAFKA-7156: --- Summary: Deleting topics with long names can bring all brokers to unrecoverable state Key: KAFKA-7156 URL: https://issues.apache.org/jira/browse/KAFKA-7156 Project:

[jira] [Created] (KAFKA-7155) the property CONFIG of the ProducerConfig maybe null.

2018-07-12 Thread zhangjk (JIRA)
zhangjk created KAFKA-7155: -- Summary: the property CONFIG of the ProducerConfig maybe null. Key: KAFKA-7155 URL: https://issues.apache.org/jira/browse/KAFKA-7155 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-7154) Apache kafka getting shut down everytime it is started

2018-07-12 Thread Pushkar Kumar (JIRA)
Pushkar Kumar created KAFKA-7154: Summary: Apache kafka getting shut down everytime it is started Key: KAFKA-7154 URL: https://issues.apache.org/jira/browse/KAFKA-7154 Project: Kafka Issue

[jira] [Created] (KAFKA-7153) Kafka commits transaction twice due to LeaveGroup

2018-07-12 Thread Kristian Kolding Foged-Ladefoged (JIRA)
Kristian Kolding Foged-Ladefoged created KAFKA-7153: --- Summary: Kafka commits transaction twice due to LeaveGroup Key: KAFKA-7153 URL: https://issues.apache.org/jira/browse/KAFKA-7153