Build failed in Jenkins: kafka-trunk-jdk8 #2845

2018-07-27 Thread Apache Jenkins Server
See Changes: [github] KAFKA-7192 Follow-up: update checkpoint to the reset beginning offset -- Started by an SCM change [EnvInject] - Loading node environment variables.

Build failed in Jenkins: kafka-trunk-jdk10 #331

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Re: Discussion: New components in JIRA?

2018-07-27 Thread Guozhang Wang
Hello Ray, Any PMC member of the project can add more components in the JIRA system. If there is no objection in the next 72 hours I can just go ahead and add them. Guozhang On Thu, Jul 26, 2018 at 1:50 PM, Ray Chiang wrote: > Thanks Guozhang. I'm good with the way the documentation is

Build failed in Jenkins: kafka-trunk-jdk10 #330

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #329

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-07-27 Thread Dong Lin
Hey Lucas, Thanks for the update. The current KIP propose new broker configs "listeners.for.controller" and "advertised.listeners.for.controller". This is going to be a big change since listeners are among the most important configs that every user needs to change. According to the rejected

[DISCUSS] add connect-related packages to "What is considered a "major change" that needs a KIP?"

2018-07-27 Thread Chia-Ping Tsai
hi Kafka There is a section[1] listing the packages which have public interfaces. However, it doesn't include any connect-related packages. It would be better to have a list used to highlight the public interfaces for connector. Otherwise, connector user may misuse the internal interface in

Build failed in Jenkins: kafka-trunk-jdk10 #328

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Jenkins build is back to normal : kafka-trunk-jdk8 #2844

2018-07-27 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-07-27 Thread Dong Lin
Hey Jason, Thanks for the update! I agree with the current proposal overall. I have some minor comments related to naming etc. 1) I am not strong and will just leave it here for discussion. Would it be better to rename "CurrentLeaderEpoch" to "ExpectedLeaderEpoch" for the new field in the

Build failed in Jenkins: kafka-trunk-jdk10 #327

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #326

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #325

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Jason Gustafson
Hey Boyang, Thanks for the KIP. I think my main question is in the same vein as James'. The problem is that the coordinator needs to be able to identify which instance of a particular memberId is the active one. For EOS, each transactionalId gets an epoch. When a new producer is started, it bumps

Build failed in Jenkins: kafka-trunk-jdk10 #324

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H30 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-07-27 Thread Stanislav Kozlovski
Hey, Ray Thanks for pointing that out, it's fixed now Best, Stanislav On Fri, Jul 27, 2018 at 9:43 PM Ray Chiang wrote: > Thanks. Can you fix the link in the "KIPs under discussion" table on > the main KIP landing page > < >

Build failed in Jenkins: kafka-trunk-jdk8 #2843

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H32 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #323

2018-07-27 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H20 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread James Cheng
When you say that it will "break", what does this breakage look like? Will the consumer-group be non-functional? Will just those instances be non-functional? Or will the group be functional, but the rebalancing be non-optimal and require more round-trips/data-transfer? (similar to the current

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-07-27 Thread Ray Chiang
Thanks.  Can you fix the link in the "KIPs under discussion" table on the main KIP landing page ?  I tried, but the Wiki won't let me. -Ray On 7/26/18 2:01 PM, Stanislav Kozlovski wrote: Hey guys, @Colin - good

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

2018-07-27 Thread Lucas Wang
A kind reminder for review of this KIP. Thank you very much! Lucas On Wed, Jul 25, 2018 at 10:23 PM, Lucas Wang wrote: > Hi All, > > I've updated the KIP by adding the dedicated endpoints for controller > connections, > and pinning threads for controller requests. > Also I've updated the title

Re: [VOTE] 2.0.0 RC3

2018-07-27 Thread Jason Gustafson
+1 I did the quickstart and verified the documentation (upgrade notes and notable changes). Thanks Rajini! On Fri, Jul 27, 2018 at 8:10 AM, Gwen Shapira wrote: > +1 > > Quickstart on binaries, built from sources, verified signatures -- it > really is Rajini. Thank you! > > Gwen > > On Thu, Jul

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-07-27 Thread Bill Bejeck
Hi Matthias, Thanks for the update and the working prototype, it helps with understanding the KIP. I took an initial pass over this PR, and overall I find the interfaces and approach to be reasonable. Regarding step 3C of the in-place upgrade (users needing to watch the restore process), I'm

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-07-27 Thread Jason Gustafson
Thanks Anna, you are right on both points. I updated the KIP. -Jason On Thu, Jul 26, 2018 at 2:08 PM, Anna Povzner wrote: > Hi Jason, > > Thanks for the update. I agree with the current proposal. > > Two minor comments: > 1) In “API Changes” section, first paragraph says that “users can catch

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Boyang Chen
Hey James, the algorithm is relying on client side to provide unique consumer member id. It will break unless we enforce some sort of validation (host + port) on the server side. To simplify the first version, we do not plan to enforce validation. A good comparison would be the EOS producer

Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-07-27 Thread Jason Gustafson
Hey Colin, The problem is both that the empty group id is the default value and that it is actually accepted by the broker for offset commits. Combine that with the fact that auto commit is enabled by default and you users get surprising behavior. If you look at a random Kafka cluster, you'll

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread James Cheng
> On Jul 26, 2018, at 11:09 PM, Guozhang Wang wrote: > > Hi Boyang, > > Thanks for the proposed KIP. I made a pass over the wiki and here are some > comments / questions: > > 1. In order to preserve broker compatibility, we need to make sure the > broker version discovery logic can be

Re: CVE-2018-1288: Authenticated Kafka clients may interfere with data replication

2018-07-27 Thread Mickael Maison
Thanks Rajini and the rest of the security team for handling this issue. For people interested in more details about the issue and its discovery we've published a blog post: https://developer.ibm.com/dwblog/2018/anatomy-kafka-cve/ On Thu, Jul 26, 2018 at 10:25 AM, Rajini Sivaram wrote: > >

Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-07-27 Thread Colin McCabe
Sorry if this is a silly question, but what's the rationale for switching to using null for the default group id, rather than the empty string? Continuing to use the empty string seems like less churn. And after all, we're not using the empty string group name for anything else. The big

Re: [VOTE] 2.0.0 RC3

2018-07-27 Thread Gwen Shapira
+1 Quickstart on binaries, built from sources, verified signatures -- it really is Rajini. Thank you! Gwen On Thu, Jul 26, 2018 at 10:27 PM, Guozhang Wang wrote: > +1. > > Validated the following: > > 1. quick start on binary (2.12) > 2. unit test on source > 3. javadoc > 4. web doc > 5.

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

2018-07-27 Thread Bill Bejeck
Thanks for the KIP! +1 -Bill On Thu, Jul 26, 2018 at 2:39 AM Guozhang Wang wrote: > +1 > > On Wed, Jul 25, 2018 at 11:13 PM, Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 7/25/18 7:47 PM, Ted Yu wrote: > > > +1 > > > > > > On Wed, Jul 25, 2018 at 7:24 PM Nishanth

[jira] [Created] (KAFKA-7213) NullPointerException during state restoration in kafka streams

2018-07-27 Thread Abhishek Agarwal (JIRA)
Abhishek Agarwal created KAFKA-7213: --- Summary: NullPointerException during state restoration in kafka streams Key: KAFKA-7213 URL: https://issues.apache.org/jira/browse/KAFKA-7213 Project: Kafka

[jira] [Created] (KAFKA-7212) Bad exception message on failed serialization

2018-07-27 Thread D T (JIRA)
D T created KAFKA-7212: -- Summary: Bad exception message on failed serialization Key: KAFKA-7212 URL: https://issues.apache.org/jira/browse/KAFKA-7212 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Guozhang Wang
Hi Boyang, Thanks for the proposed KIP. I made a pass over the wiki and here are some comments / questions: 1. In order to preserve broker compatibility, we need to make sure the broker version discovery logic can be integrated with this new logic. I.e. if a newer versioned consumer is talking