Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-11 Thread Guozhang Wang
Hello Yishun, Thanks for the proposed KIP. I made a pass over the wiki and here are some comments: 1. "DESCRIBE_GROUPS_RESPONSE_MEMBER_V0", why we need to encode the full schema for the "COORDINATOR_GROUPIDS_KEY_NAME" field? Note it includes a lot of fields such as member id that is not needed

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-11 Thread Yishun Guan
Hi, thank you Ted! I have addressed your comments: 1. Added more descriptions about later optimization. 2. Yes, I will implement the V3 later when this KIP gets accepted. 3. Fixed. Thanks, Yishun On Fri, Aug 10, 2018 at 3:32 PM Ted Yu wrote: > bq. this is the foundation of some later possible

[jira] [Created] (KAFKA-7278) replaceSegments() should not call asyncDeleteSegment() for segments which have been removed from segments list

2018-08-11 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-7278: --- Summary: replaceSegments() should not call asyncDeleteSegment() for segments which have been removed from segments list Key: KAFKA-7278 URL:

Re: [DISCUSS] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-08-11 Thread Dong Lin
Hey Attila, Sorry for late reply.. I forgot to reply the email. I have manually tested it by connecting kafka-log-dirs.sh to SSL-enabled broker. Regarding integration test, currently SaslSslAdminClientIntegrationTest tests AdminClient's connection to SSL-enabled broker. In terms of connection to

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

2018-08-11 Thread Stanislav Kozlovski
Hi, @Ron Agreed, tracking multiple errors would be better and would help diagnose bad extensions faster I've updated the KIP to address your two comments. Regarding the Javadoc, please read below: @Rajini The idea of the potentially-null token and extensions is not that they can be passed to the

Jenkins build is back to normal : kafka-trunk-jdk8 #2886

2018-08-11 Thread Apache Jenkins Server
See

RE: [VOTE] KIP-280: Enhanced log compaction

2018-08-11 Thread Luís Cabral
Hi Jason, The initial (and still only) requirement I wanted out of this KIP was to have the header strategy. This is because I want to be able to version both by date/time or by (externally provided) sequence, this is specially important if you are running in multiple environments, which may

Build failed in Jenkins: kafka-trunk-jdk10 #394

2018-08-11 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-7140; Remove deprecated poll usages (#5319) -- [...truncated 1.54 MB...] kafka.coordinator.transaction.TransactionCoordinatorTest >