Re: [VOTE] KIP-349 Priorities for Source Topics

2018-08-19 Thread Matthias J. Sax
@Nick: A KIP is only accepted if it got 3 binding votes, ie, votes from committers. If you close the vote before that, the KIP would not be accepted. Note that committers need to pay attention to a lot of KIPs and it can take a while until people can look into it. Thanks for your understanding.

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-19 Thread Ted Yu
bq. // or just Duration windowSize(); +1 to the above choice. The duration is obvious from the return type. For getter methods, we don't use get as prefix (as least for new code). Cheers On Sun, Aug 19, 2018 at 8:03 AM Nikolay Izhikov wrote: > Hello, John. > > Thank you very much for your

Re: Add to contributor list

2018-08-19 Thread Guozhang Wang
You need an apache id for the project (github account is separate), you can create one on apache website. Guozhang On Sun, Aug 19, 2018 at 2:02 PM, Murali Mani wrote: > Yes, it is correct. muralimani is the user id of Github. The mail id for > github - murali.m...@gmail.com > > On Sun, Aug

Re: Add to contributor list

2018-08-19 Thread Murali Mani
Yes, it is correct. muralimani is the user id of Github. The mail id for github - murali.m...@gmail.com On Sun, Aug 19, 2018 at 7:03 PM Guozhang Wang wrote: > Hello, > > I cannot find the id "muralimani" for either JIRA or wiki system. Could you > double check if it is created? > > > Guozhang >

[jira] [Created] (KAFKA-7313) StopReplicaRequest should not remove partition from ReplicaManager.allPartitions if partition is offline

2018-08-19 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-7313: --- Summary: StopReplicaRequest should not remove partition from ReplicaManager.allPartitions if partition is offline Key: KAFKA-7313 URL: https://issues.apache.org/jira/browse/KAFKA-7313

Re: Add to contributor list

2018-08-19 Thread Guozhang Wang
Hello, I cannot find the id "muralimani" for either JIRA or wiki system. Could you double check if it is created? Guozhang On Sun, Aug 19, 2018 at 12:46 AM, Murali Mani wrote: > Hi, > > Could you please add me to the contributor list? My jira id is muralimani > > -- > regards > Murali

[jira] [Created] (KAFKA-7312) Transient failure in kafka.api.AdminClientIntegrationTest.testMinimumRequestTimeouts

2018-08-19 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-7312: Summary: Transient failure in kafka.api.AdminClientIntegrationTest.testMinimumRequestTimeouts Key: KAFKA-7312 URL: https://issues.apache.org/jira/browse/KAFKA-7312

Re: [VOTE] KIP-349 Priorities for Source Topics

2018-08-19 Thread Adam Bellemare
While I am not sure if I can or can’t vote, my question re: Jan’s comment is, “should we be implementing it as Samza does?” I am not familiar with the drawbacks of the current approach vs how samza does it. > On Aug 18, 2018, at 5:06 PM, n...@afshartous.com wrote: > > > I only saw one vote

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-19 Thread Nikolay Izhikov
Hello, John. Thank you very much for your feedback! I've addressed all your comments. Please, see my answers and let my know is anything in KIP [1] needs to be improved. > The correct choice is actually "Instant", not> "LocalDateTime" I've changed the methods proposed in KIP [1] to use

Add to contributor list

2018-08-19 Thread Murali Mani
Hi, Could you please add me to the contributor list? My jira id is muralimani -- regards Murali Krishnan Mani Ph: +44 (0)7432128519