Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-09-15 Thread Bill Bejeck
Congrats! On Sat, Sep 15, 2018 at 1:27 PM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Congratulations!! > > El sáb., 15 sept. 2018 a las 15:18, Dongjin Lee () > escribió: > > > Congratulations! > > > > Best, > > Dongjin > > > > On Sat, Sep 15, 2018 at 3:00 PM Colin McCabe

Re: [VOTE] KIP-361: Add Consumer Configuration to Disable Auto Topic Creation

2018-09-15 Thread Bill Bejeck
Thanks for the KIP. This is a great addition. +1(non-binding) Bill On Sat, Sep 15, 2018 at 12:06 PM Gwen Shapira wrote: > Thank you. This has been a source of surprises and confusion for a long > time. > +1 > > On Fri, Sep 14, 2018 at 4:55 PM, Dhruvil Shah > wrote: > > > Hi all, > > > > I

Accessing Topology Builder

2018-09-15 Thread Jorge Esteban Quilcate Otoya
Hi everyone, I'm experimenting on how to add tracing to Kafka Streams. One option is to override and access `InternalTopologyBuilder#addProcessor`. Currently this method it is final, and builder is not exposed as part of `StreamsBuilder`: ``` public class StreamsBuilder { /** The actual

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-09-15 Thread Jorge Esteban Quilcate Otoya
Congratulations!! El sáb., 15 sept. 2018 a las 15:18, Dongjin Lee () escribió: > Congratulations! > > Best, > Dongjin > > On Sat, Sep 15, 2018 at 3:00 PM Colin McCabe wrote: > > > Congratulations, Dong Lin! > > > > best, > > Colin > > > > On Wed, Aug 22, 2018, at 05:26, Satish Duggana wrote: >

Re: [VOTE] KIP-361: Add Consumer Configuration to Disable Auto Topic Creation

2018-09-15 Thread Gwen Shapira
Thank you. This has been a source of surprises and confusion for a long time. +1 On Fri, Sep 14, 2018 at 4:55 PM, Dhruvil Shah wrote: > Hi all, > > I would like to start a vote on KIP-361. > > Link to the KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-361%3A+Add+Consumer+ >

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-09-15 Thread Dongjin Lee
Congratulations! Best, Dongjin On Sat, Sep 15, 2018 at 3:00 PM Colin McCabe wrote: > Congratulations, Dong Lin! > > best, > Colin > > On Wed, Aug 22, 2018, at 05:26, Satish Duggana wrote: > > Congrats Dong Lin! > > > > On Wed, Aug 22, 2018 at 10:08 AM, Abhimanyu Nagrath < > >

Re: [DISCUSS]: KIP-339: Create a new ModifyConfigs API

2018-09-15 Thread Colin McCabe
On Wed, Aug 15, 2018, at 05:04, Viktor Somogyi wrote: > Hi, > > To weigh-in, I agree with Colin on the API naming, overloads shouldn't > change behavior. I think all of the Java APIs I've used so far followed > this principle and I think we shouldn't diverge. > > Also I think I have an entry

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-09-15 Thread Colin McCabe
Congratulations, Dong Lin! best, Colin On Wed, Aug 22, 2018, at 05:26, Satish Duggana wrote: > Congrats Dong Lin! > > On Wed, Aug 22, 2018 at 10:08 AM, Abhimanyu Nagrath < > abhimanyunagr...@gmail.com> wrote: > > > Congratulations, Dong! > > > > On Wed, Aug 22, 2018 at 6:20 AM Dhruvil Shah