Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-09-26 Thread Dongjin Lee
Hi Srinivas, Thanks for your proposal. It sounds reasonable to me. However, the code freeze of 2.1.0 is imminent so it seems like all the committers are on working frenzy on it. How about to postpone reboot this discussion after the release of 2.1.0? I will kick off the thread as soon as the relea

Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-09-26 Thread Srinivas Reddy
Any thoughts about this KIP ? - Srinivas - Typed on tiny keys. pls ignore typos.{mobile app} On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, wrote: > Hi All, > > I'd like to start a discussion on KIP-374 which is to add "--help" option > for all the possible CLI commands in Kafka. right now, few co

Re: [DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

2018-09-26 Thread Chia-Ping Tsai
hi Yishun Thanks for nice KIP! Q1) Why VerifiableProducer extend Closeable rather than AutoCloseable? Q2) I grep project and then noticed there are other close methods but do not implement AutoCloseable. For example: 1) WorkerConnector 2) MemoryRecordsBuilder 3) MetricsReporter 4) ExpiringCrede

Re: [DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

2018-09-26 Thread Yishun Guan
Hi Bill, I see, i just updated the KIP with all the changes. And your second concern make sense - if that's what everyone think, we can start with changing KafkaStream first. Thanks, Yishun On Wed, Sep 26, 2018 at 5:18 PM Bill Bejeck wrote: > > Hi Yishun, > > Thanks for the KIP, seems like a use

Re: [DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

2018-09-26 Thread Bill Bejeck
Hi Yishun, Thanks for the KIP, seems like a useful addition. Just a couple of minor comments. Can you list all the changes in the list under "Public Interfaces" in the "Proposed Changes" section that way it's clear what's changing? I realize they all will be very similar, but it's better to be

[DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

2018-09-26 Thread Yishun Guan
Hi All, Here is a trivial KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=93325308 Suggestions are welcome. Thanks, Yishun

Re: [EXTERNAL] [DISCUSS] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-09-26 Thread McCaig, Rhys
Hi Konstantine, Thank you for your thoughtful comments! > However, I don't think the apache/kafka repository is the right place to > host such a Connector. > I find this approach very appealing. AK focuses on providing the core > infrastructure for Connect, that is required in every Kafka Conn

Jenkins build is back to normal : kafka-trunk-jdk8 #2993

2018-09-26 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-7437) Store leader epoch in offset commit metadata

2018-09-26 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-7437. --- Resolution: Fixed Reviewer: Rajini Sivaram Fix Version/s: 2.1.0 > Store leade

[jira] [Created] (KAFKA-7444) expose connector, task IDs to SinkTasks

2018-09-26 Thread Ryanne Dolan (JIRA)
Ryanne Dolan created KAFKA-7444: --- Summary: expose connector, task IDs to SinkTasks Key: KAFKA-7444 URL: https://issues.apache.org/jira/browse/KAFKA-7444 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] Make org.apache.kafka.clients.Metadata#TOPIC_EXPIRY_MS configurable

2018-09-26 Thread Dongjin Lee
Hi Pavel, Thanks for a great proposal. However, the code freeze of 2.1.0 is imminent, so it seems like all the committers are on working frenzy. How about discussing this KIP after the release of 2.1.0? I promise, I will reboot this discussion as soon as 2.1.0 is released. I also experienced a sim

Re: [VOTE] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-09-26 Thread Konstantine Karantasis
Hi Rhys, I just replied in the discussion thread for KIP-310 with my concerns. Thanks for submitting this proposal. -Konstantine On Tue, Sep 11, 2018 at 12:53 AM McCaig, Rhys wrote: > Hi All, > > Bumping this again. > Can I get feedback from some binding vote holders on this KIP? I think its

Re: [EXTERNAL] [DISCUSS] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-09-26 Thread Konstantine Karantasis
Hi Rhys, thanks for the proposal and apologies for the late feedback. Utilizing Connect to mirror Kafka topics is definitely a plausible proposal for a very useful use case. However, I don't think the apache/kafka repository is the right place to host such a Connector. Currently, no full-featured

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-26 Thread Yishun Guan
Congrats! -Yishun On Wed, Sep 26, 2018, 10:04 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Well deserved! Congratulations Colin. > > -Konstantine > > On Wed, Sep 26, 2018 at 4:57 AM Srinivas Reddy > > wrote: > > > Congratulations Colin 👏 > > > > - > > Srinivas > > > > - Typed o

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-26 Thread Konstantine Karantasis
Well deserved! Congratulations Colin. -Konstantine On Wed, Sep 26, 2018 at 4:57 AM Srinivas Reddy wrote: > Congratulations Colin 👏 > > - > Srinivas > > - Typed on tiny keys. pls ignore typos.{mobile app} > > On Tue 25 Sep, 2018, 16:39 Ismael Juma, wrote: > > > Hi all, > > > > The PMC for Apach

Re: [DISCUSS] KIP-375 Kafka Clients - make Metadata#TOPIC_EXPIRY_MS configurable

2018-09-26 Thread Viktor Somogyi-Vass
Hi Pavel, May I kindly ask you to increment your KIP number? :) As it turns out I have already created one with this number a little bit earlier. Apologies for the inconvenience. Viktor On Wed, Sep 26, 2018 at 4:48 PM Pavel Moukhataev wrote: > > https://cwiki.apache.org/confluence/display/KAFK

[DISCUSS] KIP-375 Kafka Clients - make Metadata#TOPIC_EXPIRY_MS configurable

2018-09-26 Thread Pavel Moukhataev
https://cwiki.apache.org/confluence/display/KAFKA/KIP-375%3A+Kafka+Clients+-+make+Metadata%23TOPIC_EXPIRY_MS+configurable I'd like to introduce new feature for kafka client: Making org.apache.kafka.clients.Metadata#TOPIC_EXPIRY_MS configurable The problem is: if application sends records to some

Build failed in Jenkins: kafka-trunk-jdk8 #2992

2018-09-26 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-7428: ConnectionStressSpec: add "action", allow multiple clients [rajinisivaram] MINOR: Fix broken link in security.html (#5670) -- [.

Jenkins build is back to normal : kafka-trunk-jdk10 #522

2018-09-26 Thread Apache Jenkins Server
See

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-26 Thread Srinivas Reddy
Congratulations Colin 👏 - Srinivas - Typed on tiny keys. pls ignore typos.{mobile app} On Tue 25 Sep, 2018, 16:39 Ismael Juma, wrote: > Hi all, > > The PMC for Apache Kafka has invited Colin McCabe as a committer and we are > pleased to announce that he has accepted! > > Colin has contributed

Kafka 7382 - Guarantee atleast one replica of partition be alive during create topic.

2018-09-26 Thread Suman B N
Team, Issue KAFKA-7382 has been fixed. Please review and merge. We need this fix in one of our production clusters. Pull request is here . -- *Suman* *OlaCabs*

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-26 Thread Viktor Somogyi-Vass
Hi Manikumar, Thanks for raising this to my attention. I must have missed this in the AdminClient, so you're right, we don't need this new protocol at all. I've moved it to the rejected alternatives section. Thanks, Viktor On Wed, Sep 26, 2018 at 8:24 AM Manikumar wrote: > Hi Viktor, > > We al

[jira] [Created] (KAFKA-7443) OffsetOutOfRangeException in restoring state store from changelog topic when start offset of local checkpoint is smaller than that of changelog topic

2018-09-26 Thread linyue li (JIRA)
linyue li created KAFKA-7443: Summary: OffsetOutOfRangeException in restoring state store from changelog topic when start offset of local checkpoint is smaller than that of changelog topic Key: KAFKA-7443 URL: https:

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-26 Thread Jorge Esteban Quilcate Otoya
Congratulations Colin!! El mié., 26 sept. 2018 a las 5:54, Dongjin Lee () escribió: > Congratulations!! > > Best, > Dongjin > > On Wed, Sep 26, 2018 at 11:56 AM Satish Duggana > wrote: > > > Congratulations Colin! > > > > > > > > On Wed, Sep 26, 2018 at 5:52 AM, Vahid Hashemian > > wrote: > > >

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-09-26 Thread Satish Duggana
Thanks for the KIP! +1 (non-binding) On Tue, Sep 25, 2018 at 1:38 PM, Ismael Juma wrote: > Thanks, +1 (binding). > > Ismael > > On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai wrote: > >> KIP-336[1] has been merged so it is time to activate this thread >> (KIP-331[2]). Last discussion is about "S

Re: Accessing Topology Builder

2018-09-26 Thread Jorge Esteban Quilcate Otoya
Good to know, thanks Matthias! You've mentioned a previous operator, but what about: `peek().mapValues().peek()`, will both `peek`s be in the same thread as well? El mar., 25 sept. 2018 a las 23:14, Matthias J. Sax () escribió: > Just for clarification: > > `peek()` would run on the same thread

[jira] [Created] (KAFKA-7442) forceUnmap mmap on linux

2018-09-26 Thread JIRA
翟玉勇 created KAFKA-7442: -- Summary: forceUnmap mmap on linux Key: KAFKA-7442 URL: https://issues.apache.org/jira/browse/KAFKA-7442 Project: Kafka Issue Type: Improvement Components: log Affe