Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-16 Thread Matthias J. Sax
Couple of follow up comment on the KIP: It seems that `windowSize` is a mandatory argument for windowed-tables, thus all overload should have the first two parameters being `String topic` and `Duration windowSize`. For session-tables, there should be no `windowSize` parameter because each session

Re: [DISCUSS] KIP-165: Extend Interactive Queries for return latest update timestamp per key

2019-01-16 Thread Matthias J. Sax
Hi, This issue seems to be resolved as part of KIP-258. Thus, I close this discussion and mark this KIP as discarded. Let me know if there is any objection. Thanks. -Matthias On 12/4/17 4:06 PM, Matthias J. Sax wrote: > Jeyhun, > > is there any update regarding this KIP? > > > -Matthias >

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-16 Thread Matthias J. Sax
Thanks for the details John. While I understand your argument that it is no optimal to use `Materialized` to set the processor name, I still slightly prefer this option, because adding more overloads seems to be even worse to me. But I would also not block this KIP if the majority of people prefe

Re: [DISCUSS] KIP-382: MirrorMaker 2.0

2019-01-16 Thread Ryanne Dolan
Thanks Dong. > 1. Currently if there is topic created with "." in the topic name, would it cause correctness issue for this KIP? Yes, RemoteClusterUtils would be confused by existing topics that have a period, and MM2 might try to send records to existing topics if they happen to be prefixed with

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-16 Thread John Roesler
Hi Matthias, One thing that we discussed earlier was to avoid creating ambiguity by conflating config objects that configure an operation (like Grouped) with config objects that configure an aspect of the operation (like Materialized). It is natural for the Grouped config to extend Named, as doin

[jira] [Created] (KAFKA-7834) Extend collected logs in system test services to include heap dumps

2019-01-16 Thread Konstantine Karantasis (JIRA)
Konstantine Karantasis created KAFKA-7834: - Summary: Extend collected logs in system test services to include heap dumps Key: KAFKA-7834 URL: https://issues.apache.org/jira/browse/KAFKA-7834 P

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Matthias J. Sax
Thanks for the feedback. I updated the interface names to `TimestampedXxxStore`. About `RecordConverter` I would like to keep the name, because it's a generic concept and we will have a special implementation that does the timestamp conversion -- however, this should be reflected in the (internal

[jira] [Created] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2019-01-16 Thread Sam Lendle (JIRA)
Sam Lendle created KAFKA-7833: - Summary: StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder Key: KAFKA-7833 URL: https://issues.apache.org/jira/browse/KAF

[jira] [Created] (KAFKA-7832) Use automatic RPC generation in CreateTopics

2019-01-16 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-7832: -- Summary: Use automatic RPC generation in CreateTopics Key: KAFKA-7832 URL: https://issues.apache.org/jira/browse/KAFKA-7832 Project: Kafka Issue Type: Su

[jira] [Created] (KAFKA-7831) Consumer SubscriptionState missing synchronization

2019-01-16 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-7831: -- Summary: Consumer SubscriptionState missing synchronization Key: KAFKA-7831 URL: https://issues.apache.org/jira/browse/KAFKA-7831 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-7830) Convert Kafka RPCs to use automatically generated code

2019-01-16 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-7830: -- Summary: Convert Kafka RPCs to use automatically generated code Key: KAFKA-7830 URL: https://issues.apache.org/jira/browse/KAFKA-7830 Project: Kafka Issu

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread John Roesler
+1 (nonbinding) from me. Thanks for the KIP, Matthias. -John On Wed, Jan 16, 2019 at 12:01 PM Guozhang Wang wrote: > Thanks Matthias, I left some minor comments but since they do not involve > in any major architectural changes and I did not feel strong about the > naming etc as well. I'd +1 o

Re: [DISCUSS] KIP-402: Improve fairness in SocketServer processors

2019-01-16 Thread Mickael Maison
+1 (non binding) Thanks for the KIP On Wed, Jan 16, 2019 at 5:47 PM vcgat...@gmail.com wrote: > > > > On 2018/12/11 10:48:02, Rajini Sivaram wrote: > > Hi all, > > > > I have submitted a KIP to improve fairness in channel processing in > > SocketServer to protect brokers from connection storms:

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Guozhang Wang
Thanks Matthias, I left some minor comments but since they do not involve in any major architectural changes and I did not feel strong about the naming etc as well. I'd +1 on the proposal as well. Feel free to reply / accept or reject my suggestions on the other DISCUSS thread. Guozhang On Wed,

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Guozhang Wang
Matthias, Thanks for the updated wiki page. I made another pass and here are some minor comments I have (mostly about API names and writing itself): 1. The scope of the RecordConverter may not be very clear from the wiki page reads. Here's my understanding: 1.a) For build-in implementations (roc

Re: [DISCUSS] KIP-402: Improve fairness in SocketServer processors

2019-01-16 Thread vcgato29
On 2018/12/11 10:48:02, Rajini Sivaram wrote: > Hi all, > > I have submitted a KIP to improve fairness in channel processing in > SocketServer to protect brokers from connection storms: > >- > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-402%3A+Improve+fairness+in+SocketSe

Re: [DISCUSS] KIP-402: Improve fairness in SocketServer processors

2019-01-16 Thread Victor Corral
https://drive.google.com/open?id=14W1-hEu6rFHhZGFxY_vUGD2HAR-cRYEj On 2018/12/11 10:48:02, Rajini Sivaram wrote: > Hi all, > > I have submitted a KIP to improve fairness in channel processing in > SocketServer to protect brokers from connection storms: > >- > > https://cwiki.apache.org

Re: [jira] [Created] (KAFKA-7814) Broker shut down while cleaning up log file

2019-01-16 Thread Ishwor
On 11/1/19 10:41 pm, EverZhang (JIRA) wrote: EverZhang created KAFKA-7814: [...] It's fixed in `1.1.1`. It's time to upgrade your broker.

[jira] [Created] (KAFKA-7829) Inaccurate description for --reassignment-json-file option in ReassignPartitionsCommand

2019-01-16 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-7829: -- Summary: Inaccurate description for --reassignment-json-file option in ReassignPartitionsCommand Key: KAFKA-7829 URL: https://issues.apache.org/jira/browse/KAFKA-7829 Project: Ka

[VOTE] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-16 Thread Boyang Chen
Hey friends, I would like to start the vote thread for KIP-300 so that we could agree on the high level API. Feel free to continue making comment on the discussion thread. Best, Boyang

Re: [VOTE] KIP-402: Improve fairness in SocketServer processors

2019-01-16 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Tue, Jan 15, 2019, 3:38 PM Rajini Sivaram Hi all, > > I would like to start vote on KIP-402 to improve fairness in channel > processing in SocketServer to protect brokers from connection storms and > limit the total number of connections in brokers to

Re: [jira] [Created] (KAFKA-7814) Broker shut down while cleaning up log file

2019-01-16 Thread Ishwor
On 16/1/19 11:44 pm, Ishwor wrote: On 11/1/19 10:41 pm, EverZhang (JIRA) wrote: EverZhang created KAFKA-7814: [...] It's fixed in `1.1.1`. It's time to upgrade your broker. Ignore my earlier reply. Saw that you upgraded to `2.1.0` and I thought it was repro of log cleaner bug which was

Re: [VOTE] KIP-402: Improve fairness in SocketServer processors

2019-01-16 Thread Colin McCabe
+1 (binding) Thanks, Colin On Tue, Jan 15, 2019, at 18:55, Gwen Shapira wrote: > +1 > Thank you! > > > On Tue, Jan 15, 2019, 3:38 PM Rajini Sivaram > > > Hi all, > > > > I would like to start vote on KIP-402 to improve fairness in channel> > > > processing in SocketServer to protect brokers fr

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Hugo Louro
Congratulations on this important achievement. Keep it going! Hugo > On Jan 16, 2019, at 7:49 AM, Vahid Hashemian > wrote: > > Thank you all. It's my privilege to be involved in this great community and > I look forward to continuing this collaboration. > > Regards, > --Vahid > >> On Wed, Ja

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Vahid Hashemian
Thank you all. It's my privilege to be involved in this great community and I look forward to continuing this collaboration. Regards, --Vahid On Wed, Jan 16, 2019, 04:58 Attila Sasvári wrote: > Congratulations Vahid! > > On Tue, Jan 15, 2019 at 11:45 PM Jason Gustafson > wrote: > > > Hi All, >

Re: [VOTE] KIP-349 Priorities for Source Topics

2019-01-16 Thread Jan Filipiak
On 16.01.2019 14:05, Thomas Becker wrote: > I'm going to bow out of this discussion since it's been made clear that > the feature is not targeted at streams. But for the record, my desire is > to have an alternative to the timestamp based message choosing strategy > streams currently imposes, and

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Damian Guy
+1 On Wed, 16 Jan 2019 at 05:09, Patrik Kleindl wrote: > +1 (non-binding) > Thanks too > Best regards > Patrik > > > Am 16.01.2019 um 03:30 schrieb Bill Bejeck : > > > > Thanks for the KIP Matthias. > > > > +1 > > > > -Bill > > > > On Tue, Jan 15, 2019 at 7:33 PM Matthias J. Sax > > wrote: > >

Re: [VOTE] KIP-349 Priorities for Source Topics

2019-01-16 Thread Thomas Becker
I'm going to bow out of this discussion since it's been made clear that the feature is not targeted at streams. But for the record, my desire is to have an alternative to the timestamp based message choosing strategy streams currently imposes, and I thought topic prioritization in the consumer c

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Attila Sasvári
Congratulations Vahid! On Tue, Jan 15, 2019 at 11:45 PM Jason Gustafson wrote: > Hi All, > > The PMC for Apache Kafka has invited Vahid Hashemian as a project > committer and > we are > pleased to announce that he has accepted! > > Vahid has made numerous contributions to the Kafka community ove

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Tom Bentley
Congratulations Vahid! On Wed, Jan 16, 2019 at 10:13 AM Edoardo Comar wrote: > Bravo Vahid!!! > > Edo > > > > From: Mickael Maison > To: Users > Cc: dev > Date: 16/01/2019 08:48 > Subject:Re: [ANNOUNCE] New Committer: Vahid Hashemian > > > > Congratulations Vahid! Well don

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Edoardo Comar
Bravo Vahid!!! Edo From: Mickael Maison To: Users Cc: dev Date: 16/01/2019 08:48 Subject:Re: [ANNOUNCE] New Committer: Vahid Hashemian Congratulations Vahid! Well done! On Wed, Jan 16, 2019 at 6:42 AM Dongjin Lee wrote: > > Congratulations, Vahid!! > > On Wed, Jan 16

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-16 Thread Mickael Maison
Congratulations Vahid! Well done! On Wed, Jan 16, 2019 at 6:42 AM Dongjin Lee wrote: > > Congratulations, Vahid!! > > On Wed, Jan 16, 2019 at 3:32 PM Dong Lin wrote: > > > Congratulations Vahid! > > > > On Tue, Jan 15, 2019 at 2:45 PM Jason Gustafson > > wrote: > > > > > Hi All, > > > > > > The

[jira] [Resolved] (KAFKA-7814) Broker shut down while cleaning up log file

2019-01-16 Thread EverZhang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] EverZhang resolved KAFKA-7814. -- Resolution: Not A Problem > Broker shut down while cleaning up log file > -