[DISCUSS] KIP-491: Preferred Leader Deprioritized List (Temporary Blacklist)

2019-07-13 Thread George Li
Hi, I have created KIP-491 (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120736982) for putting a broker to the preferred leader blacklist or deprioritized list so when determining leadership,  it's moved to the lowest priority for some of the listed use-cases.  Please

Re: [DISCUSS] KIP-455 Create an Admin API for Replica Reassignments

2019-07-13 Thread George Li
Hi Stanislav, sorry for the late reply. comments below:  > Thanks for the reminder. A lot of your suggestions are outlined in the > "Future Work" section of KIP-455. The pointer towards different > ReplicaFetcher thread pools is interesting -- do you think there's > much value in that? My

[jira] [Created] (KAFKA-8663) partition assignment would be better original_assignment + new_reassignment during reassignments

2019-07-13 Thread GEORGE LI (JIRA)
GEORGE LI created KAFKA-8663: Summary: partition assignment would be better original_assignment + new_reassignment during reassignments Key: KAFKA-8663 URL: https://issues.apache.org/jira/browse/KAFKA-8663

[DISCUSS] KIP-490: log when consumer groups lose a message because offset has been deleted

2019-07-13 Thread Jose M
Hello, I would like to know what do you think on KIP-490: https://cwiki.apache.org/confluence/display/KAFKA/KIP-490%3A+log+when+consumer+groups+lose+a+message+because+offset+has+been+deleted

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-13 Thread Anastasia Vela
Hey! Thanks for looking over this KIP. These are all partitions per manager. I'll clear this up in the KIP. Anastasia On Sat, Jul 13, 2019, 2:15 PM Stanislav Kozlovski wrote: > Hey there, > > Thanks for the KIP! I always smile when I see new metrics > I have just one quick question - are these

[jira] [Resolved] (KAFKA-8183) Trogdor - ProduceBench should retry on UnknownTopicOrPartitionException during topic creation

2019-07-13 Thread Stanislav Kozlovski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski resolved KAFKA-8183. Resolution: Fixed > Trogdor - ProduceBench should retry on

Re: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2019-07-13 Thread Stanislav Kozlovski
Hello, Could we restart the discussion here again? My last message was sent on the 3rd of June but I haven't received replies since then. I'd like to get this KIP to a finished state, regardless of whether that is merged-in or discarded. It has been almost one year since the publication of the

Re: [VOTE] KIP-480 : Sticky Partitioner

2019-07-13 Thread Stanislav Kozlovski
+1 (non-binding) Thanks! On Fri, Jul 12, 2019 at 6:02 PM Gwen Shapira wrote: > +1 (binding) > > Thank you for the KIP. This was long awaited. > > On Tue, Jul 9, 2019 at 5:15 PM Justine Olshan > wrote: > > > > Hello all, > > > > I'd like to start the vote for KIP-480 : Sticky Partitioner. > >

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-13 Thread Stanislav Kozlovski
Hey there, Thanks for the KIP! I always smile when I see new metrics I have just one quick question - are these metrics per partition or a total of all the partitions per manager? The KIP has conflicting sentences so I'm not sure what it is. Thanks, Stanislav On Wed, Jul 3, 2019 at 9:13 PM

Re: [DISCUSS] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-13 Thread Stanislav Kozlovski
Hello, Thanks for the KIP, I'm happy we're converging on implementations. I was wondering whether we need to deprecate the old metrics - are those classes public interfaces? I see we don't build a JavaDoc for them ( https://kafka.apache.org/22/javadoc/allclasses-noframe.html) and, as far as I

Re: [DISCUSS] KIP-480 : Sticky Partitioner

2019-07-13 Thread Jun Rao
Hi, Justine, Thanks for the explanation. Your PR made the RecordAccumulator more cooperative with the new partitioning scheme. So, what I mentioned won't be an issue. The KIP looks good to me then. Jun On Fri, Jul 12, 2019 at 9:02 AM Justine Olshan wrote: > Hello all, > > Jun, thanks for

[jira] [Created] (KAFKA-8662) Produce fails if a previous produce was to an unauthorized topic

2019-07-13 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-8662: - Summary: Produce fails if a previous produce was to an unauthorized topic Key: KAFKA-8662 URL: https://issues.apache.org/jira/browse/KAFKA-8662 Project: Kafka

Jenkins build is back to normal : kafka-trunk-jdk11 #695

2019-07-13 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #3786

2019-07-13 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Refactor admin client helpers for checking leader and ISR (#7074) -- [...truncated 2.55 MB...]

Build failed in Jenkins: kafka-trunk-jdk11 #694

2019-07-13 Thread Apache Jenkins Server
See Changes: [github] MINOR: Use dynamic port in `RestServerTest` (#7079) [jason] KAFKA-8614; Consistent naming for IncrementalAlterConfig and AlterConfig --

Build failed in Jenkins: kafka-trunk-jdk8 #3785

2019-07-13 Thread Apache Jenkins Server
See Changes: [github] MINOR: Create a new topic for each test for flaky [matthias] HOT FIX: close RocksDB objects in correct order (#7076) [github] MINOR: Use dynamic port in `RestServerTest` (#7079) [jason]