[jira] [Created] (KAFKA-8914) Setting GROUP_INSTANCE_ID_CONFIG leads to a protobuf error

2019-09-16 Thread Igamr Palsenberg (Jira)
Igamr Palsenberg created KAFKA-8914: --- Summary: Setting GROUP_INSTANCE_ID_CONFIG leads to a protobuf error Key: KAFKA-8914 URL: https://issues.apache.org/jira/browse/KAFKA-8914 Project: Kafka

Re: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-09-16 Thread Maulin Vasavada
Hi Clement/Rajini When I read your responses - I swing between both of your suggestions :) I see both of your points. Let me ponder little bit more and give me take in a day or so. I tend to agree with Clement in a sense that we need to define clear responsibilities of classes. Right now I feel i

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-09-16 Thread Arjun Satish
Answers inline On Mon, Sep 16, 2019 at 5:06 PM Randall Hauch wrote: > Thanks for the updates, Arjun. If possible, it'd be great to have the KIP > clarify a few things: > > 1) IIUC, the loggers returned by the GET methods are only those loggers > that have been activated/used/set in the JVM. If t

Requesting Permission

2019-09-16 Thread Brian Byrne
Hello, I'm requesting permission to the Kafka Wiki, specifically to create a KIP. Wiki ID is 'bbyrne'. Thanks, Brian

Build failed in Jenkins: kafka-trunk-jdk8 #3905

2019-09-16 Thread Apache Jenkins Server
See Changes: [github] MINOR: add unsigned varint support (#7338) [jason] MINOR: Cleanup scala warnings (#7335) -- [...truncated 2.63 MB...] org.apache.kafka.connect.tran

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-09-16 Thread Randall Hauch
Thanks for the updates, Arjun. If possible, it'd be great to have the KIP clarify a few things: 1) IIUC, the loggers returned by the GET methods are only those loggers that have been activated/used/set in the JVM. If this is the case, this should be specified. 2) It's possible to set a log level

Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON

2019-09-16 Thread Randall Hauch
Thanks for the nice improvement, Almog! +1 (binding) Randall On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Thanks Almog! > Nicely designed and concise KIP. > > +1 non-binding > > Konstantine > > On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: >

Re: [DISCUSS] KIP-481: SerDe Improvements for Connect Decimal type in JSON

2019-09-16 Thread Randall Hauch
Thanks for all the changes, Almog. The current KIP looks good to me. Randall On Fri, Aug 30, 2019 at 11:28 AM Almog Gavra wrote: > Thanks again Randall! Here are the changes I made: > > - Defaults. The KIP had mentioned that the default would be BASE64 in the > "Public Interfaces" section. I ha

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-16 Thread Randall Hauch
Thanks for tackling this, Konstantine. The KIP looks great. My only question is about whether to enable the recent MDC variable in the file log format, but for backward compatibility reasons keep it as-is for the console. I suspect using the same format in the log files and the console would be pr

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-09-16 Thread Randall Hauch
On Mon, Sep 16, 2019 at 3:06 PM Chris Egerton wrote: > Hi Randall, > > The new default value for the key size configuration will be "null". I've > clarified this in the KIP. This will still preserve backwards compatibility > and should not be an issue. > Thanks for clarifying this in the KIP.

Re: [DISCUSS] Streams-Broker compatibility regression in 2.2.1 release

2019-09-16 Thread Ismael Juma
+1 to the proposal. Let's also highlight this in the release notes for 2.2.2 and 2.3.0 please. Ismael On Wed, Sep 11, 2019 at 10:23 AM Matthias J. Sax wrote: > Hi, > > recently a user reported an issue upgrading a Kafka Streams application > from 2.2.0 to 2.2.1 (cf > https://mail-archives.apach

Re: [DISCUSS] KIP-524: Allow users to choose config source when describing configs

2019-09-16 Thread Jason Gustafson
Thanks Gwen and Rajini. Since this seems to be a non-controversial change, I'll plan to go ahead with a vote later this week. -Jason On Mon, Sep 16, 2019 at 2:41 AM Rajini Sivaram wrote: > Thanks for the KIP Jason! Good idea. > > On Sun, Sep 15, 2019 at 5:41 AM Gwen Shapira wrote: > > > Ah, gr

Re: [VOTE] KIP-373: Allow users to create delegation tokens for other users

2019-09-16 Thread Ryanne Dolan
+1 non-binding Ryanne On Mon, Sep 16, 2019, 5:11 PM Harsha Ch wrote: > +1 (binding). Thanks for the KIP Viktor > > Thanks, > > Harsha > > On Mon, Sep 16, 2019 at 3:02 AM, Viktor Somogyi-Vass < > viktorsomo...@gmail.com > wrote: > > > > > > > > > Hi All, > > > > > > > > I'd like to bump this aga

Re: [ DISCUSS ] KIP-512:Adding headers to RecordMetaData

2019-09-16 Thread Renuka M
Hi All, The motivation behind this KIP is have info about record in ProducerInterceptor.onAcknowledgement(..), so that we can link record to its metadata which is missing now. Initially we proposed to add headers to RecordMetadata, so that we can link record to its metadata. After thinking little

Build failed in Jenkins: kafka-trunk-jdk11 #814

2019-09-16 Thread Apache Jenkins Server
See Changes: [github] MINOR: add unsigned varint support (#7338) [jason] MINOR: Cleanup scala warnings (#7335) -- [...truncated 2.63 MB...] org.apache.kafka.connect.conve

Re: [DISCUSS] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-16 Thread Jose Armando Garcia Sancio
On Mon, Sep 9, 2019 at 4:00 PM Colin McCabe wrote: > > One solution to consider is adding the clientVersion and clientType to the > request header as optional (tagged) fields. This would let us skip the > extra round trip. I don't think it's that much more messy than having a > separate request

KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-09-16 Thread Nikolay Izhikov
Hello, Kafka team. I implemented KAFKA-8584 [1]. PR - [2] Please, do the review. [1] https://issues.apache.org/jira/browse/KAFKA-8584 [2] https://github.com/apache/kafka/pull/7342 signature.asc Description: This is a digitally signed message part

[jira] [Created] (KAFKA-8913) Document topic based configs & ISR settings for Streams apps

2019-09-16 Thread Vinoth Chandar (Jira)
Vinoth Chandar created KAFKA-8913: - Summary: Document topic based configs & ISR settings for Streams apps Key: KAFKA-8913 URL: https://issues.apache.org/jira/browse/KAFKA-8913 Project: Kafka

Re: [VOTE] KIP-373: Allow users to create delegation tokens for other users

2019-09-16 Thread Harsha Ch
+1 (binding). Thanks for the KIP Viktor Thanks, Harsha On Mon, Sep 16, 2019 at 3:02 AM, Viktor Somogyi-Vass < viktorsomo...@gmail.com > wrote: > > > > Hi All, > > > > I'd like to bump this again in order to get some more binding votes and/or > feedback in the hope we can push this in for

Re: [VOTE] KIP-309: Add toUpperCase support to sasl.kerberos.principal.to.local rule

2019-09-16 Thread Harsha Chintalapani
+1 (binding). Thanks, Harsha On Mon, Sep 16, 2019 at 4:21 AM, Manikumar wrote: > Hi all, > > I would like to start vote on this trivial KIP-309: https://cwiki.apache. > org/confluence/display/KAFKA/KIP > -309%3A+Add+toUpperCase+support+to+sasl.kerberos.principal.to.local+rule > > Thanks, >

[jira] [Created] (KAFKA-8912) TimeoutException cause is insufficiently articulated for the KafkProducer

2019-09-16 Thread Ramkishan (Jira)
Ramkishan created KAFKA-8912: Summary: TimeoutException cause is insufficiently articulated for the KafkProducer Key: KAFKA-8912 URL: https://issues.apache.org/jira/browse/KAFKA-8912 Project: Kafka

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-09-16 Thread Chris Egerton
Hi Randall, The new default value for the key size configuration will be "null". I've clarified this in the KIP. This will still preserve backwards compatibility and should not be an issue. I understand your point about key generation vs MAC signing algorithms; like I said, I'll need to do more r

Re: Delivery Status Notification (Failure)

2019-09-16 Thread David Arthur
And here's a passing build for the 2.3 branch https://builds.apache.org/view/All/job/kafka-2.3-jdk8/108/ On Mon, Sep 16, 2019 at 3:46 PM David Arthur wrote: > And here's a passing build for the 2.3 branch > https://builds.apache.org/view/All/job/kafka-2.3-jdk8/108/ > > On Fri, Sep 13, 2019 at 6:

Re: Request to be added as a contributor

2019-09-16 Thread Shyam P
Thanks Matthias J S On Tue, Sep 17, 2019 at 12:24 AM Matthias J. Sax wrote: > Shyam, > > also check out https://kafka.apache.org/contributing > > > -Matthias > > On 9/16/19 11:51 AM, Jun Rao wrote: > > Hi, Nigel, > > > > Thanks for your interest. Just added you to the contributor list. > > > > H

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-09-16 Thread Randall Hauch
Thanks, Chris. I still have a number of questions and requests for clarification. If we don't provide a default value for the key size, then the following statement in the "Backwards compatibility" subsection is no longer true: "All of the proposed configurations here have default values, making t

Re: Request to be added as a contributor

2019-09-16 Thread Matthias J. Sax
Done. On 9/16/19 1:30 AM, Csenge Virág Maruzsi wrote: > Hi Team, > > I'd like to contribute to Kafka, and would like permissions for that. > Jira username: csenge > Thanks! > > Regards, > Csenge > signature.asc Description: OpenPGP digital signature

Re: Request to be added as a contributor

2019-09-16 Thread Matthias J. Sax
Shyam, also check out https://kafka.apache.org/contributing -Matthias On 9/16/19 11:51 AM, Jun Rao wrote: > Hi, Nigel, > > Thanks for your interest. Just added you to the contributor list. > > Hi, Shyam, > > Thanks for your interest. What's you jira id? > > To get started, you can probably

Re: Request to be added as a contributor

2019-09-16 Thread Jun Rao
Hi, Nigel, Thanks for your interest. Just added you to the contributor list. Hi, Shyam, Thanks for your interest. What's you jira id? To get started, you can probably look for recent jiras labelled with the newbie tag. Jun On Mon, Sep 16, 2019 at 11:38 AM Shyam P wrote: > Me too , want to c

Re: Request to be added as a contributor

2019-09-16 Thread Shyam P
Me too , want to contribute? But not sure where to start ... On Mon, Sep 16, 2019 at 11:05 PM Nigel Liang wrote: > Hi there, > > I'd like to contribute to Kafka, and would like permissions for the > following account: > ASF JIRA: nigel.liang > > Thanks! > -Nigel >

Jenkins build is back to normal : kafka-2.3-jdk8 #108

2019-09-16 Thread Apache Jenkins Server
See

Request to be added as a contributor

2019-09-16 Thread Nigel Liang
Hi there, I'd like to contribute to Kafka, and would like permissions for the following account: ASF JIRA: nigel.liang Thanks! -Nigel

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-16 Thread Harsha Chintalapani
Thanks. +1 LGTM. On Mon, Sep 16, 2019 at 9:19 AM, Kevin Lu wrote: > Hi Harsha, > > Thanks for the feedback. I have added *last-poll-seconds-ago* to the KIP > (being consistent with *last-heartbeat-seconds-ago*). > > Regards, > Kevin > > On Sat, Sep 14, 2019 at 9:44 AM Harsha Chintalapani > wro

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-16 Thread Kevin Lu
Hi Harsha, Thanks for the feedback. I have added *last-poll-seconds-ago* to the KIP (being consistent with *last-heartbeat-seconds-ago*). Regards, Kevin On Sat, Sep 14, 2019 at 9:44 AM Harsha Chintalapani wrote: > Thanks Kevin for the KIP. Overall LGTM. > On you second point, I think the metri

Re: [DISCUSS] KIP-491: Preferred Leader Deprioritized List (Temporary Blacklist)

2019-09-16 Thread Satish Duggana
Hi George, Thanks for explaining the usecase for topic level preferred leader blacklist. As I mentioned earlier, I am fine with broker level config for now. ~Satish. On Sat, Sep 7, 2019 at 12:29 AM George Li wrote: > > Hi, > > Just want to ping and bubble up the discussion of KIP-491. > > On a

RE: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-09-16 Thread Pellerin, Clement
>> Pluggable instances have a default constructor and implement Configurable. >> Why wouldn't we just do that for SslEngineFactory? Because the constructor that you are replacing has more than just a map. You need to pass those extra arguments somewhere. I once proposed to fake extra arguments as s

Re: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-09-16 Thread Rajini Sivaram
I am not sure what the confusion regarding Configurable interface is. Pluggable instances have a default constructor and implement Configurable. Why wouldn't we just do that for SslEngineFactory? We can rename SslEngineFactory.reconfigurableConfigs() if it helps, but basically it is the factory th

[jira] [Created] (KAFKA-8911) Implicit TimeWindowedSerde creates Serde with null inner serializer

2019-09-16 Thread Jira
Michał created KAFKA-8911: - Summary: Implicit TimeWindowedSerde creates Serde with null inner serializer Key: KAFKA-8911 URL: https://issues.apache.org/jira/browse/KAFKA-8911 Project: Kafka Issue Ty

RE: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-09-16 Thread Pellerin, Clement
There are pending issues we need to address. We want to be able to call config.getConfiguredInstance(key, Class) to instantiate the extension point. This requires a default constructor. The former constructor arguments must now be passed in a separate init() method. This has the advantage of mo

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-16 Thread Mickael Maison
+1 (non binding) Thanks for the KIP! On Mon, Sep 16, 2019 at 12:07 PM David Jacot wrote: > > Hi all, > > I would like to start a vote on KIP-511: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-511%3A+Collect+and+Expose+Client%27s+Name+and+Version+in+the+Brokers > > Best, > David

[VOTE] KIP-309: Add toUpperCase support to sasl.kerberos.principal.to.local rule

2019-09-16 Thread Manikumar
Hi all, I would like to start vote on this trivial KIP-309: https://cwiki.apache.org/confluence/display/KAFKA/KIP -309%3A+Add+toUpperCase+support+to+sasl.kerberos.principal.to.local+rule Thanks,

Re: [DISCUSS] Apache Kafka 2.4.0 release

2019-09-16 Thread Manikumar
Hi All, Just a reminder that any new/pending KIP must pass vote by next Wednesday (Sep 25, 2019) to be included in Apache Kafka 2.4.0 release. Also keep in mind that deadline for feature freeze is Oct 2, 2019. In order to be included in the release, major features/KIPs need to be merged and minor

[VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-16 Thread David Jacot
Hi all, I would like to start a vote on KIP-511: https://cwiki.apache.org/confluence/display/KAFKA/KIP-511%3A+Collect+and+Expose+Client%27s+Name+and+Version+in+the+Brokers Best, David

Re: [DISCUSS] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-16 Thread David Jacot
Hi all, I have updated the KIP to reflect the offline discussion that we have had. It seems that we have finally reached a consensus on the approach. Therefore, I will start a vote. Best, David On Wed, Sep 11, 2019 at 3:53 PM David Jacot wrote: > Hi all, > > I have discussed with Magnus about

Re: [DISCUSS] Apache Kafka 2.4.0 release

2019-09-16 Thread Manikumar
Hi Mickael, Yes, we can include. Added KIP-396 to the wiki page for tracking. Thanks, Manikumar On Mon, Sep 16, 2019 at 3:36 PM Mickael Maison wrote: > Hi Manikumar, > > Can we also include KIP-396? > (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=97551484 > ) > It has been

Re: [DISCUSS] Apache Kafka 2.4.0 release

2019-09-16 Thread Mickael Maison
Hi Manikumar, Can we also include KIP-396? (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=97551484) It has been accepted and the PR is ready for review: https://github.com/apache/kafka/pull/7296 Thanks On Mon, Sep 16, 2019 at 10:56 AM Manikumar wrote: > > Hi Viktor, > > Yes,

Re: [VOTE] KIP-373: Allow users to create delegation tokens for other users

2019-09-16 Thread Viktor Somogyi-Vass
Hi All, I'd like to bump this again in order to get some more binding votes and/or feedback in the hope we can push this in for 2.4. Thank you Manikumar, Gabor and Ryanne so far for the votes! (the last two were on the discussion thread after starting the vote but I think it still counts :) ) Th

Re: [DISCUSS] Apache Kafka 2.4.0 release

2019-09-16 Thread Manikumar
Hi Viktor, Yes, we can include KIP-434. Thanks, On Mon, Sep 16, 2019 at 3:09 PM Viktor Somogyi-Vass wrote: > Hi Manikumar, > > Can we please also include KIP-434? > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-434%3A+Add+Replica+Fetcher+and+Log+Cleaner+Count+Metrics > It has been ac

Re: [DISCUSS] KIP-524: Allow users to choose config source when describing configs

2019-09-16 Thread Rajini Sivaram
Thanks for the KIP Jason! Good idea. On Sun, Sep 15, 2019 at 5:41 AM Gwen Shapira wrote: > Ah, great idea. > > On Fri, Sep 13, 2019 at 8:47 AM Jason Gustafson > wrote: > > > > Hi All, > > > > I have a minor KIP to improve the config tool: > > > https://cwiki.apache.org/confluence/display/KAFKA/

Re: [DISCUSS] Apache Kafka 2.4.0 release

2019-09-16 Thread Viktor Somogyi-Vass
Hi Manikumar, Can we please also include KIP-434? https://cwiki.apache.org/confluence/display/KAFKA/KIP-434%3A+Add+Replica+Fetcher+and+Log+Cleaner+Count+Metrics It has been accepted and there is already a pull request under review. Thanks, Viktor On Fri, Sep 6, 2019 at 9:59 AM Manikumar wrote:

[DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-09-16 Thread Mickael Maison
Hi all, I've created a KIP to add listApiVersions support to the AdminClient. This will allow us to update the BrokerApiVersionsCommand tool and more importantly allow users to detect API support and build flexible client applications: https://cwiki.apache.org/confluence/display/KAFKA/KIP-522%3A+U

Re: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-09-16 Thread Rajini Sivaram
Hi Maulin, Thanks for writing that up. I think we are getting close. As an example interface (which can be adjusted as necessary, but just including something here to refer to), I think we would have an interface along these lines: public interface SslEngineFactory extends Configurable, Closeab

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-09-16 Thread Arjun Satish
Good catch, Randall. Yes, we should be able to set the level of any logger given its name. If this is an ancestor, then the levels of all child classes are updated. I updated the KIP to be more explicit about what loggers we can set, and how they affect child classes, if any. Let me know what you

[jira] [Created] (KAFKA-8910) Incorrect javadoc at org.apache.kafka.clients.producer.Callback

2019-09-16 Thread Sergey Ushakov (Jira)
Sergey Ushakov created KAFKA-8910: - Summary: Incorrect javadoc at org.apache.kafka.clients.producer.Callback Key: KAFKA-8910 URL: https://issues.apache.org/jira/browse/KAFKA-8910 Project: Kafka

Request to be added as a contributor

2019-09-16 Thread Csenge Virág Maruzsi
Hi Team, I'd like to contribute to Kafka, and would like permissions for that. Jira username: csenge Thanks! Regards, Csenge