Re: [DISCUSS] KIP-645: Replace abstract class Windows with a proper interface

2020-07-24 Thread Boyang Chen
Thanks for the KIP John. I share a similar concern with the motivation, it would be good if you could cast light on the actual downside of using a base class vs the interface, is it making the code fragile, or requiring redundant implementation, etc. Boyang On Tue, Jul 21, 2020 at 2:19 PM Sophie

Jenkins build is back to normal : kafka-trunk-jdk14 #316

2020-07-24 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #4741

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] MINOR: removed incorrect deprecation annotations (#9061) -- [...truncated 3.18 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Build failed in Jenkins: kafka-trunk-jdk11 #1666

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] MINOR: add task ':streams:testAll' (#9073) [github] MINOR: speed up release script (#9070) [github] MINOR: removed incorrect deprecation annotations (#9061)

Jenkins build is back to normal : kafka-trunk-jdk8 #4740

2020-07-24 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-07-24 Thread Sophie Blee-Goldman
Thanks all, +1 (non-binding) Cheers, Sophie On Wed, Jul 8, 2020 at 4:02 AM Bruno Cadonna wrote: > Thanks Will and Piotr, > > +1 (non-binding) > > Best, > Bruno > > On Wed, Jul 8, 2020 at 8:12 AM Matthias J. Sax wrote: > > > > Thanks for the KIP. > > > > +1 (binding) > > > > > > -Matthias > >

Build failed in Jenkins: kafka-trunk-jdk14 #315

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition -- [...truncated 6.42 MB...]

Build failed in Jenkins: kafka-trunk-jdk11 #1665

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition -- [...truncated 6.41 MB...]

Build failed in Jenkins: kafka-trunk-jdk8 #4739

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition -- [...truncated 3.18 MB...]

Re: [VOTE] 2.6.0 RC1

2020-07-24 Thread John Roesler
Hi Randall, I'm sorry to say we have also identified that this flaky test failure turned out to be a real blocker bug: https://issues.apache.org/jira/browse/KAFKA-10287 There is a PR in progress. Thanks, -John On Fri, Jul 24, 2020, at 12:26, Matthias J. Sax wrote: > We found a regression bug

Re: [DISCUSS] KIP-450: Sliding Windows

2020-07-24 Thread Leah Thomas
To accommodate the change to a final class, I've added another *windowedBy()* function in *CogroupedKStream.java *to handle SlidingWindows. As far as the discussion goes, I think this is the last change we've talked about. If anyone has other comments or concerns, please let me know! Cheers,

[GitHub] [kafka-site] scott-confluent commented on pull request #269: Kafka nav and hompeage redesign

2020-07-24 Thread GitBox
scott-confluent commented on pull request #269: URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663676137 Side note: we need to update 1 video (can be seen on the quickstart screenshots above) before merging this PR

[GitHub] [kafka-site] scott-confluent commented on pull request #269: Kafka nav and hompeage redesign

2020-07-24 Thread GitBox
scott-confluent commented on pull request #269: URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663671641 Here are some screenshots of our new layout including desktop and mobile views. We've made many improvements for mobile devices, too. There are several new pages

Re: [DISCUSS] KIP-595: A Raft Protocol for the Metadata Quorum

2020-07-24 Thread Jun Rao
Hi, Jason, Thanks for the reply. 101. Sounds good. Regarding clusterId, I am not sure storing it in the metadata log is enough. For example, the vote request includes clusterId. So, no one can vote until they know the clusterId. Also, it would be useful to support the case when a voter

Re: [DISCUSS] KIP-607: Add Metrics to Record the Memory Used by RocksDB to Kafka Streams

2020-07-24 Thread Guozhang Wang
Ack, thanks for the clarification folks! Yeah I agree from JVM's point all rocksDB memory are off-heap basically (which makes operations harder, sigh..) Regarding the block cache, my understanding is that by default compressed blocks are in the OS page cache, uncompressed blocks are in the

Re: [VOTE] 2.6.0 RC1

2020-07-24 Thread Matthias J. Sax
We found a regression bug that seems to be a blocker: https://issues.apache.org/jira/browse/KAFKA-10306 Will work on a PR today. -Matthias On 7/22/20 9:40 AM, Randall Hauch wrote: > Any thoughts, Rajini? > > On Mon, Jul 20, 2020 at 9:55 PM Randall Hauch wrote: > >> >> When I was checking

[jira] [Created] (KAFKA-10306) GlobalThread might loop forever

2020-07-24 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-10306: --- Summary: GlobalThread might loop forever Key: KAFKA-10306 URL: https://issues.apache.org/jira/browse/KAFKA-10306 Project: Kafka Issue Type: Bug

[DISCUSS] KIP-647: Add ability to handle late messages in streams-aggregation

2020-07-24 Thread Igor Piddubnyi
Hi everybody, I would like to start off the discussion for KIP-647: https://cwiki.apache.org/confluence/display/KAFKA/KIP-647%3A+Add+ability+to+handle+late+messages+in+streams-aggregation

Re: [VOTE] KIP-607: Add Metrics to Record the Memory Used by RocksDB to Kafka Streams

2020-07-24 Thread John Roesler
Thanks, Bruno! I'm +1 (binding) -John On Fri, Jul 24, 2020, at 07:04, Bruno Cadonna wrote: > Hi, > > After re-opening the discussion about > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-607%3A+Add+Metrics+to+Kafka+Streams+to+Report+Properties+of+RocksDB > > I would like to re-open

Re: [VOTE] KIP-607: Add Metrics to Record the Memory Used by RocksDB to Kafka Streams

2020-07-24 Thread Bruno Cadonna
Hi, After re-opening the discussion about https://cwiki.apache.org/confluence/display/KAFKA/KIP-607%3A+Add+Metrics+to+Kafka+Streams+to+Report+Properties+of+RocksDB I would like to re-open the voting for this KIP. The discussion thread can be found here:

Re: [DISCUSS] KIP-607: Add Metrics to Record the Memory Used by RocksDB to Kafka Streams

2020-07-24 Thread Bruno Cadonna
Hi Guozhang and Sophie, 1) My understanding is also that the memtables are off-heap (as almost every data structure in RocksDB). According to the docs, if after a write the size of the memtable exceeds option write_buffer_size the memtable is flushed. I would not call it hard bounded since

Build failed in Jenkins: kafka-trunk-jdk11 #1664

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10268: dynamic config like "--delete-config log.retention.ms" -- [...truncated 6.41 MB...] org.apache.kafka.streams.test.OutputVerifierTest

Build failed in Jenkins: kafka-trunk-jdk8 #4738

2020-07-24 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10268: dynamic config like "--delete-config log.retention.ms" -- [...truncated 6.36 MB...] org.apache.kafka.streams.test.OutputVerifierTest

Re: [DISCUSS] KIP-631: The Quorum-based Kafka Controller

2020-07-24 Thread Boyang Chen
Hey Colin, some more questions I have about the proposal: 1. We mentioned in the networking section that "The only time when clients should contact a controller node directly is when they are debugging system issues". But later we didn't talk about how to enable this debug mode, could you