Re: [DISCUSS] KIP-712: Shallow Mirroring

2021-03-28 Thread Ryanne Dolan
Ismael, I don't think KIP-98 is related. Shallow iteration was removed in KAFKA-732, which predates KIP-98 by a few years. Ryanne On Sun, Mar 28, 2021, 11:25 PM Ismael Juma wrote: > Thanks for the KIP. I have a few high level comments: > > 1. Like Tom, I'm not convinced about the proposal to

Build failed in Jenkins: Kafka » kafka-trunk-jdk11 #641

2021-03-28 Thread Apache Jenkins Server
See Changes: [github] KAFKA-7106: remove deprecated Windows APIs (#10378) -- [...truncated 3.67 MB...] ControllerEventManagerTest >

Re: [DISCUSS] KIP-712: Shallow Mirroring

2021-03-28 Thread Ismael Juma
Thanks for the KIP. I have a few high level comments: 1. Like Tom, I'm not convinced about the proposal to make this change to MirrorMaker 1 if we intend to deprecate it and remove it. I would rather us focus our efforts on the implementation we intend to support going forward. 2. The

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-03-28 Thread Ismael Juma
Thanks for the KIP. Are we saying that every consumer upgraded would have to follow the complex path described in the KIP? Also, what happens if they don't read the instructions and upgrade as they have in the past? Ismael On Fri, Mar 26, 2021, 1:53 AM Luke Chen wrote: > Hi everyone, > > >

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-03-28 Thread Luke Chen
Hi Sophie, Thanks for your good suggestion. I've updated in the KIP-726. Thank you. Luke On Sat, Mar 27, 2021 at 3:24 AM Sophie Blee-Goldman wrote: > Thanks for the KIP! I'm 100% on board with this (obviously :P) and the KIP > itself looks good to me > overall. Just one clarification I think

[GitHub] [kafka-site] Alee4738 commented on pull request #338: MINOR quickstart.html remove extra closing paren, fix syntax

2021-03-28 Thread GitBox
Alee4738 commented on pull request #338: URL: https://github.com/apache/kafka-site/pull/338#issuecomment-809001496 @mjsax yup, PR made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-12569) Clean up usage of commit flags in StateMachineTask

2021-03-28 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12569: -- Summary: Clean up usage of commit flags in StateMachineTask Key: KAFKA-12569 URL: https://issues.apache.org/jira/browse/KAFKA-12569 Project: Kafka

[GitHub] [kafka-site] hachikuji merged pull request #342:  Please add Knoldus Inc. (https://www.knoldus.com/) to the list of the "Powered By ❤️".

2021-03-28 Thread GitBox
hachikuji merged pull request #342: URL: https://github.com/apache/kafka-site/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

Build failed in Jenkins: Kafka » kafka-trunk-jdk15 #672

2021-03-28 Thread Apache Jenkins Server
See Changes: [github] MINOR: update Streams upgrade notes with removed APIs (#10420) [github] MINOR: fix the wrong/missing anchor in docs caused link error (#10413)

[GitHub] [kafka-site] mimaison commented on pull request #341: MINOR: Fix typo in MirrorMaker v2 documentation

2021-03-28 Thread GitBox
mimaison commented on pull request #341: URL: https://github.com/apache/kafka-site/pull/341#issuecomment-808951896 @AdilHoumadi Can you also open a PR to fix it in https://github.com/apache/kafka ? It's this file: https://github.com/apache/kafka/blob/trunk/docs/ops.html Thanks --

[GitHub] [kafka-site] mimaison merged pull request #341: MINOR: Fix typo in MirrorMaker v2 documentation

2021-03-28 Thread GitBox
mimaison merged pull request #341: URL: https://github.com/apache/kafka-site/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka-site] mjsax commented on pull request #338: MINOR quickstart.html remove extra closing paren, fix syntax

2021-03-28 Thread GitBox
mjsax commented on pull request #338: URL: https://github.com/apache/kafka-site/pull/338#issuecomment-808950413 @Alee4738 Thanks for the PR. Seems this need to be fixed in `kafka.git`, too. Can you do a second PR for it? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka-site] mjsax commented on pull request #341: MINOR: Fix typo in MirrorMaker v2 documentation

2021-03-28 Thread GitBox
mjsax commented on pull request #341: URL: https://github.com/apache/kafka-site/pull/341#issuecomment-808950270 @mimaison Can you review and merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] mjsax commented on pull request #297: MINOR: fix for example implementation of how to add a new header to the record

2021-03-28 Thread GitBox
mjsax commented on pull request #297: URL: https://github.com/apache/kafka-site/pull/297#issuecomment-808949608 @SanjayYr Does this need to be fixed in `kafka.git` and other versions, too? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka-site] mjsax commented on pull request #296: MINOR: fix for extra line break in streams processor API documentation

2021-03-28 Thread GitBox
mjsax commented on pull request #296: URL: https://github.com/apache/kafka-site/pull/296#issuecomment-808949468 @SanjayYr Does this need to be fixed in `kafka.git`, too, and also for newer version? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka-site] mjsax commented on pull request #236: MINOR fix description about whether internal topics respect broker defaults

2021-03-28 Thread GitBox
mjsax commented on pull request #236: URL: https://github.com/apache/kafka-site/pull/236#issuecomment-808949290 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #219: highlight 2.3 inter.broker.protocol breaking change

2021-03-28 Thread GitBox
mjsax closed pull request #219: URL: https://github.com/apache/kafka-site/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #219: highlight 2.3 inter.broker.protocol breaking change

2021-03-28 Thread GitBox
mjsax commented on pull request #219: URL: https://github.com/apache/kafka-site/pull/219#issuecomment-808949263 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #236: MINOR fix description about whether internal topics respect broker defaults

2021-03-28 Thread GitBox
mjsax closed pull request #236: URL: https://github.com/apache/kafka-site/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax closed pull request #214: Add Bangalore Kafka Meetup to the events page

2021-03-28 Thread GitBox
mjsax closed pull request #214: URL: https://github.com/apache/kafka-site/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #214: Add Bangalore Kafka Meetup to the events page

2021-03-28 Thread GitBox
mjsax commented on pull request #214: URL: https://github.com/apache/kafka-site/pull/214#issuecomment-808949225 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax commented on pull request #210: Fixes #8198 KStreams testing docs use non-existent method pipe

2021-03-28 Thread GitBox
mjsax commented on pull request #210: URL: https://github.com/apache/kafka-site/pull/210#issuecomment-808949211 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #210: Fixes #8198 KStreams testing docs use non-existent method pipe

2021-03-28 Thread GitBox
mjsax closed pull request #210: URL: https://github.com/apache/kafka-site/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

Re: [GitHub] [kafka-site] mjsax commented on pull request #156: MINOR increasing queued.max.requests for production recommendations in 0.9 and newer.

2021-03-28 Thread M. Manna
Unsubscribe On Sun, 28 Mar 2021 at 20:44, GitBox wrote: > > mjsax commented on pull request #156: > URL: https://github.com/apache/kafka-site/pull/156#issuecomment-808948878 > > >Closing this PR as abandoned. (We can reopen if necessary.) > > > -- > This is an automated message from the

[GitHub] [kafka-site] mjsax closed pull request #179: MINOR small syntax / typo fix

2021-03-28 Thread GitBox
mjsax closed pull request #179: URL: https://github.com/apache/kafka-site/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #179: MINOR small syntax / typo fix

2021-03-28 Thread GitBox
mjsax commented on pull request #179: URL: https://github.com/apache/kafka-site/pull/179#issuecomment-808949082 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #156: MINOR increasing queued.max.requests for production recommendations in 0.9 and newer.

2021-03-28 Thread GitBox
mjsax closed pull request #156: URL: https://github.com/apache/kafka-site/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #156: MINOR increasing queued.max.requests for production recommendations in 0.9 and newer.

2021-03-28 Thread GitBox
mjsax commented on pull request #156: URL: https://github.com/apache/kafka-site/pull/156#issuecomment-808948878 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #143: [KAFKA-4559] Add a site search bar on the Web site

2021-03-28 Thread GitBox
mjsax closed pull request #143: URL: https://github.com/apache/kafka-site/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #143: [KAFKA-4559] Add a site search bar on the Web site

2021-03-28 Thread GitBox
mjsax commented on pull request #143: URL: https://github.com/apache/kafka-site/pull/143#issuecomment-808948835 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #124: Adding 2 new streams use case logo

2021-03-28 Thread GitBox
mjsax closed pull request #124: URL: https://github.com/apache/kafka-site/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #124: Adding 2 new streams use case logo

2021-03-28 Thread GitBox
mjsax commented on pull request #124: URL: https://github.com/apache/kafka-site/pull/124#issuecomment-808948806 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax commented on pull request #110: Add missing close parenthesis

2021-03-28 Thread GitBox
mjsax commented on pull request #110: URL: https://github.com/apache/kafka-site/pull/110#issuecomment-808948746 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #110: Add missing close parenthesis

2021-03-28 Thread GitBox
mjsax closed pull request #110: URL: https://github.com/apache/kafka-site/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka-site] mjsax commented on pull request #61: Removed hyphens:auto.

2021-03-28 Thread GitBox
mjsax commented on pull request #61: URL: https://github.com/apache/kafka-site/pull/61#issuecomment-808948702 Closing this PR as abandoned. (We can reopen if necessary.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] mjsax closed pull request #61: Removed hyphens:auto.

2021-03-28 Thread GitBox
mjsax closed pull request #61: URL: https://github.com/apache/kafka-site/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (KAFKA-7106) Remove segment/segmentInterval from Window definition

2021-03-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7106. -- Resolution: Fixed > Remove segment/segmentInterval from Window definition >

[jira] [Resolved] (KAFKA-12562) Remove deprecated-overloaded "KafkaStreams#metadataForKey" and "KafkaStreams#store"

2021-03-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12562. --- Resolution: Fixed > Remove deprecated-overloaded "KafkaStreams#metadataForKey" and >

[GitHub] [kafka-site] Ambuj8105 edited a comment on pull request #342:  Please add Knoldus Inc. (https://www.knoldus.com/) to the list of the "Powered By ❤️".

2021-03-28 Thread GitBox
Ambuj8105 edited a comment on pull request #342: URL: https://github.com/apache/kafka-site/pull/342#issuecomment-808821955 Hi @hachikuji could you please review this pr and add Knoldus Inc to powered-by page . -- This is an automated message from the Apache Git Service. To respond to